Skip to content

Fix README images + breaking change links#188183

Merged
auto-submit[bot] merged 2 commits into
flutter:masterfrom
loic-sharma:readme_images
Jun 19, 2026
Merged

Fix README images + breaking change links#188183
auto-submit[bot] merged 2 commits into
flutter:masterfrom
loic-sharma:readme_images

Conversation

@loic-sharma

@loic-sharma loic-sharma commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 18, 2026
@github-actions github-actions Bot added c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. d: docs/ flutter/flutter/docs, for contributors labels Jun 18, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jun 18, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several documentation and image URLs in README.md and Tree-hygiene.md to point to the new sites/docs path. Feedback is provided regarding an accidentally added raw URL in README.md that should be removed to prevent it from rendering as plain text.

Comment thread README.md Outdated
@loic-sharma loic-sharma requested a review from parlough June 18, 2026 18:49
@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 18, 2026
parlough
parlough approved these changes Jun 18, 2026
View reviewed changes

@parlough parlough left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @loic-sharma. I didn't think about these image references.

Not necessary for this PR, but perhaps the images relied on in the README should be moved to https://github.com/flutter/assets-for-api-docs (like https://github.com/flutter/assets-for-api-docs/tree/main/assets/wiki)? So unrelated moves in the flutter/website repository don't break the README.

@loic-sharma loic-sharma added the CICD Run CI/CD label Jun 18, 2026
@loic-sharma

loic-sharma commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

Not necessary for this PR, but perhaps the images relied on in the README should be moved to https://github.com/flutter/assets-for-api-docs (like https://github.com/flutter/assets-for-api-docs/tree/main/assets/wiki)? So unrelated moves in the flutter/website repository don't break the README.

That seems reasonable to me 👍

@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 19, 2026
@auto-submit auto-submit Bot added this pull request to the merge queue Jun 19, 2026
Merged via the queue into flutter:master with commit b72d370 Jun 19, 2026
23 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 19, 2026
This was referenced Jun 20, 2026
Closed
Closed
Closed
Closed
Merged
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Jun 22, 2026
@engine-flutter-autoroll
Roll Flutter from 707e50f2f9e4 to e228771afe93 (7 revisions) (#11957)
ae845e8 
flutter/flutter@707e50f...e228771

2026-06-22 engine-flutter-autoroll@skia.org Roll Dart SDK from db809705a766 to a748c4b15399 (1 revision) (flutter/flutter#188299)
2026-06-21 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from EDJJZ2-lBofQrjK5J... to Lm76V7lvxVA0r1De5... (flutter/flutter#188281)
2026-06-20 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 9E-AJV4lUJH_Fmw66... to EDJJZ2-lBofQrjK5J... (flutter/flutter#188275)
2026-06-20 engine-flutter-autoroll@skia.org Roll Dart SDK from abd7e9ec2603 to db809705a766 (1 revision) (flutter/flutter#188269)
2026-06-19 737941+loic-sharma@users.noreply.github.com Fix README images + breaking change links (flutter/flutter#188183)
2026-06-19 engine-flutter-autoroll@skia.org Roll Dart SDK from ae150461f388 to abd7e9ec2603 (1 revision) (flutter/flutter#188254)
2026-06-19 engine-flutter-autoroll@skia.org Roll Packages from 4fd05e6 to c516c92 (1 revision) (flutter/flutter#188261)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
via-guy pushed a commit to via-guy/flutter that referenced this pull request Jun 26, 2026
@loic-sharma @via-guy
Fix README images + breaking change links (flutter#188183)
da50426 
Fix: flutter#188154

See: flutter/website#13338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parlough parlough parlough approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. CICD Run CI/CD d: docs/ flutter/flutter/docs, for contributors framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The image links in the README are broken.

2 participants

@loic-sharma @parlough