Ensure that directory names are typed as strings in the CIPD package YAML file generated by merge_and_upload_debug_symbols.py#187813
Merged
Conversation
…YAML file generated by merge_and_upload_debug_symbols.py This script is writing a YAML file that is used to create a CIPD package containing Fuchsia debug symbols. The YAML spec references subdirectories in Fuchsia's .build-id directory. .build-id contains binaries indexed by the binary's hash. The name of each subdirectory in .build-id is the first two hex digits of the hash. If the subdirectory name contains two digits starting with a zero, then the YAML entry will look like "dir: 01". YAML will interpret the value as the integer 1, which will not match the actual directory name of "01". CIPD will thus fail to create the package. This PR fixes the YAML so that the directory names are quoted as strings. See flutter#187806
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
b-luk
approved these changes
Jun 10, 2026
Contributor
|
autosubmit label was removed for flutter/flutter/187813, because - The status or check suite Linux mac_android_aot_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
10 tasks
Contributor
|
autosubmit label was removed for flutter/flutter/187813, because - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
Contributor
|
autosubmit label was removed for flutter/flutter/187813, because - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 11, 2026
flutter/flutter@c0a1129...8bdce07 2026-06-11 bernaferrari2@gmail.com Make shape border lerp symmetric (flutter/flutter#187282) 2026-06-11 matt.kosarek@canonical.com Sized to content for regular and dialog windows on win32 (flutter/flutter#186829) 2026-06-11 jason-simmons@users.noreply.github.com Ensure that directory names are typed as strings in the CIPD package YAML file generated by merge_and_upload_debug_symbols.py (flutter/flutter#187813) 2026-06-11 stuartmorgan@google.com Add core-packages to ecosystem triage (flutter/flutter#187796) 2026-06-11 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 8azSyvz57mKcPqTwk... to 2KosSR4ONUjIB7tP_... (flutter/flutter#187842) 2026-06-11 ishaquehassan@gmail.com Document moveStep direction on WidgetController.dragUntilVisible (flutter/flutter#186943) 2026-06-11 ahmedsameha1@gmail.com Add more 0x0 size tests part 11 (flutter/flutter#186822) 2026-06-10 kumarshivam72@gmail.com Fix ShapeDecoration.lerp crash when interpolating between gradient and color (flutter/flutter#187368) 2026-06-10 codedoctor@linwood.dev Reland "Add support for stylus buttons" (flutter/flutter#187629) 2026-06-10 tanyabouman@gmail.com Api docs: typo fix in Navigator (flutter/flutter#187572) 2026-06-10 engine-flutter-autoroll@skia.org Roll Packages from bd297cf to 1b56cde (4 revisions) (flutter/flutter#187784) 2026-06-10 116356835+AbdeMohlbi@users.noreply.github.com Improve docs on MediaQuery: highContrast, invertColors and disableAnimations (flutter/flutter#186614) 2026-06-10 matt.boetger@gmail.com [Android] Test to verify AnnounceSemanticsEvent deprecation warning on API 36 (flutter/flutter#187754) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
via-guy
pushed a commit
to via-guy/flutter
that referenced
this pull request
Jun 26, 2026
…YAML file generated by merge_and_upload_debug_symbols.py (flutter#187813) This script is writing a YAML file that is used to create a CIPD package containing Fuchsia debug symbols. The YAML spec references subdirectories in Fuchsia's .build-id directory. .build-id contains binaries indexed by the binary's hash. The name of each subdirectory in .build-id is the first two hex digits of the hash. If the subdirectory name contains two digits starting with a zero, then the YAML entry will look like "dir: 01". YAML will interpret the value as the integer 1, which will not match the actual directory name of "01". CIPD will thus fail to create the package. This PR fixes the YAML so that the directory names are quoted as strings. See flutter#187806
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This script is writing a YAML file that is used to create a CIPD package containing Fuchsia debug symbols. The YAML spec references subdirectories in Fuchsia's .build-id directory.
.build-id contains binaries indexed by the binary's hash. The name of each subdirectory in .build-id is the first two hex digits of the hash.
If the subdirectory name contains two digits starting with a zero, then the YAML entry will look like "dir: 01". YAML will interpret the value as the integer 1, which will not match the actual directory name of "01". CIPD will thus fail to create the package.
This PR fixes the YAML so that the directory names are quoted as strings.
See #187806