Remove many absolute paths from build commands.#187765
Conversation
356a90b to
e0fca14
Compare
e0fca14 to
d43204f
Compare
d43204f to
170f62c
Compare
There was a problem hiding this comment.
Code Review
This pull request updates various GN build files to pass root_build_dir as the second argument to rebase_path(), ensuring paths are rebased consistently relative to the build directory. It also removes the unused canonical_path helper function in create_macos_binary.py. Feedback suggests replacing a relative path traversal (../../../) with the standard GN source root identifier (//) in engine/src/flutter/lib/snapshot/BUILD.gn to improve robustness.
|
from triage: @gaaclarke you dont need to review only find someone with engine rbe experience to review on behalf of the engine. |
gaaclarke
left a comment
There was a problem hiding this comment.
This PR does what it says it will do, that aspect looks good to me.
but it is easier to verify the whole build.
Are we going to verify this somehow? That seems hard to do. What is stopping the next guy from introducing abs paths, and does it matter if there is no discernible difference?
I don't know if it's wise to try to enforce this if it isn't enforced somehow technically and has no difference to the process.
It's actually straightforward to check for the working directory in the full command list. I have the Dart build fully fixed and automatically verified. There are still some broken commands in Flutter where the naive fix seems to break the build, so I can't yet add such a check here, but manual inspection of the build log is much easier now. I also haven't found wherever Flutter is doing an incremental build check, which is the natural place to add the new check. |
gaaclarke
left a comment
There was a problem hiding this comment.
lgtm modulo filing an issue for the follow up of automated verification, sounds like we have a way to do that.
|
An existing Git SHA, To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with |
|
autosubmit label was removed for flutter/flutter/187765, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
170f62c to
596b725
Compare
Relative paths are prefered for reproducible builds.
596b725 to
74c2014
Compare
flutter/flutter@e228771...87224e0 2026-06-23 engine-flutter-autoroll@skia.org Roll Dart SDK from 5cae7f9ada62 to 3a66ea7b9aaa (1 revision) (flutter/flutter#188379) 2026-06-23 engine-flutter-autoroll@skia.org Roll Dart SDK from 1e6c246bb73a to 5cae7f9ada62 (2 revisions) (flutter/flutter#188370) 2026-06-23 engine-flutter-autoroll@skia.org Roll Skia from 766f21ae61dc to ffac3e91fbc7 (24 revisions) (flutter/flutter#188366) 2026-06-23 737941+loic-sharma@users.noreply.github.com [Windows] Add public API to post task to platform thread (flutter/flutter#187365) 2026-06-23 engine-flutter-autoroll@skia.org Roll Dart SDK from 7ab0179ce4d4 to 1e6c246bb73a (1 revision) (flutter/flutter#188354) 2026-06-23 robert.ancell@canonical.com Fix byte/character offset confusion in FlAccessibleTextField (flutter/flutter#188138) 2026-06-22 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Lm76V7lvxVA0r1De5... to RymJjIj7dd5vQ3Cnh... (flutter/flutter#188353) 2026-06-22 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#188355) 2026-06-22 154381524+flutteractionsbot@users.noreply.github.com Sync CHANGELOG.md from stable (flutter/flutter#188331) 2026-06-22 engine-flutter-autoroll@skia.org Roll Skia from 5fbb9bbd889c to 766f21ae61dc (2 revisions) (flutter/flutter#188184) 2026-06-22 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 6.0.3 to 7.0.0 in the all-github-actions group (flutter/flutter#188350) 2026-06-22 robert.ancell@canonical.com Use g_signal_connect_object in the Linux embedder (flutter/flutter#188241) 2026-06-22 robert.ancell@canonical.com Disconnect from parent window signal when view is destroyed (flutter/flutter#185521) 2026-06-22 rmacnak@google.com Remove many absolute paths from build commands. (flutter/flutter#187765) 2026-06-22 haiderqadir.hq@gmail.com Fix spelling mistake in documentation (wether → whether) (flutter/flutter#186141) 2026-06-22 engine-flutter-autoroll@skia.org Roll Dart SDK from a748c4b15399 to 7ab0179ce4d4 (2 revisions) (flutter/flutter#188332) 2026-06-22 robert.ancell@canonical.com [Linux] Move compositor shader into its own GObject (flutter/flutter#188144) 2026-06-22 bkonyi@google.com Add agent skills for orchestrating cherry-picks to stable and beta channels (flutter/flutter#187860) 2026-06-22 engine-flutter-autoroll@skia.org Roll Packages from c516c92 to cd5194a (1 revision) (flutter/flutter#188312) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Relative paths are preferred for reproducible builds. They are also needed for remote build steps. The current RBE steps (only clang compiles) are already free of absolute paths, but it is easier to verify the whole build.
Relative paths are preferred for reproducible builds.
They are also needed for remote build steps. The current RBE steps (only clang compiles) are already free of absolute paths, but it is easier to verify the whole build.