Skip to content

[AGP 9] Support enabled built in kotlin#187534

Closed
jesswrd wants to merge 30 commits into
flutter:masterfrom
jesswrd:support-enabled-built-in-kotlin
Closed

[AGP 9] Support enabled built in kotlin#187534
jesswrd wants to merge 30 commits into
flutter:masterfrom
jesswrd:support-enabled-built-in-kotlin

Conversation

@jesswrd

@jesswrd jesswrd commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Add support for enabling built-in Kotlin.

Fixes #187712

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 3, 2026
@github-actions github-actions Bot added platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Jun 3, 2026
@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 4, 2026
@jesswrd jesswrd added the CICD Run CI/CD label Jun 4, 2026
@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 5, 2026
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 8, 2026
@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 9, 2026
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 9, 2026
@jesswrd jesswrd changed the title [WIP] [AGP 9] Support enabled built in kotlin [AGP 9] Support enabled built in kotlin Jun 9, 2026
@jesswrd jesswrd added CICD Run CI/CD and removed CICD Run CI/CD labels Jun 9, 2026
@fluttergithubbot

Copy link
Copy Markdown
Contributor

An existing Git SHA, 3bae9cdcbe5a0ded32c94f36bedaa9354407f704, was detected, and no actions were taken.

To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with --force) that already was pushed before, push a blank commit (git commit --allow-empty -m "Trigger Build") or rebase to continue.

@jesswrd jesswrd marked this pull request as ready for review June 9, 2026 00:45
@jesswrd jesswrd requested a review from a team as a code owner June 9, 2026 00:45
@jesswrd jesswrd removed the request for review from a team June 9, 2026 00:45
@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 9, 2026
@jesswrd

jesswrd commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

Can you add some kt doc to your new methods and classes to help with readability

done

@jesswrd jesswrd requested a review from reidbaker June 10, 2026 06:09
@jesswrd jesswrd added the CICD Run CI/CD label Jun 10, 2026
@bkonyi bkonyi added the team-android Owned by Android platform team label Jun 10, 2026
@github-actions github-actions Bot removed team-android Owned by Android platform team CICD Run CI/CD labels Jun 12, 2026
@jesswrd jesswrd marked this pull request as draft June 12, 2026 22:30
@jesswrd jesswrd added the CICD Run CI/CD label Jun 12, 2026
@flutter-dashboard

Copy link
Copy Markdown

This pull request is not mergeable in its current state, likely because of a merge conflict. Pre-submit CI jobs were not triggered. Pushing a new commit to this branch that resolves the issue will result in pre-submit jobs being scheduled.

@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 23, 2026
@jesswrd jesswrd added the CICD Run CI/CD label Jun 23, 2026
@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 23, 2026
@jesswrd jesswrd added the CICD Run CI/CD label Jun 23, 2026
@jesswrd

jesswrd commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Decided to close pull request. Trying to split this into smaller PRs due to CP.

  1. Should not log when AGP < 9 (must be CP'ed to stable and beta)
  2. Supports Enabling Built-in Kotlin (can be CP'ed to stable and beta)
  3. Major test refactoring (may have to be a part of 2).

@jesswrd jesswrd closed this Jun 23, 2026
pull Bot pushed a commit to TheRakeshPurohit/flutter that referenced this pull request Jun 26, 2026
Warnings to migrate to built-in kotlin should not log when AGP is below
9. This should be CP'ed to the current stable and beta. This is an
effort to split this large PR:
flutter#187534 (comment)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

If this change needs to override an active code freeze, provide a
comment explaining why. The code freeze workflow can be overridden by
code reviewers. See pinned issues for any active code freezes with
guidance.

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AGP 9] Add Support To Enable Built-in Kotlin

4 participants