Roll dart sdk to 3.13.0-101.0.dev#186148
Conversation
There was a problem hiding this comment.
Code Review
This pull request replaces InternetAddress with InterfaceAddress in the NetworkInterface class and updates the corresponding test mocks. The review identified several critical issues, including the accidental removal of InternetAddress from the import list and a missing namespace prefix, both of which will cause compilation errors. Additionally, the mock implementation of InterfaceAddress is incomplete and incorrectly structured, as it lacks required getters and incorrectly inherits members from the wrong interface.
I am having trouble creating individual review comments. Click here to see my feedback.
packages/flutter_tools/lib/src/base/io.dart (40)
The InternetAddress class should not be removed from the show list. It is a fundamental class used throughout the Flutter tool, and removing it will cause compilation errors in any code that references io.InternetAddress (including within this file if it is used elsewhere).
InterfaceAddress,
InternetAddress,packages/flutter_tools/test/commands.shard/hermetic/proxy_validator_test.dart (250)
The FakeInterfaceAddress class is missing the required address getter from the io.InterfaceAddress interface. Additionally, it still contains members like type (at line 277) which are part of the InternetAddress interface but not InterfaceAddress.
Note that InterfaceAddress is a wrapper that contains an InternetAddress, it does not replace it. You should likely keep FakeInternetAddress and have FakeInterfaceAddress wrap an instance of it to correctly mock the new API.
packages/flutter_tools/test/commands.shard/hermetic/proxy_validator_test.dart (283)
The InternetAddress type is missing the io. prefix. Since the library is imported with the io prefix (as seen at line 277), this will result in a compilation error.
io.InternetAddress? get broadcast => throw UnimplementedError();
Changes since last roll ``` 4ef36dbcd3c Version 3.13.0-101.0.dev c5a57427d18 [ CLI ] Add support for modifying the environment from package:dartdev 5c3fb10feaa [gardening] Fix fuchsia bot after broadcast InterfaceAddress changes. e1cacdc23a6 Add a fix when an extension or mixin has a primary constructor 4db21a5827e Version 3.13.0-100.0.dev 00cda4d60fa [ffi/isolate_group] Move IsolateGroupBound callbacks from isolate to isolate group. b10062cbbf8 [dart2wasm] Synthesize null when calling JS functions without result, Remove inlining in js interop transformer 688133cc2cb Version 3.13.0-99.0.dev 449fa5a99e7 Version 3.13.0-98.0.dev 6dd8ad53977 Add InterfaceAddress for broadcast address support 4d6c9b756c8 fix: reject Set-Cookie with SameSite=None but no Secure attribute 9c5d1115566 [CFE] Convert import uri to file uri when there's no package config f8b363a3356 CQ. Format test_runner/ e534602bd5b [DEPS] Update d8/jsshell/jsc ``` Contains changes to flutter tools to accommodate breaking change to InternetAddress, introduction of InterfaceAddress.
55cd7d6 to
a719759
Compare
|
Obsolete by #186131 |
Changes since last roll
Contains changes to flutter tools to accommodate breaking change to InternetAddress, introduction of InterfaceAddress.