Roll Dart 3.13 beta1 into Flutter#186131
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request updates the addresses getter in NetworkInterface to return List<io.InterfaceAddress> instead of List<io.InternetAddress>. The reviewer highlighted that this is a breaking change requiring updates to existing callers to avoid type errors and noted that the addresses getter is missing the required documentation comment.
5d3aaa7 to
2856cdc
Compare
2856cdc to
b793991
Compare
b793991 to
c998340
Compare
c998340 to
8290521
Compare
a76609d to
05cb325
Compare
05cb325 to
2d0fa07
Compare
2d0fa07 to
9bdd017
Compare
9bdd017 to
446bbb3
Compare
446bbb3 to
d74e288
Compare
Changes: http://dart.googlesource.com/sdk/+log/28ef48b..a0451fb Manually fix flutter_tools and proxy_validator_test after https://dart-review.googlesource.com/c/sdk/+/492180.
d74e288 to
339f242
Compare
http://dart.googlesource.com/sdk/+log/28ef48b..a0451fb
Manually fix flutter_tools after
https://dart-review.googlesource.com/c/sdk/+/492180.