And static library and impellerc binary to impeller_sdk#185996
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request updates the Impeller interop build configuration by splitting the library target into shared and static versions and including both, along with the impellerc compiler, in the SDK zip bundle. A duplicate platform check was identified in the dependencies for the SDK bundle, which also missed the Windows platform required for the compiler binary.
|
@lzm-build please check out the comment above about signing the CLA. |
|
@gaaclarke OK, the relevant info has been updated. |
The currently prebuilt impeller_sdk.zip contains only dynamic libraries, which makes it inconvenient for use with binding of some other programming languages. Therefore, add static libraries and the impellerc executable to it.