Skip to content

Roll Dart SDK from 25910e31a6d2 to 6fda0523c6c5 (1 revision)#185773

Closed
engine-flutter-autoroll wants to merge 1 commit into
flutter:masterfrom
engine-flutter-autoroll:dart-sdk-flutter-9bd45688-7e71-4560-90b8-f548f22c83cb-1777492790
Closed

Roll Dart SDK from 25910e31a6d2 to 6fda0523c6c5 (1 revision)#185773
engine-flutter-autoroll wants to merge 1 commit into
flutter:masterfrom
engine-flutter-autoroll:dart-sdk-flutter-9bd45688-7e71-4560-90b8-f548f22c83cb-1777492790

Conversation

@engine-flutter-autoroll

Copy link
Copy Markdown
Contributor

https://dart.googlesource.com/sdk.git/+log/25910e31a6d2..6fda0523c6c5

2026-04-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.13.0-80.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC bensonluk@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://dart.googlesource.com/sdk.git/+log/25910e31a6d2..6fda0523c6c5

2026-04-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.13.0-80.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC bensonluk@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@engine-flutter-autoroll engine-flutter-autoroll added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 29, 2026
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Apr 29, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@github-actions github-actions Bot added the engine flutter/engine related. See also e: labels. label Apr 29, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 29, 2026
@auto-submit

auto-submit Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/185773, because - The status or check suite Linux customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@engine-flutter-autoroll

Copy link
Copy Markdown
Contributor Author

Commit queue failed; closing this roll.

auto-submit Bot pushed a commit to flutter/tests that referenced this pull request Apr 30, 2026
Fixes failing Dart to Flutter [autoroller](flutter/flutter#185773).

[Failure log](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8683154551376454241/+/u/run_test.dart_for_customer_testing_shard_and_subshard_None/stdout)
```
| Analyzing devtools_app...
|
| warning - test/shared/eval_integration_test.dart:123:43 - A value of type 'Object?' can't be returned by the 'onError' handler because it must be assignable to 'FutureOr<FutureFailedException>', as required by 'Future.then'. - invalid_return_type_for_then
|
| 1 issue found.
```

Caused by a new analyzer warning: https://dart-review.googlesource.com/c/sdk/+/498240

eval_integration_test.dart was [updated 2 weeks ago](flutter/devtools@e439571#diff-d7c828cbc9f16c59e1193c5a9f816177e84619072686c4d41715f9882d0c188cL123) to fix the problematic line.

This updates the git hash used for flutter/devtools customer testing to incorporate this change.
pull Bot pushed a commit to safarmer/flutter that referenced this pull request Apr 30, 2026
Fixes failing Dart to Flutter
flutter#185773.

Commit
[0d8487f9d42d46602fd1bd2a5ad28e0f2ace057b](flutter/tests@0d8487f)
updates the flutter/tests repo to fix the issue.

This PR updates our customer testing version to include that commit in
flutter/tests
@engine-flutter-autoroll engine-flutter-autoroll deleted the dart-sdk-flutter-9bd45688-7e71-4560-90b8-f548f22c83cb-1777492790 branch May 6, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants