[hooks] Fix pass-through dependencies#185739
Merged
auto-submit[bot] merged 3 commits intoApr 29, 2026
Merged
Conversation
effc0ae to
7789e8d
Compare
Contributor
|
An existing Git SHA, To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with |
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an optional output filtering mechanism in DepfileService to prevent circular dependencies in external systems like Xcode. It updates the native assets build and link hooks to utilize this filter and adds a test case to verify the fix. The review feedback suggests optimizing the filtering logic by using a Set for input paths to improve performance from O(N*M) to O(N+M).
bkonyi
approved these changes
Apr 29, 2026
This was referenced Apr 29, 2026
This was referenced Apr 30, 2026
BilalRehman08
pushed a commit
to BilalRehman08/flutter
that referenced
this pull request
May 22, 2026
Closes: * flutter#186305 Fix: * Updated `packages/flutter_tools/lib/src/build_system/targets/native_assets.dart` and `packages/flutter_tools/lib/src/isolated/native_assets/native_assets.dart` to cleanly support the tracking of build hook output files, ensuring they are properly bundled as part of the asset bundling phase and correctly rebuild when modified. Test: * Added isolated integration tests (`packages/flutter_tools/test/integration.shard/isolated/dart_data_asset_flutter_build_test.dart`) specifically verifying that Flutter builds rebuild correctly on macOS and Web when hook-generated data asset files are deleted or changed. Dependency updates: * Upgrades the build hook and native asset package ecosystem to the latest versions to apply the same fix in hooks_runner. * The hooks_runner fix required a breaking change to `package:hooks`. (We did the breaking change in a way so that further additions to `ProtocolExtension` do not cause bring changes in the future.) Refactors how the `LinkHooks` `Target` tracks dependencies: * Only outputs its own DEPS as opposed to flutter#185739 * Adding the `BuildHooks` inputs and outputs leads to extra link hook target runs. * To achieve that, `runFlutterSpecificLinkHooks` no longer combines the assets and dependencies from both build and link, the combining is done in `combineBuildAndLinkResults`. * The `LinkHooks` still outputs the combined asset list so that downstream targets don't have to combine the `BuildHooks` and `LinkHooks` outputs manually.
via-guy
pushed a commit
to via-guy/flutter
that referenced
this pull request
Jun 26, 2026
Closes: * flutter#186305 Fix: * Updated `packages/flutter_tools/lib/src/build_system/targets/native_assets.dart` and `packages/flutter_tools/lib/src/isolated/native_assets/native_assets.dart` to cleanly support the tracking of build hook output files, ensuring they are properly bundled as part of the asset bundling phase and correctly rebuild when modified. Test: * Added isolated integration tests (`packages/flutter_tools/test/integration.shard/isolated/dart_data_asset_flutter_build_test.dart`) specifically verifying that Flutter builds rebuild correctly on macOS and Web when hook-generated data asset files are deleted or changed. Dependency updates: * Upgrades the build hook and native asset package ecosystem to the latest versions to apply the same fix in hooks_runner. * The hooks_runner fix required a breaking change to `package:hooks`. (We did the breaking change in a way so that further additions to `ProtocolExtension` do not cause bring changes in the future.) Refactors how the `LinkHooks` `Target` tracks dependencies: * Only outputs its own DEPS as opposed to flutter#185739 * Adding the `BuildHooks` inputs and outputs leads to extra link hook target runs. * To achieve that, `runFlutterSpecificLinkHooks` no longer combines the assets and dependencies from both build and link, the combining is done in `combineBuildAndLinkResults`. * The `LinkHooks` still outputs the combined asset list so that downstream targets don't have to combine the `BuildHooks` and `LinkHooks` outputs manually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes:
The dependencies from build and link hooks are reported as inputs by the flutter build system to Xcode.
The assets reported from build and link hooks were reported as outputs by the Flutter build system to Xcode.
This caused issues if files just passed through hooks untouched.
We should only report files as outputs if they are actually produced by the hook. This means that if a file occurs in its inputs it should not occur in its outputs.
If linking is disabled, then the LinkHooks target must also report the dependencies of the BuildHooks, not only its outputs.
Note: This was likely only an issue for data assets, not for code assets. Code assets are either built from source or downloaded in the hook. Usually precompiled code-assets are not part of your package sources.