[CP-beta]Fix --enable-hcpp flag being ignored in release#185717
Conversation
The flag needed to be moved outside of the
```dart
if (debuggingOptions.debuggingEnabled) {
...
}
```
block, as impeller is
|
@gmackall please fill out the PR description above, afterwards the release team will review this request. |
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
There was a problem hiding this comment.
Code Review
This pull request modifies the Android device implementation to forward the HCPP and surface control flag regardless of whether debugging is enabled. It includes updates to existing tests and a new test case to verify that Impeller and HCPP flags are correctly passed during application startup in release mode. I have no feedback to provide.
b9d0496
into
flutter:flutter-3.44-candidate.0
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
I didn't file an issue, but the problem is that the
--enable-hcppflag was not respected in release mode. This change aligns this flag with the pattern used by some other existing flags, such as--enable-impeller.Impact Description:
Users of the tool will think they are opting in to the HCPP platform view mode, but they will not be (in release mode)
< Replace with impact description here >
Changelog Description:
Explain this cherry pick:
See best practices for examples.
Fixes
--enable-hcpptool flag being ignored in release mode.< Replace with changelog description here >
[flutter/185692] Respects
--enable-hcppargument forflutter runon android in release mode.Workaround:
Is there a workaround for this issue?
They can use the manifest value instead, but it doesn't replicate the convenience.
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
Run an app with a platform view in it on android on a device on api 34+ w/ vulkan, and inspect the logcat for logs indicating HCPP is in use.