Fix --enable-hcpp flag being ignored in release#185692
Merged
auto-submit[bot] merged 2 commits intoApr 29, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies AndroidDevice to ensure the enable-hcpp-and-surface-control flag is forwarded during app startup even when debugging is disabled, such as in release mode. It includes a new test case for release mode and updates existing tests. Review feedback identifies a logic error in the new test's expectations regarding the enable-dart-profiling flag and suggests renaming the test APK to better reflect the release build context.
…isting patterns, which makes the review questionable in my opinion. However, easy to fix with ai anyways so just fix it. But still, bad review
mboetger
approved these changes
Apr 28, 2026
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flag needed to be moved outside of the
if (debuggingOptions.debuggingEnabled) { ... }block, as impeller is