Made the MIT matcher not greedy and added a boost file matcher#185491
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a new license matcher for the Boost Software License, updates the .gitignore for sky_engine, and modifies the MIT license regex to use non-greedy matching. Feedback on the new Boost license matcher suggests unescaping double quotes for consistency with other matchers and escaping literal periods to ensure precise regex matching.
| must be included in all copies of the Software, in whole or in part, and | ||
| all derivative works of the Software, unless such copies or derivative | ||
| works are solely in the form of machine-executable object code generated by | ||
| a source language processor. |
Contributor
There was a problem hiding this comment.
The literal period at the end of the sentence is not escaped. In a regex, . matches any character. It should be escaped as \. for precision and consistency with other matchers like mit.txt (line 18).
a source language processor\.
| SHALL THE COPYRIGHT HOLDERS OR ANYONE DISTRIBUTING THE SOFTWARE BE LIABLE | ||
| FOR ANY DAMAGES OR OTHER LIABILITY, WHETHER IN CONTRACT, TORT OR OTHERWISE, | ||
| ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER | ||
| DEALINGS IN THE SOFTWARE. |
Contributor
There was a problem hiding this comment.
The literal period at the end of the file should be escaped as \. to ensure it matches only a period.
DEALINGS IN THE SOFTWARE\.
jason-simmons
approved these changes
Apr 23, 2026
chingjun
approved these changes
Apr 24, 2026
This was referenced Apr 24, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 24, 2026
flutter/flutter@aeb9623...3100188 2026-04-24 engine-flutter-autoroll@skia.org Roll Skia from 1c9b0b9141e9 to 63dbf37c3700 (1 revision) (flutter/flutter#185533) 2026-04-24 30870216+gaaclarke@users.noreply.github.com Made MetalSDF a printed name when sdf's are enabled. (flutter/flutter#185504) 2026-04-24 30870216+gaaclarke@users.noreply.github.com Made the MIT matcher not greedy and added a boost file matcher (flutter/flutter#185491) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…#11579) flutter/flutter@aeb9623...3100188 2026-04-24 engine-flutter-autoroll@skia.org Roll Skia from 1c9b0b9141e9 to 63dbf37c3700 (1 revision) (flutter/flutter#185533) 2026-04-24 30870216+gaaclarke@users.noreply.github.com Made MetalSDF a printed name when sdf's are enabled. (flutter/flutter#185504) 2026-04-24 30870216+gaaclarke@users.noreply.github.com Made the MIT matcher not greedy and added a boost file matcher (flutter/flutter#185491) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #184587
The reason the roll wasn't working is that the MIT license matcher was being greedy and it was grabbing all the text between 2 MIT licenses in the icu license file. That included licenses for files that we explicitly removed for files we don't use.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.