Skip to content

Roll Dart SDK from 9648f446f131 to 8c7d735d679f (10 revisions)#185339

Closed
engine-flutter-autoroll wants to merge 1 commit into
flutter:masterfrom
engine-flutter-autoroll:dart-sdk-flutter-fabb8442-8bf2-45a2-b2f3-acc9bada4557-1776776447
Closed

Roll Dart SDK from 9648f446f131 to 8c7d735d679f (10 revisions)#185339
engine-flutter-autoroll wants to merge 1 commit into
flutter:masterfrom
engine-flutter-autoroll:dart-sdk-flutter-fabb8442-8bf2-45a2-b2f3-acc9bada4557-1776776447

Conversation

@engine-flutter-autoroll

Copy link
Copy Markdown
Contributor

https://dart.googlesource.com/sdk.git/+log/9648f446f131..8c7d735d679f

2026-04-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.13.0-44.0.dev
2026-04-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.13.0-43.0.dev
2026-04-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.13.0-42.0.dev
2026-04-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.13.0-41.0.dev
2026-04-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.13.0-40.0.dev
2026-04-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.13.0-39.0.dev
2026-04-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.13.0-38.0.dev
2026-04-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.13.0-37.0.dev
2026-04-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.13.0-36.0.dev
2026-04-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.13.0-35.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://dart.googlesource.com/sdk.git/+log/9648f446f131..8c7d735d679f

2026-04-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.13.0-44.0.dev
2026-04-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.13.0-43.0.dev
2026-04-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.13.0-42.0.dev
2026-04-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.13.0-41.0.dev
2026-04-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.13.0-40.0.dev
2026-04-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.13.0-39.0.dev
2026-04-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.13.0-38.0.dev
2026-04-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.13.0-37.0.dev
2026-04-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.13.0-36.0.dev
2026-04-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.13.0-35.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@engine-flutter-autoroll engine-flutter-autoroll added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 21, 2026
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Apr 21, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@github-actions github-actions Bot added the engine flutter/engine related. See also e: labels. label Apr 21, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 21, 2026
@auto-submit

auto-submit Bot commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/185339, because - The status or check suite Linux linux_host_engine_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@engine-flutter-autoroll engine-flutter-autoroll added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 21, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 21, 2026
@auto-submit

auto-submit Bot commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/185339, because - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux linux_host_engine_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@engine-flutter-autoroll engine-flutter-autoroll added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 21, 2026
@auto-submit

auto-submit Bot commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/185339, because - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux linux_host_engine_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 21, 2026
@engine-flutter-autoroll

Copy link
Copy Markdown
Contributor Author

Commit queue failed; closing this roll.

@scheglov

scheglov commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

A little hint? What specifically fails?
Ah, there are compilation errors.

Running command "/b/s/w/ir/cache/builder/engine/src/out/ci/host_debug_test/dart-sdk/bin/dart test --reporter=expanded" in "/b/s/w/ir/cache/builder/engine/src/flutter/tools/api_check"
00:00 +0: loading test/apicheck_test.dart
00:00 +0 -1: loading test/apicheck_test.dart [E]
  Failed to load "test/apicheck_test.dart":
  test/apicheck_test.dart:265:24: Error: 'SimpleFormalParameter' isn't a type.
        if (parameter is SimpleFormalParameter) {
                         ^^^^^^^^^^^^^^^^^^^^^
  test/apicheck_test.dart:267:31: Error: 'DefaultFormalParameter' isn't a type.
        } else if (parameter is DefaultFormalParameter) {
                                ^^^^^^^^^^^^^^^^^^^^^^
  test/apicheck_test.dart:268:40: Error: 'SimpleFormalParameter' isn't a type.
          type = (parameter.parameter as SimpleFormalParameter).type;
                                         ^^^^^^^^^^^^^^^^^^^^^
  test/apicheck_test.dart:268:27: Error: The getter 'parameter' isn't defined for the type 'FormalParameter'.
   - 'FormalParameter' is from 'package:analyzer/src/dart/ast/ast.dart' ('../../third_party/dart/pkg/analyzer/lib/src/dart/ast/ast.dart').
  Try correcting the name to the name of an existing getter, or defining a getter or field named 'parameter'.
          type = (parameter.parameter as SimpleFormalParameter).type;
                            ^^^^^^^^^
00:00 +0 -1: Some tests failed.

Failing tests:
  test/apicheck_test.dart: loading test/apicheck_test.dart

@scheglov

Copy link
Copy Markdown
Contributor

#185360 should help.

alejandro-all-win-software pushed a commit to alejandro-all-win-software/flutter that referenced this pull request Apr 21, 2026
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

Solution for flutter#185339

*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

If this change needs to override an active code freeze, provide a
comment explaining why. The code freeze workflow can be overridden by
code reviewers. See pinned issues for any active code freezes with
guidance.

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
@engine-flutter-autoroll engine-flutter-autoroll deleted the dart-sdk-flutter-fabb8442-8bf2-45a2-b2f3-acc9bada4557-1776776447 branch April 28, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants