Rewrites no-response workflow to work with pr as well by chunhtai · Pull Request #185163 · flutter/flutter

chunhtai · 2026-04-16T17:31:20Z

The original workflow uses a third party custom action. I rewrote it and also add support for pr that doesn't have comment or branch update for 21 days.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

gemini-code-assist

Code Review

This pull request introduces two scripts for managing the 'waiting for customer response' label: no-response.js for closing stale issues and remove-waiting-label.js for clearing the label upon author activity. Feedback suggests optimizing no-response.js by using the updated_at property to reduce API calls and expanding remove-waiting-label.js to include the pull_request_review event.

gemini-code-assist · 2026-04-16T17:33:00Z

+      const events = await github.paginate(github.rest.issues.listEvents, {
+        owner,
+        repo,
+        issue_number: issue.number,
+      });
+
+      const labelEvent = events.reverse().find(event => event.event === 'labeled' && event.label.name === labelName);
+
+      if (labelEvent) {
+        const labeledAt = new Date(labelEvent.created_at);
+        if (labeledAt < closeDate) {
+          shouldClose = true;
+          console.log(`Issue #${issue.number} has label added since 21 days.`);
+        }
+      }


Fetching all events for every issue with the label is inefficient and can lead to hitting GitHub API rate limits in a large repository like Flutter. Since issue.updated_at is updated whenever a label is added or a comment is made, you can use it as a preliminary check. If updated_at is older than 21 days, the label must have been added at least 21 days ago, allowing you to skip the expensive event fetching. You only need to fetch events if updated_at is recent to check if the specific label event itself is old.

const updatedAt = new Date(issue.updated_at); if (updatedAt < closeDate) { shouldClose = true; console.log(`Issue #${issue.number} hasn't been updated since 21 days.`); } else { const events = await github.paginate(github.rest.issues.listEvents, { owner, repo, issue_number: issue.number, }); const labelEvent = events.reverse().find(event => event.event === 'labeled' && event.label.name === labelName); if (labelEvent) { const labeledAt = new Date(labelEvent.created_at); if (labeledAt < closeDate) { shouldClose = true; console.log(`Issue #${issue.number} has label added since 21 days.`); } } }

we don't want every types of update to postpone the issue or pr closure. I don't think there will be a lot event updates for an issue

This also is the original behavior

gemini-code-assist · 2026-04-16T17:33:00Z

+  if (context.eventName === 'issue_comment' || context.eventName === 'pull_request_review_comment') {
+    const comment = context.payload.comment;
+    if (comment && comment.user.id === item.user.id) {
+      isResponse = true;
+    }


The script currently misses the pull_request_review event. If an author submits a top-level review (e.g., to respond to feedback or approve changes), the label should also be removed.

if (['issue_comment', 'pull_request_review_comment', 'pull_request_review'].includes(context.eventName)) { const user = (context.payload.comment || context.payload.review).user; if (user && user.id === item.user.id) { isResponse = true; } }

pull_request_review is from the reviewer. we only care about pr author's comment

chunhtai · 2026-04-16T17:44:24Z

+name: No Response (Issue Comment)
+
+on:
+  issue_comment:


I wonder how bad this trigger is in terms of github quota

there's a few types of quota; the one I've been concerned with is Cocoon's secondary quota. This doesn't affect that. Instead this affects the team / organization action minutes.

no response is the second most run action, consuming 4,952 minutes last month with 4,944 runs.

If we did this just on a cron, every 15 minutes, it would be 2880 runs, or 57% of last months runs.

jtmcdole

Could we combine these? Do we need to immediately remove the label or can it be 15 minutes?

e.g.

Every 15 minutes:

Look for all issues / prs that are open
Look if they have the label and record the time
Look if the author has responded since the label was created - remove label
Look if the label was added > 21 days; close

jtmcdole · 2026-04-16T18:20:49Z

+name: No Response (Issue Comment)
+
+on:
+  issue_comment:


there's a few types of quota; the one I've been concerned with is Cocoon's secondary quota. This doesn't affect that. Instead this affects the team / organization action minutes.

no response is the second most run action, consuming 4,952 minutes last month with 4,944 runs.

jtmcdole · 2026-04-16T18:22:32Z

+name: No Response (Issue Comment)
+
+on:
+  issue_comment:


If we did this just on a cron, every 15 minutes, it would be 2880 runs, or 57% of last months runs.

chunhtai · 2026-04-16T18:59:00Z

All done.

run every 15 minutes, it either remove the label if there is qualified response, or close the issue/pr when it is >21 without qualified response

Piinks · 2026-04-16T19:00:50Z

+module.exports = async ({ github, context }) => {
+  const owner = context.repo.owner;
+  const repo = context.repo.repo;
+  const labelName = 'waiting for customer response';


Since this covers PRs now, should 'waiting for customer response' --> 'waiting for response'?

sgtm, will also need to update the existing label once this lands

Piinks

LGTM

…ter/flutter#185163)

flutter/flutter@8e8a194...2844af6 2026-04-19 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from bWoigpGIb60B6C7hD... to aDbXQm6WA0wFCAUp-... (flutter/flutter#185253) 2026-04-18 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from di3JdYrdE9OFu8Iyl... to bWoigpGIb60B6C7hD... (flutter/flutter#185231) 2026-04-18 rmolivares@renzo-olivares.dev Fix: text selection context menu should reappear after a non-fling scroll on Android and iOS (flutter/flutter#185054) 2026-04-18 flar@google.com Rect constructors for circle bounds (MakeCircle/EllipseBounds) (flutter/flutter#185110) 2026-04-17 97480502+b-luk@users.noreply.github.com Change uber SDF to get pixel size (for AA) using euclidean distance rather than manhattan distance. (flutter/flutter#184984) 2026-04-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 7c2564c18770 to 9648f446f131 (7 revisions) (flutter/flutter#185223) 2026-04-17 47866232+chunhtai@users.noreply.github.com Rewrites no-response workflow to work with pr as well (flutter/flutter#185163) 2026-04-17 15619084+vashworth@users.noreply.github.com Only use LLDB breakpoint in debug mode (flutter/flutter#185158) 2026-04-17 flar@google.com add playground to test SDF primitive rendering under transforms (flutter/flutter#185010) 2026-04-17 30870216+gaaclarke@users.noreply.github.com Adds sdf rrects (and fixes opacity + color source) (flutter/flutter#184999) 2026-04-17 matt.kosarek@canonical.com Implementation of popup windows for Win32 (flutter/flutter#184516) 2026-04-17 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (flutter/flutter#185207) 2026-04-17 chris@bracken.jp [iOS] Update previousCompositionOrder to return Obj-C type (flutter/flutter#185136) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC boetger@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#11531) flutter/flutter@8e8a194...2844af6 2026-04-19 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from bWoigpGIb60B6C7hD... to aDbXQm6WA0wFCAUp-... (flutter/flutter#185253) 2026-04-18 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from di3JdYrdE9OFu8Iyl... to bWoigpGIb60B6C7hD... (flutter/flutter#185231) 2026-04-18 rmolivares@renzo-olivares.dev Fix: text selection context menu should reappear after a non-fling scroll on Android and iOS (flutter/flutter#185054) 2026-04-18 flar@google.com Rect constructors for circle bounds (MakeCircle/EllipseBounds) (flutter/flutter#185110) 2026-04-17 97480502+b-luk@users.noreply.github.com Change uber SDF to get pixel size (for AA) using euclidean distance rather than manhattan distance. (flutter/flutter#184984) 2026-04-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 7c2564c18770 to 9648f446f131 (7 revisions) (flutter/flutter#185223) 2026-04-17 47866232+chunhtai@users.noreply.github.com Rewrites no-response workflow to work with pr as well (flutter/flutter#185163) 2026-04-17 15619084+vashworth@users.noreply.github.com Only use LLDB breakpoint in debug mode (flutter/flutter#185158) 2026-04-17 flar@google.com add playground to test SDF primitive rendering under transforms (flutter/flutter#185010) 2026-04-17 30870216+gaaclarke@users.noreply.github.com Adds sdf rrects (and fixes opacity + color source) (flutter/flutter#184999) 2026-04-17 matt.kosarek@canonical.com Implementation of popup windows for Win32 (flutter/flutter#184516) 2026-04-17 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (flutter/flutter#185207) 2026-04-17 chris@bracken.jp [iOS] Update previousCompositionOrder to return Obj-C type (flutter/flutter#185136) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC boetger@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

chunhtai added 2 commits April 16, 2026 10:29

Rewrites no-response workflow to work with pr as well

9b842ef

update

b0dda6f

gemini-code-assist Bot reviewed Apr 16, 2026

View reviewed changes

update

b2b2ae2

chunhtai requested review from Piinks, jtmcdole and mdebbar April 16, 2026 17:41

update

1186cb2

chunhtai commented Apr 16, 2026

View reviewed changes

jtmcdole reviewed Apr 16, 2026

View reviewed changes

Comment thread .github/workflows/no-response.yaml

jtmcdole reviewed Apr 16, 2026

View reviewed changes

chunhtai added 3 commits April 16, 2026 11:50

update

371349e

update

a408715

fix more

7faddc4

Piinks reviewed Apr 16, 2026

View reviewed changes

update

13d0ec6

github-actions Bot added c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. d: docs/ flutter/flutter/docs, for contributors labels Apr 16, 2026

chunhtai requested review from Piinks and jtmcdole April 16, 2026 20:30

chunhtai added the CICD Run CI/CD label Apr 16, 2026

Piinks approved these changes Apr 17, 2026

View reviewed changes

jtmcdole approved these changes Apr 17, 2026

View reviewed changes

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 17, 2026

auto-submit Bot added this pull request to the merge queue Apr 17, 2026

Merged via the queue into flutter:master with commit a8eb8eb Apr 17, 2026
19 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 17, 2026

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2026

a8eb8ebd3 Rewrites no-response workflow to work with pr as well (flut…

7dacc4b

…ter/flutter#185163)

engine-flutter-autoroll mentioned this pull request Apr 18, 2026

Roll Flutter from 8e8a194923dc to b28889e393d9 (12 revisions) flutter/packages#11528

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2026

a8eb8ebd3 Rewrites no-response workflow to work with pr as well (flut…

463bf88

…ter/flutter#185163)

engine-flutter-autoroll mentioned this pull request Apr 18, 2026

Roll Flutter from 8e8a194923dc to b28889e393d9 (12 revisions) flutter/packages#11529

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 19, 2026

a8eb8ebd3 Rewrites no-response workflow to work with pr as well (flut…

55b7ad4

…ter/flutter#185163)

engine-flutter-autoroll mentioned this pull request Apr 19, 2026

Roll Flutter from 8e8a194923dc to 2844af6a7134 (13 revisions) flutter/packages#11530

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 19, 2026

a8eb8ebd3 Rewrites no-response workflow to work with pr as well (flut…

5e97d7b

…ter/flutter#185163)

engine-flutter-autoroll mentioned this pull request Apr 19, 2026

Roll Flutter from 8e8a194923dc to 2844af6a7134 (13 revisions) flutter/packages#11531

Merged

stuartmorgan-g mentioned this pull request May 6, 2026

Create a team-owned no-response fork #177267

Closed

4 tasks

Uh oh!

Conversation

chunhtai commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jtmcdole left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chunhtai commented Apr 16, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chunhtai commented Apr 16, 2026 •

edited

Loading