[CP-stable] Fix changelog merging workflow.#185095
Conversation
This change also pulls some changelogs from 3.38 which happened after 3.41's original branch cut.
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
There was a problem hiding this comment.
Code Review
This pull request updates CHANGELOG.md with entries for Flutter versions 3.38.6 through 3.38.10. Feedback includes correcting a version typo from 'iOS 26' to 'iOS 16', removing an unnecessary newline for consistent spacing, and standardizing the entry format by removing hyphens after issue links.
reidbaker
left a comment
There was a problem hiding this comment.
If this is a cherry pick of the workflow can you include the commit hash being cherry picked or the pr in the pr description.
I do not think that changelog entries should be cherry picked into 3.41 and if they were it should not happen in a workflow pr to help with releasing.
I added a link in the description to the PR that originally fixed the workflow on master. (#184145) We actually must cherry-pick the 3.38 changelog entries into 3.41, otherwise when the merge changelog workflow runs, it will actually delete these 3.38 changelog entries from the master branch, which is definitely not something we want to do. |
reidbaker
left a comment
There was a problem hiding this comment.
Unblocking but having to have updated changelogs is a new constraint. Our processes do not sync changelogs across long running branches.
c7cfd95
into
flutter:flutter-3.41-candidate.0
This change also pulls some changelogs from 3.38 which happened after 3.41's original branch cut. The changes to the workflow are from this PR: flutter#184145
This change also pulls some changelogs from 3.38 which happened after 3.41's original branch cut.
The changes to the workflow are from this PR: #184145