Skip to content

[ Tool ] Remove legacy analytics code#184994

Merged
auto-submit[bot] merged 8 commits into
flutter:masterfrom
bkonyi:remove_legacy_analytics
May 20, 2026
Merged

[ Tool ] Remove legacy analytics code#184994
auto-submit[bot] merged 8 commits into
flutter:masterfrom
bkonyi:remove_legacy_analytics

Conversation

@bkonyi

@bkonyi bkonyi commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

package:usage has been replaced with package:unified_analytics and can now be removed from the tool.

package:usage has been replaced with package:unified_analytics and can now be removed from the tool.
@bkonyi bkonyi requested a review from a team as a code owner April 13, 2026 19:57
@bkonyi bkonyi added the CICD Run CI/CD label Apr 13, 2026
@github-actions github-actions Bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. team-ios Owned by iOS platform team labels Apr 13, 2026
@bkonyi bkonyi removed the request for review from a team April 13, 2026 19:58

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the legacy package:usage telemetry system and its associated classes, such as Usage, HotEvent, and CommandResultEvent, in favor of unified_analytics. The usage dependency is removed from pubspec.yaml, and the reporting/ directory is cleaned of legacy files. Review feedback highlights that several Event.hotRunnerInfo calls in resident_web_runner.dart and run_hot.dart are missing telemetry parameters previously included, which may lead to data loss. There is also a request to update documentation comments that still reference removed metrics.

Comment thread packages/flutter_tools/lib/src/isolated/resident_web_runner.dart
Comment thread packages/flutter_tools/lib/src/isolated/resident_web_runner.dart
Comment thread packages/flutter_tools/lib/src/isolated/resident_web_runner.dart
Comment thread packages/flutter_tools/lib/src/run_hot.dart
Comment thread packages/flutter_tools/lib/src/run_hot.dart
@github-actions github-actions Bot removed the CICD Run CI/CD label Apr 20, 2026
@bkonyi bkonyi added the CICD Run CI/CD label Apr 20, 2026
hellohuanlin
hellohuanlin previously approved these changes Apr 20, 2026

@hellohuanlin hellohuanlin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide more context around this deprecation? any design doc or issue tracking?

@bkonyi

bkonyi commented Apr 21, 2026

Copy link
Copy Markdown
Contributor Author

This is the last step of our migration to package:unified_analytics from package:usage (#134442) in the flutter_tool project (#128251). It hasn't been high priority, so I'm only just getting around to this now.

@github-actions github-actions Bot removed the CICD Run CI/CD label Apr 24, 2026
@bkonyi bkonyi added the CICD Run CI/CD label Apr 24, 2026
@github-actions github-actions Bot removed the CICD Run CI/CD label Apr 24, 2026
@bkonyi bkonyi added the CICD Run CI/CD label Apr 24, 2026
@hellohuanlin hellohuanlin self-requested a review April 30, 2026 21:41
parlough
parlough previously approved these changes May 7, 2026

@parlough parlough left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this cleanup! 🚀

@bkonyi bkonyi requested a review from a team as a code owner May 14, 2026 17:11
@github-actions github-actions Bot added team-macos Owned by the macOS platform team and removed CICD Run CI/CD labels May 14, 2026
@bkonyi bkonyi added the CICD Run CI/CD label May 14, 2026
@chingjun

Copy link
Copy Markdown
Contributor

I believe this PR needs a different g3fix now. Also can we hold this until Monday? I want to make sure that the changes you made internally is working correctly before landing this. Thanks!

@bkonyi

bkonyi commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

I believe this PR needs a different g3fix now. Also can we hold this until Monday? I want to make sure that the changes you made internally is working correctly before landing this. Thanks!

SGTM! Landing the internal changes now and will upload a new fix shortly. I'll hold off on landing this until Monday at the earliest.

@chingjun

Copy link
Copy Markdown
Contributor

I believe this PR needs a different g3fix now. Also can we hold this until Monday? I want to make sure that the changes you made internally is working correctly before landing this. Thanks!

SGTM! Landing the internal changes now and will upload a new fix shortly. I'll hold off on landing this until Monday at the earliest.

I've manually verified that the changes you landed last week is working fine internally.

LGTM on this PR.

chingjun
chingjun previously approved these changes May 18, 2026
@bkonyi bkonyi dismissed stale reviews from chingjun, parlough, and hellohuanlin via 36a2766 May 19, 2026 17:13
@bkonyi bkonyi force-pushed the remove_legacy_analytics branch from 08cd598 to 36a2766 Compare May 19, 2026 17:13
@github-actions github-actions Bot removed the CICD Run CI/CD label May 19, 2026
@bkonyi bkonyi requested a review from chingjun May 19, 2026 17:13
@bkonyi bkonyi added the CICD Run CI/CD label May 19, 2026
@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label May 19, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 19, 2026
@auto-submit

auto-submit Bot commented May 19, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/184994, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@chingjun chingjun added the autosubmit Merge PR when tree becomes green via auto submit App label May 19, 2026
@auto-submit auto-submit Bot added this pull request to the merge queue May 19, 2026
Merged via the queue into flutter:master with commit 461f432 May 20, 2026
170 of 171 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2026
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request May 20, 2026
flutter/flutter@259aeae...e03b91f

2026-05-20 engine-flutter-autoroll@skia.org Roll Packages from ade10ca to 1dfbada (6 revisions) (flutter/flutter#186811)
2026-05-20 brunocorona.alcantar@gmail.com Fix AnimatedList.separated assert when removing last item mid-removal… (flutter/flutter#186389)
2026-05-20 engine-flutter-autoroll@skia.org Roll Skia from d45969a5752e to 5f4f454b9662 (2 revisions) (flutter/flutter#186809)
2026-05-20 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from -F9Ci3Opxt06MixDl... to iKCvaD58jKStYGla0... (flutter/flutter#186796)
2026-05-20 engine-flutter-autoroll@skia.org Roll Skia from 19ad9707e5c6 to d45969a5752e (2 revisions) (flutter/flutter#186792)
2026-05-20 engine-flutter-autoroll@skia.org Roll Skia from 3471ebf5af0c to 19ad9707e5c6 (9 revisions) (flutter/flutter#186772)
2026-05-20 mdebbar@google.com [web] Refactor webparagraph painters to separate CK properly (flutter/flutter#186684)
2026-05-19 31859944+LongCatIsLooong@users.noreply.github.com Enable Swift testing in the iOS embedder (flutter/flutter#185712)
2026-05-19 mdebbar@google.com [web] Rename WebParagraph goldens (flutter/flutter#186680)
2026-05-19 engine-flutter-autoroll@skia.org Roll Skia from f1b406860c5e to 3471ebf5af0c (5 revisions) (flutter/flutter#186745)
2026-05-19 154381524+flutteractionsbot@users.noreply.github.com Revert "Ship gen_snapshot for linux-arm64 hosts targeting Android" (flutter/flutter#186693)
2026-05-19 bkonyi@google.com [ Tool ] Remove legacy analytics code (flutter/flutter#184994)
2026-05-19 chingjun@google.com Update Vulkan enum values (flutter/flutter#186694)
2026-05-19 1961493+harryterkelsen@users.noreply.github.com fix(web): Fixes CSS override detection when the browser has a default font size (flutter/flutter#186474)
2026-05-19 30870216+gaaclarke@users.noreply.github.com adds linux impeller hello world integration test (flutter/flutter#186715)
2026-05-19 jason-simmons@users.noreply.github.com Update the list of binaries in the code signing verification test to include new Dart snapshots (flutter/flutter#186754)
2026-05-19 brunocorona.alcantar@gmail.com Make EdgeDraggingAutoScroller respect ScrollPhysics (flutter/flutter#186541)
2026-05-19 bkonyi@google.com [ Widget Preview ] Fix inspector split resize focus loss over WebViews (flutter/flutter#186432)
2026-05-19 engine-flutter-autoroll@skia.org Roll Packages from b9bdd37 to ade10ca (1 revision) (flutter/flutter#186746)
2026-05-19 jason-simmons@users.noreply.github.com Manual Dart roll from 8e30b88e4d5a to 66873d2da857 (flutter/flutter#186690)
2026-05-19 bkonyi@google.com [ Widget Preview ] Improve zoom behavior and add zoom slider (flutter/flutter#186422)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
matthewhendrix pushed a commit to matthewhendrix/flutter that referenced this pull request May 23, 2026
`package:usage` has been replaced with package:unified_analytics and can
now be removed from the tool.
@parlough parlough mentioned this pull request Jun 8, 2026
3 tasks
@parlough parlough linked an issue Jun 8, 2026 that may be closed by this pull request
3 tasks
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…r#11747)

flutter/flutter@259aeae...e03b91f

2026-05-20 engine-flutter-autoroll@skia.org Roll Packages from ade10ca to 1dfbada (6 revisions) (flutter/flutter#186811)
2026-05-20 brunocorona.alcantar@gmail.com Fix AnimatedList.separated assert when removing last item mid-removal… (flutter/flutter#186389)
2026-05-20 engine-flutter-autoroll@skia.org Roll Skia from d45969a5752e to 5f4f454b9662 (2 revisions) (flutter/flutter#186809)
2026-05-20 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from -F9Ci3Opxt06MixDl... to iKCvaD58jKStYGla0... (flutter/flutter#186796)
2026-05-20 engine-flutter-autoroll@skia.org Roll Skia from 19ad9707e5c6 to d45969a5752e (2 revisions) (flutter/flutter#186792)
2026-05-20 engine-flutter-autoroll@skia.org Roll Skia from 3471ebf5af0c to 19ad9707e5c6 (9 revisions) (flutter/flutter#186772)
2026-05-20 mdebbar@google.com [web] Refactor webparagraph painters to separate CK properly (flutter/flutter#186684)
2026-05-19 31859944+LongCatIsLooong@users.noreply.github.com Enable Swift testing in the iOS embedder (flutter/flutter#185712)
2026-05-19 mdebbar@google.com [web] Rename WebParagraph goldens (flutter/flutter#186680)
2026-05-19 engine-flutter-autoroll@skia.org Roll Skia from f1b406860c5e to 3471ebf5af0c (5 revisions) (flutter/flutter#186745)
2026-05-19 154381524+flutteractionsbot@users.noreply.github.com Revert "Ship gen_snapshot for linux-arm64 hosts targeting Android" (flutter/flutter#186693)
2026-05-19 bkonyi@google.com [ Tool ] Remove legacy analytics code (flutter/flutter#184994)
2026-05-19 chingjun@google.com Update Vulkan enum values (flutter/flutter#186694)
2026-05-19 1961493+harryterkelsen@users.noreply.github.com fix(web): Fixes CSS override detection when the browser has a default font size (flutter/flutter#186474)
2026-05-19 30870216+gaaclarke@users.noreply.github.com adds linux impeller hello world integration test (flutter/flutter#186715)
2026-05-19 jason-simmons@users.noreply.github.com Update the list of binaries in the code signing verification test to include new Dart snapshots (flutter/flutter#186754)
2026-05-19 brunocorona.alcantar@gmail.com Make EdgeDraggingAutoScroller respect ScrollPhysics (flutter/flutter#186541)
2026-05-19 bkonyi@google.com [ Widget Preview ] Fix inspector split resize focus loss over WebViews (flutter/flutter#186432)
2026-05-19 engine-flutter-autoroll@skia.org Roll Packages from b9bdd37 to ade10ca (1 revision) (flutter/flutter#186746)
2026-05-19 jason-simmons@users.noreply.github.com Manual Dart roll from 8e30b88e4d5a to 66873d2da857 (flutter/flutter#186690)
2026-05-19 bkonyi@google.com [ Widget Preview ] Improve zoom behavior and add zoom slider (flutter/flutter#186422)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
via-guy pushed a commit to via-guy/flutter that referenced this pull request Jun 26, 2026
`package:usage` has been replaced with package:unified_analytics and can
now be removed from the tool.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD platform-ios iOS applications specifically team-ios Owned by iOS platform team team-macos Owned by the macOS platform team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[tool] Stop using pkg:usage

5 participants