Skip to content

[CP-stable] Disable async mode with LLDB#184983

Merged
auto-submit[bot] merged 3 commits into
flutter:flutter-3.41-candidate.0from
vashworth:cp_3.41_lldb_fix
Apr 15, 2026
Merged

[CP-stable] Disable async mode with LLDB#184983
auto-submit[bot] merged 3 commits into
flutter:flutter-3.41-candidate.0from
vashworth:cp_3.41_lldb_fix

Conversation

@vashworth

Copy link
Copy Markdown
Contributor

Issue Link:

What is the link to the issue this cherry-pick is addressing?

#184254

Impact Description:

What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)?
Does it impact development (ex. flutter doctor crashes when Android Studio is installed),
or the shipping of production apps (the app crashes on launch).
This information is for domain experts and release engineers to understand the consequences of saying yes or no to the cherry pick.

Debugging on physical iOS devices often crashes when using Xcode 26.4.

Changelog Description:

Explain this cherry pick:

  • In one line that is accessible to most Flutter developers.
  • That describes the state prior to the fix.
  • That includes which platforms are impacted.
    See best practices for examples.

When debugging on physical iOS devices and Xcode 26.4+, app often crashes.

Workaround:

Is there a workaround for this issue?

  • Use a simulator
  • Or launch from Xcode
  • Or use Xcode 26.3
  • Or use a wireless device

Risk:

What is the risk level of this cherry-pick?

  • Low
  • Medium
  • High

Test Coverage:

Are you confident that your fix is well-tested by automated tests?

  • Yes
  • No

Validation Steps:

What are the steps to validate that this fix works?

Do flutter run in https://github.com/flutter/flutter/tree/master/dev/integration_tests/flutter_gallery using Xcode 26.4 and a physical iOS device.

@vashworth vashworth requested a review from a team as a code owner April 13, 2026 18:55
@flutter-dashboard

Copy link
Copy Markdown

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@github-actions github-actions Bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. team-ios Owned by iOS platform team labels Apr 13, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request disables LLDB asynchronous mode to address breakpoint rearming issues and updates the expected log pattern from process resumption to breakpoint location addition. Feedback indicates that using breakpoint addition is a weak indicator for workflow initialization and suggests renaming the _lldbProcessResuming variable to better reflect its updated purpose.

Comment thread dev/devicelab/bin/tasks/ios_debug_workflow.dart
Comment thread packages/flutter_tools/lib/src/ios/lldb.dart
@vashworth vashworth added the CICD Run CI/CD label Apr 13, 2026
@vashworth

Copy link
Copy Markdown
Contributor Author

Test failures caused by #184689, #184989 needs to land first

@vashworth vashworth added the cp: review Cherry-picks in the review queue label Apr 14, 2026
@vashworth vashworth requested a review from hellohuanlin April 14, 2026 14:24
@github-actions github-actions Bot removed the CICD Run CI/CD label Apr 15, 2026
@eyebrowsoffire eyebrowsoffire added the CICD Run CI/CD label Apr 15, 2026
@github-actions github-actions Bot removed the CICD Run CI/CD label Apr 15, 2026
@eyebrowsoffire eyebrowsoffire added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Apr 15, 2026
@auto-submit auto-submit Bot merged commit d8d0a0a into flutter:flutter-3.41-candidate.0 Apr 15, 2026
132 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 16, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2026
Xbectordash pushed a commit to Xbectordash/abhi_flutter_fork that referenced this pull request May 13, 2026
### Issue Link:
What is the link to the issue this cherry-pick is addressing?

flutter#184254

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)?
Does it impact development (ex. flutter doctor crashes when Android Studio is installed),
or the shipping of production apps (the app crashes on launch).
This information is for domain experts and release engineers to understand the consequences of saying yes or no to the cherry pick.

Debugging on physical iOS devices often crashes when using Xcode 26.4.

### Changelog Description:
Explain this cherry pick:
* In one line that is accessible to most Flutter developers.
* That describes the state prior to the fix.
* That includes which platforms are impacted.
See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples.

When debugging on physical iOS devices and Xcode 26.4+, app often crashes.

### Workaround:
Is there a workaround for this issue?

* Use a simulator
* Or launch from Xcode
* Or use Xcode 26.3
* Or use a wireless device

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
What are the steps to validate that this fix works?

Do `flutter run` in https://github.com/flutter/flutter/tree/master/dev/integration_tests/flutter_gallery using Xcode 26.4 and a physical iOS device.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD cp: review Cherry-picks in the review queue platform-ios iOS applications specifically team-ios Owned by iOS platform team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants