Remove live_text_utils cross-imports from material and cupertino tests by xfce0 · Pull Request #184517 · flutter/flutter

xfce0 · 2026-04-02T15:26:48Z

Remove cross-directory test imports of live_text_utils.dart from material and cupertino tests.

LiveTextInputTester is a small (75-line) test utility with a trivial implementation, so duplication is the appropriate strategy per the issue guidelines. The file is copied into test/material/ and
test/cupertino/, and all 4 imports are updated to reference the local copies.

Pre-launch Checklist

gemini-code-assist

Code Review

This pull request relocates live_text_utils.dart to the cupertino and material test directories and updates the relevant imports. The LiveTextInputTester mock handler should be updated to return null instead of false for unhandled platform methods to prevent potential type errors in tests that call other platform services.

loic-sharma · 2026-04-03T00:17:34Z


 import '../widgets/clipboard_utils.dart';
-import '../widgets/live_text_utils.dart';
+import 'live_text_utils.dart';


Please move this to be below other ../ imports

loic-sharma · 2026-04-03T00:17:56Z

 import '../widgets/clipboard_utils.dart';
 import '../widgets/editable_text_utils.dart';
-import '../widgets/live_text_utils.dart';
+import 'live_text_utils.dart';


Please move this to be below other ../ imports

loic-sharma · 2026-04-03T00:18:00Z

 import '../widgets/clipboard_utils.dart';
 import '../widgets/editable_text_utils.dart';
-import '../widgets/live_text_utils.dart';
+import 'live_text_utils.dart';


Please move this to be below other ../ imports

loic-sharma · 2026-04-03T00:18:05Z

 import '../widgets/editable_text_utils.dart';
 import '../widgets/feedback_tester.dart';
-import '../widgets/live_text_utils.dart';
+import 'live_text_utils.dart';


Please move this to be below other ../ imports

loic-sharma

Thanks for the patch!

loic-sharma · 2026-04-03T00:21:39Z

@xfce0 It looks like this is branched off a master commit that has test failures. Could you rebase off the latest master?

xfce0 · 2026-04-03T05:00:25Z

Thanks for the review! I've reordered the local imports to come after ../ imports and rebased onto the latest master.

justinmc

LGTM 👍

loic-sharma

Thanks for fixing this!

…rtino tests (flutter/flutter#184517)

flutter/flutter@7245c3f...9cd60b5 2026-04-06 97480502+b-luk@users.noreply.github.com Fix go/ links in rbe.mde (flutter/flutter#184672) 2026-04-06 engine-flutter-autoroll@skia.org Roll Packages from d31df66 to 5299279 (2 revisions) (flutter/flutter#184663) 2026-04-06 1063596+reidbaker@users.noreply.github.com Add suggestion for what types of skills are helpful (flutter/flutter#184661) 2026-04-06 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from hrLZV-ij47FXnv_m5... to 1rcChbOv4nSTVkUxs... (flutter/flutter#184657) 2026-04-06 1063596+reidbaker@users.noreply.github.com Skill to find dart or flutter revision from a hash (flutter/flutter#184589) 2026-04-06 engine-flutter-autoroll@skia.org Roll Skia from 207c6721c64b to 163dfdf500c7 (7 revisions) (flutter/flutter#184650) 2026-04-05 engine-flutter-autoroll@skia.org Roll Skia from 52b79372764c to 207c6721c64b (1 revision) (flutter/flutter#184636) 2026-04-05 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from D2z-jMnRVbcwcraY-... to hrLZV-ij47FXnv_m5... (flutter/flutter#184623) 2026-04-05 engine-flutter-autoroll@skia.org Roll Skia from 500bc1651c86 to 52b79372764c (1 revision) (flutter/flutter#184621) 2026-04-04 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from PpL3Bn2YMb2h9LbdK... to D2z-jMnRVbcwcraY-... (flutter/flutter#184611) 2026-04-04 engine-flutter-autoroll@skia.org Roll Dart SDK from 102a3d1c7fe5 to 79f728f5d66e (1 revision) (flutter/flutter#184610) 2026-04-04 engine-flutter-autoroll@skia.org Roll Skia from 5e5a7f252b5e to 500bc1651c86 (1 revision) (flutter/flutter#184609) 2026-04-04 engine-flutter-autoroll@skia.org Roll Skia from ec209c206aa5 to 5e5a7f252b5e (2 revisions) (flutter/flutter#184606) 2026-04-04 engine-flutter-autoroll@skia.org Roll Dart SDK from f7be88117622 to 102a3d1c7fe5 (2 revisions) (flutter/flutter#184604) 2026-04-04 34465683+rkishan516@users.noreply.github.com refactor: remove material from color and image filter test (flutter/flutter#183563) 2026-04-04 engine-flutter-autoroll@skia.org Roll Skia from 50f3a9aaa185 to ec209c206aa5 (1 revision) (flutter/flutter#184601) 2026-04-03 engine-flutter-autoroll@skia.org Roll Skia from 4ecb7b28459f to 50f3a9aaa185 (3 revisions) (flutter/flutter#184599) 2026-04-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll ICU from ee5f27adc28b to ff7995a708a1 (5 revisions) (#184566)" (flutter/flutter#184586) 2026-04-03 15619084+vashworth@users.noreply.github.com Add integration scripts and tools for SwiftPM add to app (flutter/flutter#184204) 2026-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 46f49142acd9 to f7be88117622 (1 revision) (flutter/flutter#184596) 2026-04-03 jesswon@google.com [AGP 9] Add Disable Built-in Kotlin and newDSL Migratorrs (flutter/flutter#184255) 2026-04-03 engine-flutter-autoroll@skia.org Roll Skia from 3b0f0f04f97c to 4ecb7b28459f (7 revisions) (flutter/flutter#184594) 2026-04-03 34465683+rkishan516@users.noreply.github.com refactor: remove material from list_view_viewporting_test and page_forward_transitions_test (flutter/flutter#183564) 2026-04-03 737941+loic-sharma@users.noreply.github.com [Dot shorthands] Migrate examples/api/lib/cupertino (flutter/flutter#183964) 2026-04-03 okorohelijah@google.com Downgrade CocoaPods doctor check to warning and fix build error messaging (flutter/flutter#184511) 2026-04-03 engine-flutter-autoroll@skia.org Roll Skia from 4134f8091147 to 3b0f0f04f97c (2 revisions) (flutter/flutter#184582) 2026-04-03 73785960+xfce0@users.noreply.github.com Remove live_text_utils cross-imports from material and cupertino tests (flutter/flutter#184517) 2026-04-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[data_assets] Cleanup tests (#184209)" (flutter/flutter#184575) 2026-04-03 engine-flutter-autoroll@skia.org Roll Packages from 66bf7ec to d31df66 (3 revisions) (flutter/flutter#184578) 2026-04-03 engine-flutter-autoroll@skia.org Roll Skia from 5d847ba5c4aa to 4134f8091147 (1 revision) (flutter/flutter#184573) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter#184517) Remove cross-directory test imports of `live_text_utils.dart` from material and cupertino tests. Part of flutter#182636. `LiveTextInputTester` is a small (75-line) test utility with a trivial implementation, so duplication is the appropriate strategy per the issue guidelines. The file is copied into `test/material/` and `test/cupertino/`, and all 4 imports are updated to reference the local copies. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…r#11452) flutter/flutter@7245c3f...9cd60b5 2026-04-06 97480502+b-luk@users.noreply.github.com Fix go/ links in rbe.mde (flutter/flutter#184672) 2026-04-06 engine-flutter-autoroll@skia.org Roll Packages from d31df66 to 5299279 (2 revisions) (flutter/flutter#184663) 2026-04-06 1063596+reidbaker@users.noreply.github.com Add suggestion for what types of skills are helpful (flutter/flutter#184661) 2026-04-06 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from hrLZV-ij47FXnv_m5... to 1rcChbOv4nSTVkUxs... (flutter/flutter#184657) 2026-04-06 1063596+reidbaker@users.noreply.github.com Skill to find dart or flutter revision from a hash (flutter/flutter#184589) 2026-04-06 engine-flutter-autoroll@skia.org Roll Skia from 207c6721c64b to 163dfdf500c7 (7 revisions) (flutter/flutter#184650) 2026-04-05 engine-flutter-autoroll@skia.org Roll Skia from 52b79372764c to 207c6721c64b (1 revision) (flutter/flutter#184636) 2026-04-05 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from D2z-jMnRVbcwcraY-... to hrLZV-ij47FXnv_m5... (flutter/flutter#184623) 2026-04-05 engine-flutter-autoroll@skia.org Roll Skia from 500bc1651c86 to 52b79372764c (1 revision) (flutter/flutter#184621) 2026-04-04 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from PpL3Bn2YMb2h9LbdK... to D2z-jMnRVbcwcraY-... (flutter/flutter#184611) 2026-04-04 engine-flutter-autoroll@skia.org Roll Dart SDK from 102a3d1c7fe5 to 79f728f5d66e (1 revision) (flutter/flutter#184610) 2026-04-04 engine-flutter-autoroll@skia.org Roll Skia from 5e5a7f252b5e to 500bc1651c86 (1 revision) (flutter/flutter#184609) 2026-04-04 engine-flutter-autoroll@skia.org Roll Skia from ec209c206aa5 to 5e5a7f252b5e (2 revisions) (flutter/flutter#184606) 2026-04-04 engine-flutter-autoroll@skia.org Roll Dart SDK from f7be88117622 to 102a3d1c7fe5 (2 revisions) (flutter/flutter#184604) 2026-04-04 34465683+rkishan516@users.noreply.github.com refactor: remove material from color and image filter test (flutter/flutter#183563) 2026-04-04 engine-flutter-autoroll@skia.org Roll Skia from 50f3a9aaa185 to ec209c206aa5 (1 revision) (flutter/flutter#184601) 2026-04-03 engine-flutter-autoroll@skia.org Roll Skia from 4ecb7b28459f to 50f3a9aaa185 (3 revisions) (flutter/flutter#184599) 2026-04-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll ICU from ee5f27adc28b to ff7995a708a1 (5 revisions) (#184566)" (flutter/flutter#184586) 2026-04-03 15619084+vashworth@users.noreply.github.com Add integration scripts and tools for SwiftPM add to app (flutter/flutter#184204) 2026-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 46f49142acd9 to f7be88117622 (1 revision) (flutter/flutter#184596) 2026-04-03 jesswon@google.com [AGP 9] Add Disable Built-in Kotlin and newDSL Migratorrs (flutter/flutter#184255) 2026-04-03 engine-flutter-autoroll@skia.org Roll Skia from 3b0f0f04f97c to 4ecb7b28459f (7 revisions) (flutter/flutter#184594) 2026-04-03 34465683+rkishan516@users.noreply.github.com refactor: remove material from list_view_viewporting_test and page_forward_transitions_test (flutter/flutter#183564) 2026-04-03 737941+loic-sharma@users.noreply.github.com [Dot shorthands] Migrate examples/api/lib/cupertino (flutter/flutter#183964) 2026-04-03 okorohelijah@google.com Downgrade CocoaPods doctor check to warning and fix build error messaging (flutter/flutter#184511) 2026-04-03 engine-flutter-autoroll@skia.org Roll Skia from 4134f8091147 to 3b0f0f04f97c (2 revisions) (flutter/flutter#184582) 2026-04-03 73785960+xfce0@users.noreply.github.com Remove live_text_utils cross-imports from material and cupertino tests (flutter/flutter#184517) 2026-04-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[data_assets] Cleanup tests (#184209)" (flutter/flutter#184575) 2026-04-03 engine-flutter-autoroll@skia.org Roll Packages from 66bf7ec to d31df66 (3 revisions) (flutter/flutter#184578) 2026-04-03 engine-flutter-autoroll@skia.org Roll Skia from 5d847ba5c4aa to 4134f8091147 (1 revision) (flutter/flutter#184573) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

gemini-code-assist Bot reviewed Apr 2, 2026

View reviewed changes

Comment thread packages/flutter/test/cupertino/live_text_utils.dart

Comment thread packages/flutter/test/material/live_text_utils.dart

loic-sharma requested review from justinmc and loic-sharma April 2, 2026 20:36

loic-sharma reviewed Apr 3, 2026

View reviewed changes

loic-sharma added CICD Run CI/CD a: text input Entering text in a text field or keyboard related problems and removed a: text input Entering text in a text field or keyboard related problems labels Apr 3, 2026

loic-sharma previously approved these changes Apr 3, 2026

View reviewed changes

xfce0 added 2 commits April 3, 2026 07:59

Remove live_text_utils cross-imports from material and cupertino tests

a71f803

Fix import ordering: local imports after ../ imports

90158f6

xfce0 dismissed loic-sharma’s stale review via 90158f6 April 3, 2026 05:08

xfce0 force-pushed the fix-live-text-utils-cross-imports branch from 8af7f84 to 90158f6 Compare April 3, 2026 05:08

github-actions Bot removed the CICD Run CI/CD label Apr 3, 2026

justinmc approved these changes Apr 3, 2026

View reviewed changes

justinmc mentioned this pull request Apr 3, 2026

(Test cross-imports) Don't cross-import test utils #182636

Open

loic-sharma approved these changes Apr 3, 2026

View reviewed changes

loic-sharma added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Apr 3, 2026

auto-submit Bot added this pull request to the merge queue Apr 3, 2026

Merged via the queue into flutter:master with commit f88d2c4 Apr 3, 2026
80 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 3, 2026

Piinks mentioned this pull request Apr 3, 2026

Flutter Notable Commits - 2026 #181433

Open

This was referenced Apr 4, 2026

Remove feedback_tester cross-imports from material tests #184279

Open

Remove clipboard_utils cross-imports from material and cupertino tests #184278

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 4, 2026

f88d2c4a0 Remove live_text_utils cross-imports from material and cupe…

918aa15

…rtino tests (flutter/flutter#184517)

engine-flutter-autoroll mentioned this pull request Apr 4, 2026

Roll Flutter from 7245c3f71104 to ecfd1d7c5d21 (21 revisions) flutter/packages#11434

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 4, 2026

f88d2c4a0 Remove live_text_utils cross-imports from material and cupe…

5225f92

…rtino tests (flutter/flutter#184517)

engine-flutter-autoroll mentioned this pull request Apr 4, 2026

Roll Flutter from 7245c3f71104 to ecfd1d7c5d21 (21 revisions) flutter/packages#11435

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 5, 2026

f88d2c4a0 Remove live_text_utils cross-imports from material and cupe…

6554e9d

…rtino tests (flutter/flutter#184517)

engine-flutter-autoroll mentioned this pull request Apr 5, 2026

Roll Flutter from 7245c3f71104 to 54f9794693b6 (23 revisions) flutter/packages#11436

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 5, 2026

f88d2c4a0 Remove live_text_utils cross-imports from material and cupe…

89f0d88

…rtino tests (flutter/flutter#184517)

engine-flutter-autoroll mentioned this pull request Apr 5, 2026

Roll Flutter from 7245c3f71104 to ca1580b01385 (24 revisions) flutter/packages#11437

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 6, 2026

f88d2c4a0 Remove live_text_utils cross-imports from material and cupe…

8022c79

…rtino tests (flutter/flutter#184517)

engine-flutter-autoroll mentioned this pull request Apr 6, 2026

Roll Flutter from 7245c3f71104 to 821d193fe5c4 (25 revisions) flutter/packages#11444

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 6, 2026

f88d2c4a0 Remove live_text_utils cross-imports from material and cupe…

4a6a6bb

…rtino tests (flutter/flutter#184517)

engine-flutter-autoroll mentioned this pull request Apr 6, 2026

Roll Flutter from 7245c3f71104 to 1120789d00c2 (27 revisions) flutter/packages#11446

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 6, 2026

f88d2c4a0 Remove live_text_utils cross-imports from material and cupe…

78350b6

…rtino tests (flutter/flutter#184517)

engine-flutter-autoroll mentioned this pull request Apr 6, 2026

Roll Flutter from 7245c3f71104 to e923ecaf139e (28 revisions) flutter/packages#11448

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 6, 2026

f88d2c4a0 Remove live_text_utils cross-imports from material and cupe…

6235d39

…rtino tests (flutter/flutter#184517)

engine-flutter-autoroll mentioned this pull request Apr 6, 2026

Roll Flutter from 7245c3f71104 to 8422f21c7a86 (29 revisions) flutter/packages#11451

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 6, 2026

f88d2c4a0 Remove live_text_utils cross-imports from material and cupe…

d058727

…rtino tests (flutter/flutter#184517)

engine-flutter-autoroll mentioned this pull request Apr 6, 2026

Roll Flutter from 7245c3f71104 to 9cd60b512fbc (30 revisions) flutter/packages#11452

Merged

xfce0 deleted the fix-live-text-utils-cross-imports branch April 8, 2026 20:39

Sanaullah49 mentioned this pull request Apr 29, 2026

Remove semantics_tester cross-imports from material tests #185736

Open

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove live_text_utils cross-imports from material and cupertino tests#184517

Remove live_text_utils cross-imports from material and cupertino tests#184517
auto-submit[bot] merged 2 commits into
flutter:masterfrom
xfce0:fix-live-text-utils-cross-imports

xfce0 commented Apr 2, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

loic-sharma Apr 3, 2026

Uh oh!

loic-sharma Apr 3, 2026

Uh oh!

loic-sharma Apr 3, 2026

Uh oh!

loic-sharma Apr 3, 2026

Uh oh!

loic-sharma left a comment

Uh oh!

loic-sharma commented Apr 3, 2026 •

edited

Loading

Uh oh!

xfce0 commented Apr 3, 2026

Uh oh!

justinmc left a comment

Uh oh!

loic-sharma left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

xfce0 commented Apr 2, 2026

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

loic-sharma Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

loic-sharma Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

loic-sharma Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

loic-sharma Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

loic-sharma left a comment

Choose a reason for hiding this comment

Uh oh!

loic-sharma commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xfce0 commented Apr 3, 2026

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

loic-sharma left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

loic-sharma commented Apr 3, 2026 •

edited

Loading