Reland "Fix Slider semantics node size" with some changes #184168
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Slider widget's accessibility semantics by moving semantic properties from the Semantics widget wrapping the FocusableActionDetector directly into the _RenderSlider's describeSemanticsConfiguration and assembleSemanticsNode methods. This includes adding an onDidGainAccessibilityFocus callback and a new onFocusAction to handle accessibility focus. Test files have been updated to reflect these changes. A critical issue was identified in packages/flutter_test/test/controller_test.dart where sliderFinder.evaluate().single is incorrectly used to access a value property, which would cause a compilation error. The suggestion is to use tester.semantics.find(sliderFinder).value to correctly check the SemanticsNode's value.
Update slider.dart _thumbCenter Update packages/flutter_test/test/controller_test.dart tests Update slider_test.dart 1 Update slider.dart
80832e6 to
afd8a85
Compare
chunhtai
reviewed
Mar 27, 2026
| Iterable<SemanticsNode> children, | ||
| ) { | ||
| node.rect = Rect.fromCenter( | ||
| center: _semanticThumbCenter, |
Contributor
There was a problem hiding this comment.
We will also need to make sure the thumb's render object itself is big enough, not just the semantics node.
Member
Author
There was a problem hiding this comment.
Do you mean we need to make the thumb size 48*48?
I don't think that's necessary, because in non-a11y mode,
the whole slider is interactive and you can start dragging the thumb even if you didn't clicked on the thumb. so the interactive is definitely larger than 48*48
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 30, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 30, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 30, 2026
This was referenced Mar 30, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 30, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 30, 2026
This was referenced Mar 30, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2026
ahmedsameha1
pushed a commit
to ahmedsameha1/flutter
that referenced
this pull request
Apr 14, 2026
…4168) This is a reland of a old PR flutter#115285 with some changes: 1. the node has onFocusAction 2. update tests to reflect the semantics tree changes. 3. the `semantics` and `paint()` reuse the _calcThumbCenter function. in the formly reverted PR flutter#115285 the semantics only get the value of the thumbcenter after it's updated in paint() , I think it's what caused the g3 test failures in g3 and caused the revert. The semantics tree changes was caused because the semantics node was higher than the overlay before, and after the PR, the semantics node is formed as a leaf node and not merged with the overlay node, the extra overlay node won't change user experience but it will change some test result, fixes flutter#114225 ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a reland of a old PR #115285 with some changes:
semanticsandpaint()reuse the _calcThumbCenter function. in the formly reverted PR FixSlidersemantics node size #115285 the semantics only get the value of the thumbcenter after it's updated in paint() , I think it's what caused the g3 test failures in g3 and caused the revert.The semantics tree changes was caused because the semantics node was higher than the overlay before, and after the PR, the semantics node is formed as a leaf node and not merged with the overlay node, the extra overlay node won't change user experience but it will change some test result,
fixes #114225
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.