Skip to content

Use clearer return value for idle and timeout callbacks.#183811

Merged
robert-ancell merged 1 commit into
flutter:masterfrom
robert-ancell:linux-g-source-return-value
Mar 20, 2026
Merged

Use clearer return value for idle and timeout callbacks.#183811
robert-ancell merged 1 commit into
flutter:masterfrom
robert-ancell:linux-g-source-return-value

Conversation

@robert-ancell

@robert-ancell robert-ancell commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Use G_SOURCE_REMOVE (which is just FALSE) to make clearer what happens at the end of these callbacks.

@robert-ancell
Use clearer return value for idle and timeout callbacks.
0f0b686 
Use G_SOURCE_REMOVE (which is just FALSE) to make clearer what happens at the
end of these callbacks.
@robert-ancell robert-ancell requested a review from a team as a code owner March 17, 2026 23:27
@github-actions github-actions Bot added engine flutter/engine related. See also e: labels. platform-linux Building on or for Linux specifically a: desktop Running on desktop team-linux Owned by the Linux platform team labels Mar 17, 2026
@robert-ancell robert-ancell requested a review from mattkae March 17, 2026 23:28
@robert-ancell robert-ancell added the CICD Run CI/CD label Mar 17, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Mar 17, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies GLib callback functions in fl_binary_messenger_test.cc, fl_task_runner.cc, and fl_view.cc. In these callbacks, the return value FALSE has been replaced with the G_SOURCE_REMOVE constant. This change affects g_idle_add and timeout callbacks, clarifying that the event source should be removed after execution.

mattkae
mattkae approved these changes Mar 19, 2026
View reviewed changes

@mattkae mattkae left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 🫘

@robert-ancell robert-ancell added this pull request to the merge queue Mar 20, 2026
Merged via the queue into flutter:master with commit 42f16eb Mar 20, 2026
186 checks passed
@robert-ancell robert-ancell deleted the linux-g-source-return-value branch March 20, 2026 01:52
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 20, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 20, 2026
@engine-flutter-autoroll
42f16ebbc Use clearer return value for idle and timeout callbacks. (f…
184ccac 
…lutter/flutter#183811)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 20, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 20, 2026
@engine-flutter-autoroll
42f16ebbc Use clearer return value for idle and timeout callbacks. (f…
d520dc1 
…lutter/flutter#183811)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 20, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 20, 2026
@engine-flutter-autoroll
42f16ebbc Use clearer return value for idle and timeout callbacks. (f…
4c2a675 
…lutter/flutter#183811)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 20, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 20, 2026
@engine-flutter-autoroll
42f16ebbc Use clearer return value for idle and timeout callbacks. (f…
02d70d3 
…lutter/flutter#183811)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 20, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 20, 2026
@engine-flutter-autoroll
42f16ebbc Use clearer return value for idle and timeout callbacks. (f…
2207d05 
…lutter/flutter#183811)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 21, 2026
@engine-flutter-autoroll
42f16ebbc Use clearer return value for idle and timeout callbacks. (f…
03e087f 
…lutter/flutter#183811)
This was referenced Mar 21, 2026
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 21, 2026
@engine-flutter-autoroll
42f16ebbc Use clearer return value for idle and timeout callbacks. (f…
afba03b 
…lutter/flutter#183811)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 21, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 21, 2026
@engine-flutter-autoroll
42f16ebbc Use clearer return value for idle and timeout callbacks. (f…
1a0f575 
…lutter/flutter#183811)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2026
@engine-flutter-autoroll
42f16ebbc Use clearer return value for idle and timeout callbacks. (f…
7e6e199 
…lutter/flutter#183811)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2026
@engine-flutter-autoroll
42f16ebbc Use clearer return value for idle and timeout callbacks. (f…
30c53e6 
…lutter/flutter#183811)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 23, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2026
@engine-flutter-autoroll
42f16ebbc Use clearer return value for idle and timeout callbacks. (f…
c07059f 
…lutter/flutter#183811)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 23, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2026
@engine-flutter-autoroll
42f16ebbc Use clearer return value for idle and timeout callbacks. (f…
40969d0 
…lutter/flutter#183811)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 23, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2026
@engine-flutter-autoroll
42f16ebbc Use clearer return value for idle and timeout callbacks. (f…
332f637 
…lutter/flutter#183811)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 23, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2026
@engine-flutter-autoroll
42f16ebbc Use clearer return value for idle and timeout callbacks. (f…
50a4633 
…lutter/flutter#183811)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 24, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 24, 2026
@engine-flutter-autoroll
42f16ebbc Use clearer return value for idle and timeout callbacks. (f…
9d61d43 
…lutter/flutter#183811)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 24, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 24, 2026
@engine-flutter-autoroll
42f16ebbc Use clearer return value for idle and timeout callbacks. (f…
19edd8c 
…lutter/flutter#183811)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 24, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 24, 2026
@engine-flutter-autoroll
42f16ebbc Use clearer return value for idle and timeout callbacks. (f…
2b263e9 
…lutter/flutter#183811)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 24, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 24, 2026
@engine-flutter-autoroll
42f16ebbc Use clearer return value for idle and timeout callbacks. (f…
230bb60 
…lutter/flutter#183811)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 24, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 24, 2026
@engine-flutter-autoroll
42f16ebbc Use clearer return value for idle and timeout callbacks. (f…
20ec866 
…lutter/flutter#183811)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 24, 2026
@engine-flutter-autoroll
42f16ebbc Use clearer return value for idle and timeout callbacks. (f…
91a5bec 
…lutter/flutter#183811)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2026
@engine-flutter-autoroll
42f16ebbc Use clearer return value for idle and timeout callbacks. (f…
860d118 
…lutter/flutter#183811)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2026
@engine-flutter-autoroll
42f16ebbc Use clearer return value for idle and timeout callbacks. (f…
d14548b 
…lutter/flutter#183811)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2026
@engine-flutter-autoroll
42f16ebbc Use clearer return value for idle and timeout callbacks. (f…
7917603 
…lutter/flutter#183811)
mboetger pushed a commit to mboetger/flutter that referenced this pull request Mar 26, 2026
@robert-ancell @mboetger
Use clearer return value for idle and timeout callbacks. (flutter#183811
408b81b 
)

Use G_SOURCE_REMOVE (which is just FALSE) to make clearer what happens
at the end of these callbacks.
ahmedsameha1 pushed a commit to ahmedsameha1/flutter that referenced this pull request Apr 14, 2026
@robert-ancell @ahmedsameha1
Use clearer return value for idle and timeout callbacks. (flutter#183811
cfd9f58 
)

Use G_SOURCE_REMOVE (which is just FALSE) to make clearer what happens
at the end of these callbacks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattkae mattkae mattkae approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: desktop Running on desktop CICD Run CI/CD engine flutter/engine related. See also e: labels. platform-linux Building on or for Linux specifically team-linux Owned by the Linux platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robert-ancell @mattkae