Fix Semantics expanded state not updating in PopupMenuButton and DropdownButton#183475
Merged
auto-submit[bot] merged 2 commits intoMar 18, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where the expanded state in the Semantics widget was not updating for PopupMenuButton and DropdownButton. The changes wrap the assignments to the _isMenuExpanded state variable within setState calls in both widgets. This ensures that the UI rebuilds to reflect the menu's expanded or collapsed state for accessibility services. For DropdownButton, the logic to set _isMenuExpanded to false upon menu closure has been moved from _removeDropdownRoute into the .then() callback of navigator.push, guarded by a mounted check. This prevents unnecessary setState calls during widget disposal or orientation changes. Regression tests have been added for both PopupMenuButton and DropdownButton to confirm that the expanded semantics state updates correctly.
Note: Security Review is unavailable for this PR.
QuncCccccc
approved these changes
Mar 17, 2026
QuncCccccc
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks for your contribution:)!
7ab0319 to
cc69a93
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 19, 2026
…n and DropdownButton (flutter/flutter#183475)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 19, 2026
…n and DropdownButton (flutter/flutter#183475)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 19, 2026
…n and DropdownButton (flutter/flutter#183475)
This was referenced Mar 19, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 19, 2026
…n and DropdownButton (flutter/flutter#183475)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 19, 2026
…n and DropdownButton (flutter/flutter#183475)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 19, 2026
…n and DropdownButton (flutter/flutter#183475)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 20, 2026
…n and DropdownButton (flutter/flutter#183475)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 20, 2026
…n and DropdownButton (flutter/flutter#183475)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 21, 2026
…n and DropdownButton (flutter/flutter#183475)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 21, 2026
…n and DropdownButton (flutter/flutter#183475)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 21, 2026
…n and DropdownButton (flutter/flutter#183475)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 22, 2026
…n and DropdownButton (flutter/flutter#183475)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 22, 2026
…n and DropdownButton (flutter/flutter#183475)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 23, 2026
…n and DropdownButton (flutter/flutter#183475)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 23, 2026
…n and DropdownButton (flutter/flutter#183475)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 23, 2026
…n and DropdownButton (flutter/flutter#183475)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 23, 2026
…n and DropdownButton (flutter/flutter#183475)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 24, 2026
…n and DropdownButton (flutter/flutter#183475)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 24, 2026
…n and DropdownButton (flutter/flutter#183475)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 24, 2026
…n and DropdownButton (flutter/flutter#183475)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 24, 2026
…n and DropdownButton (flutter/flutter#183475)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 24, 2026
…n and DropdownButton (flutter/flutter#183475)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 24, 2026
…n and DropdownButton (flutter/flutter#183475)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 25, 2026
…n and DropdownButton (flutter/flutter#183475)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 25, 2026
…n and DropdownButton (flutter/flutter#183475)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 25, 2026
…n and DropdownButton (flutter/flutter#183475)
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Mar 26, 2026
…downButton (flutter#183475) Fixes flutter#183432 ## Description `_isMenuExpanded` is updated without calling `setState()` in both `PopupMenuButton` and `DropdownButton`, so the `Semantics(expanded: _isMenuExpanded)` widget doesn't rebuild. **`PopupMenuButton`**: The `expanded` state never updates at all since there is no `setState()` call anywhere in `PopupMenuButtonState`. **`DropdownButton`**: Currently masked by `_handleFocusChanged`, which happens to call `setState()` whenever focus changes on open/close, but should not rely on this side effect. ### Changes - Wrapped `_isMenuExpanded` assignments with `setState()` in both widgets. - For `DropdownButton`, moved `_isMenuExpanded = false` from `_removeDropdownRoute()` to the `.then()` callback with a `mounted` guard. This avoids unnecessary `setState()` calls when `_removeDropdownRoute()` is invoked during `dispose()` or orientation changes in `build()`, where the menu state isn't actually changing from user interaction. ## Tests Added regression tests for both `PopupMenuButton` and `DropdownButton` to verify the `expanded` semantics state updates correctly when the menu opens and closes. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
ahmedsameha1
pushed a commit
to ahmedsameha1/flutter
that referenced
this pull request
Apr 14, 2026
…downButton (flutter#183475) Fixes flutter#183432 ## Description `_isMenuExpanded` is updated without calling `setState()` in both `PopupMenuButton` and `DropdownButton`, so the `Semantics(expanded: _isMenuExpanded)` widget doesn't rebuild. **`PopupMenuButton`**: The `expanded` state never updates at all since there is no `setState()` call anywhere in `PopupMenuButtonState`. **`DropdownButton`**: Currently masked by `_handleFocusChanged`, which happens to call `setState()` whenever focus changes on open/close, but should not rely on this side effect. ### Changes - Wrapped `_isMenuExpanded` assignments with `setState()` in both widgets. - For `DropdownButton`, moved `_isMenuExpanded = false` from `_removeDropdownRoute()` to the `.then()` callback with a `mounted` guard. This avoids unnecessary `setState()` calls when `_removeDropdownRoute()` is invoked during `dispose()` or orientation changes in `build()`, where the menu state isn't actually changing from user interaction. ## Tests Added regression tests for both `PopupMenuButton` and `DropdownButton` to verify the `expanded` semantics state updates correctly when the menu opens and closes. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #183432
Description
_isMenuExpandedis updated without callingsetState()in bothPopupMenuButtonandDropdownButton, so theSemantics(expanded: _isMenuExpanded)widget doesn't rebuild.PopupMenuButton: Theexpandedstate never updates at all since there is nosetState()call anywhere inPopupMenuButtonState.DropdownButton: Currently masked by_handleFocusChanged, which happens to callsetState()whenever focus changes on open/close, but should not rely on this side effect.Changes
_isMenuExpandedassignments withsetState()in both widgets.DropdownButton, moved_isMenuExpanded = falsefrom_removeDropdownRoute()to the.then()callback with amountedguard. This avoids unnecessarysetState()calls when_removeDropdownRoute()is invoked duringdispose()or orientation changes inbuild(), where the menu state isn't actually changing from user interaction.Tests
Added regression tests for both
PopupMenuButtonandDropdownButtonto verify theexpandedsemantics state updates correctly when the menu opens and closes.Pre-launch Checklist
///).