Replace BorderRadius.circular with const BorderRadius.all and update documentation examples by BrainLUX · Pull Request #183074 · flutter/flutter

BrainLUX · 2026-02-28T20:58:32Z

This PR replaces usages of BorderRadius.circular(double radius) with const BorderRadius.all(Radius.circular(radius)) (and similarly for BorderRadiusDirectional and BorderRadiusGeometry) to improve code consistency and enable const constructors where applicable.

Additionally, all code examples in the documentation have been updated to reflect this pattern, ensuring that developers see the recommended style.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

gemini-code-assist

Code Review

This pull request aims to standardize the usage of BorderRadius by replacing BorderRadius.circular with const BorderRadius.all. While the intent is good and many changes are correct, I've found several instances where this change introduces compilation errors. This is primarily due to adding const to a constructor call without ensuring all its arguments are also compile-time constants. I've also identified a couple of other issues, including a typo in documentation and incorrect usage of const with an instance variable. My review includes specific suggestions to fix these problems.

dkwingsmt

LGTM. Love to see more consts!

Can you resolve the merge conflict?

…_const # Conflicts: # packages/flutter/lib/src/material/predictive_back_page_transitions_builder.dart

victorsanni

Should we deprecate BorderRadius.circular or at least call out in its documentation when it should (not) be used?

Piinks · 2026-03-13T17:56:09Z

I feel like I recall discussion on this in the past. @BrainLUX is there an open issue this is resolving?

BrainLUX · 2026-03-14T16:51:00Z

I feel like I recall discussion on this in the past. @BrainLUX is there an open issue this is resolving?

Not an issue, but a similar MR was there a time ago #91239

And during code reviews at my work, I constantly ask to change the use of .circular to .all :)

BrainLUX · 2026-03-14T16:52:08Z

Should we deprecate BorderRadius.circular or at least call out in its documentation when it should (not) be used?

I actually really support an idea of making .circular deprecated

dkwingsmt · 2026-03-16T18:19:33Z

I doubt if it's needed. .circular is nice, concise, and convenient. Its only downside is that it's not const due to Dart's limitation of forbidding constructing objects in const initializers, which is not a problem for situations where the parameter for .circular is a variable (common in real apps).

Also, this discussion shouldn't be a blocker for this PR. Even if we're to deprecate it, it should be in a separate issue and PR.

Piinks · 2026-03-17T19:09:33Z

Not an issue, but a similar MR was there a time ago #91239

Thanks for digging this up!

Hixie left a comment at the time recommending against deprecation for the same reasons mentioned above: #91239 (comment)
I think that recommendation is still a good one. :)

This change seems fine as is to utilize const in the framework. 👍

BrainLUX · 2026-03-17T20:23:44Z

Thanks for digging this up!

Hixie left a comment at the time recommending against deprecation for the same reasons mentioned above: #91239 (comment) I think that recommendation is still a good one. :)

This change seems fine as is to utilize const in the framework. 👍

This I might omit. We lean towards brevity for our sample code so it is not overly verbose. A while back, an engineer on the team was able to demonstrate that const did not result in a perceivable performance improvement in most cases, so I think it is ok to prefer the less verbose options in sample code.

Thanks for the tip! Honestly, I'd really like to see the mentioned study on the performance of const constructors for my own development.
Also I can't help but agree that the widespread use of const BorderRadius.all instead of BorderRadius.circular adds verbosity (although, let's be honest, with shorthand, it all boils down to the laconic
const .all(.circular(radius)) – which in practice won't be as verbose).

As a compromise, I'd suggest adding a reminder to the .circular constructor's dart doc: "It's better to use the const BorderRadius.all constructor for better performance." This statement is a useful truth and will allow novice developers to even know about the existence of the .all constructor for their needs and will also give them a hint about the usefulness of const constructors in general.

What do you think?

Piinks · 2026-03-17T20:25:58Z

As a compromise, I'd suggest adding a reminder to the .circular constructor's dart doc: "It's better to use the const BorderRadius.all constructor for better performance."

SGTM! I will see if I can dig up that reference on const. IIRC, it's somewhere here on Github.

Piinks · 2026-03-17T20:28:01Z

Phew! That was easier to dig up than I thought!
Here are the const findings I referenced: #149932 (comment)

…nd update documentation examples (flutter/flutter#183074)

…documentation examples (flutter#183074) This PR replaces usages of `BorderRadius.circular(double radius)` with `const BorderRadius.all(Radius.circular(radius))` (and similarly for `BorderRadiusDirectional` and `BorderRadiusGeometry`) to improve code consistency and enable const constructors where applicable. Additionally, all code examples in the documentation have been updated to reflect this pattern, ensuring that developers see the recommended style. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Mirrors a change made in Flutter: flutter/flutter#183074

…documentation examples (flutter#183074) This PR replaces usages of `BorderRadius.circular(double radius)` with `const BorderRadius.all(Radius.circular(radius))` (and similarly for `BorderRadiusDirectional` and `BorderRadiusGeometry`) to improve code consistency and enable const constructors where applicable. Additionally, all code examples in the documentation have been updated to reflect this pattern, ensuring that developers see the recommended style. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Replace BorderRadius.circular with const BorderRadius.all

5e149e3

gemini-code-assist Bot reviewed Feb 28, 2026

View reviewed changes

BrainLUX and others added 4 commits March 1, 2026 00:18

Fix defaultStyleOf doc

2732e74

Fix progress indicator template

f6dd25f

Merge branch 'master' into make_border_radius_const

7235891

Merge branch 'master' into make_border_radius_const

4487ae3

dkwingsmt self-requested a review March 4, 2026 19:22

dkwingsmt previously approved these changes Mar 13, 2026

View reviewed changes

Merge remote-tracking branch 'flutter/master' into make_border_radius…

4a69574

…_const # Conflicts: # packages/flutter/lib/src/material/predictive_back_page_transitions_builder.dart

BrainLUX dismissed dkwingsmt’s stale review via 4a69574 March 13, 2026 07:54

Merge branch 'master' into make_border_radius_const

1c6c2dd

dkwingsmt previously approved these changes Mar 13, 2026

View reviewed changes

victorsanni reviewed Mar 13, 2026

View reviewed changes

Merge branch 'master' into make_border_radius_const

0f3b350

dkwingsmt added the CICD Run CI/CD label Mar 16, 2026

dkwingsmt requested a review from victorsanni March 16, 2026 18:36

Piinks reviewed Mar 17, 2026

View reviewed changes

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 21, 2026

662fc4aa4 Replace BorderRadius.circular with const BorderRadius.all a…

3aa0f6a

…nd update documentation examples (flutter/flutter#183074)

engine-flutter-autoroll mentioned this pull request Mar 21, 2026

Roll Flutter from dd64978dfae1 to 89e8ac09ce43 (51 revisions) flutter/packages#11317

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 21, 2026

662fc4aa4 Replace BorderRadius.circular with const BorderRadius.all a…

843de9d

…nd update documentation examples (flutter/flutter#183074)

This was referenced Mar 21, 2026

Roll Flutter from dd64978dfae1 to 89e8ac09ce43 (51 revisions) flutter/packages#11318

Closed

Roll Flutter from dd64978dfae1 to 69b4bee8d1ce (52 revisions) flutter/packages#11319

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 21, 2026

662fc4aa4 Replace BorderRadius.circular with const BorderRadius.all a…

a139560

…nd update documentation examples (flutter/flutter#183074)

engine-flutter-autoroll mentioned this pull request Mar 22, 2026

Roll Flutter from dd64978dfae1 to 75bd5b7b5816 (53 revisions) flutter/packages#11328

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2026

662fc4aa4 Replace BorderRadius.circular with const BorderRadius.all a…

4224900

…nd update documentation examples (flutter/flutter#183074)

engine-flutter-autoroll mentioned this pull request Mar 22, 2026

Roll Flutter from dd64978dfae1 to 75bd5b7b5816 (53 revisions) flutter/packages#11329

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2026

662fc4aa4 Replace BorderRadius.circular with const BorderRadius.all a…

0240964

…nd update documentation examples (flutter/flutter#183074)

engine-flutter-autoroll mentioned this pull request Mar 23, 2026

Roll Flutter from dd64978dfae1 to 17429363d473 (59 revisions) flutter/packages#11331

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2026

662fc4aa4 Replace BorderRadius.circular with const BorderRadius.all a…

95d5f79

…nd update documentation examples (flutter/flutter#183074)

engine-flutter-autoroll mentioned this pull request Mar 23, 2026

Roll Flutter from dd64978dfae1 to 41670b7bd4eb (60 revisions) flutter/packages#11332

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2026

662fc4aa4 Replace BorderRadius.circular with const BorderRadius.all a…

426d1d0

…nd update documentation examples (flutter/flutter#183074)

engine-flutter-autoroll mentioned this pull request Mar 23, 2026

Roll Flutter from dd64978dfae1 to 94c7ecb272a4 (61 revisions) flutter/packages#11335

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2026

662fc4aa4 Replace BorderRadius.circular with const BorderRadius.all a…

fe95cd8

…nd update documentation examples (flutter/flutter#183074)

engine-flutter-autoroll mentioned this pull request Mar 23, 2026

Roll Flutter from dd64978dfae1 to c7990b47e543 (63 revisions) flutter/packages#11336

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2026

662fc4aa4 Replace BorderRadius.circular with const BorderRadius.all a…

2e5f918

…nd update documentation examples (flutter/flutter#183074)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 24, 2026

662fc4aa4 Replace BorderRadius.circular with const BorderRadius.all a…

499f72d

…nd update documentation examples (flutter/flutter#183074)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 24, 2026

662fc4aa4 Replace BorderRadius.circular with const BorderRadius.all a…

ba6fe38

…nd update documentation examples (flutter/flutter#183074)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 24, 2026

662fc4aa4 Replace BorderRadius.circular with const BorderRadius.all a…

6a4b7fe

…nd update documentation examples (flutter/flutter#183074)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 24, 2026

662fc4aa4 Replace BorderRadius.circular with const BorderRadius.all a…

55bafac

…nd update documentation examples (flutter/flutter#183074)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 24, 2026

662fc4aa4 Replace BorderRadius.circular with const BorderRadius.all a…

47cd885

…nd update documentation examples (flutter/flutter#183074)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 24, 2026

662fc4aa4 Replace BorderRadius.circular with const BorderRadius.all a…

a901b06

…nd update documentation examples (flutter/flutter#183074)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2026

662fc4aa4 Replace BorderRadius.circular with const BorderRadius.all a…

7bfe3f8

…nd update documentation examples (flutter/flutter#183074)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2026

662fc4aa4 Replace BorderRadius.circular with const BorderRadius.all a…

19e5851

…nd update documentation examples (flutter/flutter#183074)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2026

662fc4aa4 Replace BorderRadius.circular with const BorderRadius.all a…

bd10431

…nd update documentation examples (flutter/flutter#183074)

adil192 added a commit to saber-notes/saber that referenced this pull request Apr 3, 2026

perf: use const BorderRadius constructor

8ad1954

Mirrors a change made in Flutter: flutter/flutter#183074

Uh oh!

Conversation

BrainLUX commented Feb 28, 2026

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dkwingsmt left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

victorsanni left a comment

Choose a reason for hiding this comment

Uh oh!

Piinks commented Mar 13, 2026

Uh oh!

BrainLUX commented Mar 14, 2026

Uh oh!

BrainLUX commented Mar 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dkwingsmt commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Piinks commented Mar 17, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BrainLUX commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Piinks commented Mar 17, 2026

Uh oh!

Piinks commented Mar 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dkwingsmt left a comment •

edited

Loading

BrainLUX commented Mar 14, 2026 •

edited

Loading

dkwingsmt commented Mar 16, 2026 •

edited

Loading

BrainLUX commented Mar 17, 2026 •

edited

Loading