[CP-stable]Exclude arm64 if any dependencies do and print warning when using Xcode 26#183028
Conversation
…de 26 (flutter#182913) If any Pod dependencies exclude the arm64 architecture for simulators, Flutter excludes it too. This will force Xcode to build it in an x86 architecture. However, iOS 26 introduced arm-only simulators. So when using Xcode 26, print a warning with the list of plugins/targets that are excluding arm and direct them to request arm support. Then if the build fails due to targeting an arm-only simulator, give a guided message to switch to an x86 simulator. Fixes flutter#182748. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
|
@vashworth please fill out the PR description above, afterwards the release team will review this request. |
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
There was a problem hiding this comment.
Code Review
This pull request updates the iOS build process to handle arm64 simulator architecture requirements, particularly with Xcode 26. It introduces logic to detect if any plugin dependencies do not support arm64, and if so, excludes arm64 from the app's simulator architectures to prevent build failures. It also adds warnings for developers when this occurs on Xcode 26+ and improves diagnostics for related build errors. My review identified two potential issues: one regarding the parsing of pod names for resource bundles, which could lead to incorrect dependency analysis, and another concerning the format of the runtime argument for a simctl command in the new diagnostics logic. I have provided suggestions to address both of these points.
8442d07
into
flutter:flutter-3.41-candidate.0
…arning when using Xcode 26 (flutter/flutter#183028)
…n using Xcode 26 (flutter#183028) This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. What is the link to the issue this cherry-pick is addressing? flutter#182748 What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping of production apps (the app crashes on launch). This information is for domain experts and release engineers to understand the consequences of saying yes or no to the cherry pick. Build targeting an iOS simulator with Xcode 26 fails when a CocoaPod dependency does not support arm. Explain this cherry pick: * In one line that is accessible to most Flutter developers. * That describes the state prior to the fix. * That includes which platforms are impacted. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples. [flutter/182748] When building for an iOS simulator with Xcode 26, the build will fail when there is a CocoaPod dependency that does not support arm. Is there a workaround for this issue? Use Xcode 16 or use older version of Flutter. What is the risk level of this cherry-pick? Are you confident that your fix is well-tested by automated tests? What are the steps to validate that this fix works? 1. Create a Flutter project 2. Add a dependency that doesn't support arm (e.g. google_ml_kit) 3. `flutter build ios --simulator --debug`
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
#182748
Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)?
Does it impact development (ex. flutter doctor crashes when Android Studio is installed),
or the shipping of production apps (the app crashes on launch).
This information is for domain experts and release engineers to understand the consequences of saying yes or no to the cherry pick.
Build targeting an iOS simulator with Xcode 26 fails when a CocoaPod dependency does not support arm.
Changelog Description:
Explain this cherry pick:
See best practices for examples.
[flutter/182748] When building for an iOS simulator with Xcode 26, the build will fail when there is a CocoaPod dependency that does not support arm.
Workaround:
Is there a workaround for this issue?
Use Xcode 16 or use older version of Flutter.
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
flutter build ios --simulator --debug