Manual dart sdk flutter 174bcc79 25ff 4267 8e26 d0e902f18681 1771486449#182624
Merged
Conversation
https://dart.googlesource.com/sdk.git/+log/2642761fca94..f8fac50475b8 2026-02-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.12.0-162.0.dev 2026-02-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.12.0-161.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Contributor
There was a problem hiding this comment.
Code Review
The pull request addresses issue #182617 by adding // ignore: prefer_initializing_formals comments to several constructors and disabling the prefer_initializing_formals lint rule in engine/src/flutter/analysis_options.yaml. This change effectively suppresses the lint warning for these specific constructors, which is a common practice when dealing with certain Flutter widget patterns. The changes are straightforward and directly target the reported issue.
| /// Provides controls to change the zoom level of a [WidgetPreview]. | ||
| class ZoomControls extends StatelessWidget { | ||
| /// Provides controls to change the zoom level of a [WidgetPreview]. | ||
| // ignore: prefer_initializing_formals |
Contributor
There was a problem hiding this comment.
Adding // ignore: prefer_initializing_formals directly above the constructor is a valid way to suppress this lint for specific cases. This is consistent with the overall approach taken in this PR to address the lint warning.
|
|
||
| /// IDE-supplied theming. | ||
| final class IdeTheme { | ||
| // ignore: prefer_initializing_formals |
Contributor
There was a problem hiding this comment.
The // ignore: prefer_initializing_formals comment is correctly placed to suppress the lint for the IdeTheme constructor. This aligns with the PR's objective to resolve the lint issue.
|
|
||
| /// Custom render box that forces constraints onto unconstrained widgets. | ||
| class _WidgetPreviewWrapperBox extends RenderShiftedBox { | ||
| // ignore: prefer_initializing_formals |
Contributor
There was a problem hiding this comment.
The // ignore: prefer_initializing_formals comment is appropriately added to the _WidgetPreviewWrapperBox constructor, addressing the lint warning for this specific constructor.
| /// Controller used to process events and determine which previews should be | ||
| /// displayed and how they should be displayed in the [WidgetPreviewScaffold]. | ||
| class WidgetPreviewScaffoldController { | ||
| // ignore: prefer_initializing_formals |
Contributor
There was a problem hiding this comment.
Adding // ignore: prefer_initializing_formals to the WidgetPreviewScaffoldController constructor resolves the lint warning for this class, maintaining consistency with the other changes in this PR.
| missing_whitespace_between_adjacent_strings: false # too many false positives | ||
| public_member_api_docs: true # dart:ui is public API | ||
| use_string_in_part_of_directives: false # needs to be evaluated, dart:ui frequently uses non-strings | ||
| prefer_initializing_formals: false # https://github.com/flutter/flutter/issues/182617#issuecomment-3928680061 |
Contributor
There was a problem hiding this comment.
Disabling prefer_initializing_formals in the analysis_options.yaml file is a global change that suppresses this lint across the entire engine. While this resolves the immediate issue, it's important to ensure that this lint is not generally desired for other parts of the codebase. The comment linking to the GitHub issue provides good context for this decision.
jtmcdole
approved these changes
Feb 19, 2026
munificent
approved these changes
Feb 19, 2026
| final class IdeTheme { | ||
| // ignore: prefer_initializing_formals | ||
| const IdeTheme({this.backgroundColor, this.foregroundColor, bool? isDarkMode}) | ||
| : _isDarkMode = isDarkMode; |
Contributor
There was a problem hiding this comment.
The lint will fire on this line. If the ignore comment seems to be working where it is, then SGTM, but you may need to move it to the end of this line or one line above this one. Likewise below.
Member
Author
There was a problem hiding this comment.
I wasn't able to reproduce the failure locally to verify. Gemini told me this is the right place for it to go. I originally had it like this:
const IdeTheme({this.backgroundColor, this.foregroundColor, bool? isDarkMode})
// ignore: prefer_initializing_formals
: _isDarkMode = isDarkMode;Having it at the beginning of the statement makes sense to me since there can be multiple instances of initializers, I'm not sure if the analyzer agrees.
Member
Author
There was a problem hiding this comment.
I moved them, the old position didn't work as suspected. It is weird because in that one case we have 2 initializers, but only one lint failure is issued. I'm guessing one ignore is sufficient since only one failure was issued.
Contributor
|
autosubmit label was removed for flutter/flutter/182624, because - The status or check suite Mac_arm64 tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
Contributor
|
autosubmit label was removed for flutter/flutter/182624, because - The status or check suite Linux tool_tests_widget_preview_scaffold has failed. Please fix the issues identified (or deflake) before re-applying this label. |
munificent
approved these changes
Feb 19, 2026
munificent
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for fixing what I broke and unblocking the roll.
| super.key, | ||
| required TransformationController transformationController, | ||
| // ignore: prefer_initializing_formals | ||
| }) : _transformationController = transformationController; |
Contributor
There was a problem hiding this comment.
Style nit, but I'd put the comment outside of the parameter list so it's clearer that it applies to the initializer:
const ZoomControls({
super.key,
required TransformationController transformationController,
}) : // ignore: prefer_initializing_formals
_transformationController = transformationController;Likewise elsewhere, but it's up to you.
Member
Author
There was a problem hiding this comment.
Oh yea, that's nicer. I unfortunately didn't have a setup where i could reproduce the problem locally so I couldn't play around with it. I didn't know the analyzer can recognized ignores if there is non-whitespace before the comment.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 21, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 21, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 21, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 22, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 22, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 22, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 23, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 23, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Feb 23, 2026
flutter/flutter@91b2d41...dad6f9d 2026-02-23 engine-flutter-autoroll@skia.org Roll Packages from 9da22bf to 12b43a1 (19 revisions) (flutter/flutter#182758) 2026-02-23 engine-flutter-autoroll@skia.org Roll Skia from 55fae1660572 to 9a5a3c92c336 (7 revisions) (flutter/flutter#182749) 2026-02-23 engine-flutter-autoroll@skia.org Roll Skia from 256e2b47b303 to 55fae1660572 (1 revision) (flutter/flutter#182741) 2026-02-22 engine-flutter-autoroll@skia.org Roll Skia from 141ed451f007 to 256e2b47b303 (1 revision) (flutter/flutter#182732) 2026-02-22 engine-flutter-autoroll@skia.org Roll Skia from e59de8a12e7e to 141ed451f007 (1 revision) (flutter/flutter#182729) 2026-02-22 engine-flutter-autoroll@skia.org Roll Skia from f6ea7ef42d14 to e59de8a12e7e (1 revision) (flutter/flutter#182726) 2026-02-22 engine-flutter-autoroll@skia.org Roll Skia from 34fa7b2373f3 to f6ea7ef42d14 (1 revision) (flutter/flutter#182721) 2026-02-21 engine-flutter-autoroll@skia.org Roll Skia from 3ca547c8b816 to 34fa7b2373f3 (2 revisions) (flutter/flutter#182711) 2026-02-21 engine-flutter-autoroll@skia.org Roll Skia from c91ad88e89f8 to 3ca547c8b816 (9 revisions) (flutter/flutter#182696) 2026-02-21 victorsanniay@gmail.com Shortcircuit if Tooltip message and richMessage are empty (flutter/flutter#182524) 2026-02-21 50643541+Mairramer@users.noreply.github.com Add fields getter to FormState (flutter/flutter#180815) 2026-02-20 1961493+harryterkelsen@users.noreply.github.com fix(web_ui): use static whitelist for image codec tests (flutter/flutter#182648) 2026-02-20 victorsanniay@gmail.com Add cupertino docimports for CupertinoPageTransitionsBuilder and fix typos (flutter/flutter#182685) 2026-02-20 katelovett@google.com Fix Chat invite link (flutter/flutter#182675) 2026-02-20 engine-flutter-autoroll@skia.org Roll Skia from ce5854495a3a to c91ad88e89f8 (58 revisions) (flutter/flutter#182678) 2026-02-20 30870216+gaaclarke@users.noreply.github.com Manual dart sdk flutter 174bcc79 25ff 4267 8e26 d0e902f18681 1771486449 (flutter/flutter#182624) 2026-02-20 97480502+b-luk@users.noreply.github.com Don't compile shaders to SkSL unless --sksl arg is present (flutter/flutter#182519) 2026-02-20 katelovett@google.com Correct PerformanceOverlay optionsMask checks and add tests (flutter/flutter#182309) 2026-02-20 jason-simmons@users.noreply.github.com [Impeller] libImpeller: Dispose thread local caches on each Vulkan frame (flutter/flutter#182402) 2026-02-20 31859944+LongCatIsLooong@users.noreply.github.com Update CHANGELOG for 3.41.2 stable hotfix (flutter/flutter#182647) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ahmedsameha1
pushed a commit
to ahmedsameha1/flutter
that referenced
this pull request
Feb 27, 2026
…49 (flutter#182624) fixes flutter#182617 manual roll for flutter#182591 https://dart.googlesource.com/sdk.git/+log/2642761fca94..f8fac50475b8 --------- Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
okorohelijah
pushed a commit
to okorohelijah/packages
that referenced
this pull request
Mar 26, 2026
…r#11102) flutter/flutter@91b2d41...dad6f9d 2026-02-23 engine-flutter-autoroll@skia.org Roll Packages from 9da22bf to 12b43a1 (19 revisions) (flutter/flutter#182758) 2026-02-23 engine-flutter-autoroll@skia.org Roll Skia from 55fae1660572 to 9a5a3c92c336 (7 revisions) (flutter/flutter#182749) 2026-02-23 engine-flutter-autoroll@skia.org Roll Skia from 256e2b47b303 to 55fae1660572 (1 revision) (flutter/flutter#182741) 2026-02-22 engine-flutter-autoroll@skia.org Roll Skia from 141ed451f007 to 256e2b47b303 (1 revision) (flutter/flutter#182732) 2026-02-22 engine-flutter-autoroll@skia.org Roll Skia from e59de8a12e7e to 141ed451f007 (1 revision) (flutter/flutter#182729) 2026-02-22 engine-flutter-autoroll@skia.org Roll Skia from f6ea7ef42d14 to e59de8a12e7e (1 revision) (flutter/flutter#182726) 2026-02-22 engine-flutter-autoroll@skia.org Roll Skia from 34fa7b2373f3 to f6ea7ef42d14 (1 revision) (flutter/flutter#182721) 2026-02-21 engine-flutter-autoroll@skia.org Roll Skia from 3ca547c8b816 to 34fa7b2373f3 (2 revisions) (flutter/flutter#182711) 2026-02-21 engine-flutter-autoroll@skia.org Roll Skia from c91ad88e89f8 to 3ca547c8b816 (9 revisions) (flutter/flutter#182696) 2026-02-21 victorsanniay@gmail.com Shortcircuit if Tooltip message and richMessage are empty (flutter/flutter#182524) 2026-02-21 50643541+Mairramer@users.noreply.github.com Add fields getter to FormState (flutter/flutter#180815) 2026-02-20 1961493+harryterkelsen@users.noreply.github.com fix(web_ui): use static whitelist for image codec tests (flutter/flutter#182648) 2026-02-20 victorsanniay@gmail.com Add cupertino docimports for CupertinoPageTransitionsBuilder and fix typos (flutter/flutter#182685) 2026-02-20 katelovett@google.com Fix Chat invite link (flutter/flutter#182675) 2026-02-20 engine-flutter-autoroll@skia.org Roll Skia from ce5854495a3a to c91ad88e89f8 (58 revisions) (flutter/flutter#182678) 2026-02-20 30870216+gaaclarke@users.noreply.github.com Manual dart sdk flutter 174bcc79 25ff 4267 8e26 d0e902f18681 1771486449 (flutter/flutter#182624) 2026-02-20 97480502+b-luk@users.noreply.github.com Don't compile shaders to SkSL unless --sksl arg is present (flutter/flutter#182519) 2026-02-20 katelovett@google.com Correct PerformanceOverlay optionsMask checks and add tests (flutter/flutter#182309) 2026-02-20 jason-simmons@users.noreply.github.com [Impeller] libImpeller: Dispose thread local caches on each Vulkan frame (flutter/flutter#182402) 2026-02-20 31859944+LongCatIsLooong@users.noreply.github.com Update CHANGELOG for 3.41.2 stable hotfix (flutter/flutter#182647) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Mar 26, 2026
…49 (flutter#182624) fixes flutter#182617 manual roll for flutter#182591 https://dart.googlesource.com/sdk.git/+log/2642761fca94..f8fac50475b8 --------- Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…r#11102) flutter/flutter@91b2d41...dad6f9d 2026-02-23 engine-flutter-autoroll@skia.org Roll Packages from 9da22bf to 12b43a1 (19 revisions) (flutter/flutter#182758) 2026-02-23 engine-flutter-autoroll@skia.org Roll Skia from 55fae1660572 to 9a5a3c92c336 (7 revisions) (flutter/flutter#182749) 2026-02-23 engine-flutter-autoroll@skia.org Roll Skia from 256e2b47b303 to 55fae1660572 (1 revision) (flutter/flutter#182741) 2026-02-22 engine-flutter-autoroll@skia.org Roll Skia from 141ed451f007 to 256e2b47b303 (1 revision) (flutter/flutter#182732) 2026-02-22 engine-flutter-autoroll@skia.org Roll Skia from e59de8a12e7e to 141ed451f007 (1 revision) (flutter/flutter#182729) 2026-02-22 engine-flutter-autoroll@skia.org Roll Skia from f6ea7ef42d14 to e59de8a12e7e (1 revision) (flutter/flutter#182726) 2026-02-22 engine-flutter-autoroll@skia.org Roll Skia from 34fa7b2373f3 to f6ea7ef42d14 (1 revision) (flutter/flutter#182721) 2026-02-21 engine-flutter-autoroll@skia.org Roll Skia from 3ca547c8b816 to 34fa7b2373f3 (2 revisions) (flutter/flutter#182711) 2026-02-21 engine-flutter-autoroll@skia.org Roll Skia from c91ad88e89f8 to 3ca547c8b816 (9 revisions) (flutter/flutter#182696) 2026-02-21 victorsanniay@gmail.com Shortcircuit if Tooltip message and richMessage are empty (flutter/flutter#182524) 2026-02-21 50643541+Mairramer@users.noreply.github.com Add fields getter to FormState (flutter/flutter#180815) 2026-02-20 1961493+harryterkelsen@users.noreply.github.com fix(web_ui): use static whitelist for image codec tests (flutter/flutter#182648) 2026-02-20 victorsanniay@gmail.com Add cupertino docimports for CupertinoPageTransitionsBuilder and fix typos (flutter/flutter#182685) 2026-02-20 katelovett@google.com Fix Chat invite link (flutter/flutter#182675) 2026-02-20 engine-flutter-autoroll@skia.org Roll Skia from ce5854495a3a to c91ad88e89f8 (58 revisions) (flutter/flutter#182678) 2026-02-20 30870216+gaaclarke@users.noreply.github.com Manual dart sdk flutter 174bcc79 25ff 4267 8e26 d0e902f18681 1771486449 (flutter/flutter#182624) 2026-02-20 97480502+b-luk@users.noreply.github.com Don't compile shaders to SkSL unless --sksl arg is present (flutter/flutter#182519) 2026-02-20 katelovett@google.com Correct PerformanceOverlay optionsMask checks and add tests (flutter/flutter#182309) 2026-02-20 jason-simmons@users.noreply.github.com [Impeller] libImpeller: Dispose thread local caches on each Vulkan frame (flutter/flutter#182402) 2026-02-20 31859944+LongCatIsLooong@users.noreply.github.com Update CHANGELOG for 3.41.2 stable hotfix (flutter/flutter#182647) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #182617
manual roll for #182591
https://dart.googlesource.com/sdk.git/+log/2642761fca94..f8fac50475b8