3.41.2 Changelog#182518
Conversation
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
There was a problem hiding this comment.
Code Review
This pull request updates the CHANGELOG.md file with entries for version 3.41.2. My review focuses on ensuring the new entries adhere to the project's documentation guidelines. I have suggested a minor wording improvement for one of the entries to better describe the problem from a user's perspective, making it more useful as per the style guide.
| ### [3.41.2](https://github.com/flutter/flutter/releases/tag/3.41.2) | ||
|
|
||
| - [flutter/179673](https://github.com/flutter/flutter/issues/179673) When content sizing is not enabled on Android, a race condition can sometimes make platform views not render correctly. | ||
| - [flutter/182076](https://github.com/flutter/flutter/issues/182076) Fix flutter build web ignoring --web-define flag |
There was a problem hiding this comment.
This changelog entry could be more descriptive for users. According to the repository's style guide and the notes in CHANGELOG.md itself, documentation should be useful and explain the 'why'. For changelogs, this means describing the problem from the user's perspective, not just stating the fix. This helps users quickly determine if they are affected.
A more descriptive entry would be:
"When building for web, flutter build web ignores the --web-define flag."
| - [flutter/182076](https://github.com/flutter/flutter/issues/182076) Fix flutter build web ignoring --web-define flag | |
| - [flutter/182076](https://github.com/flutter/flutter/issues/182076) When building for web, `flutter build web` ignores the `--web-define` flag. |
References
- Documentation should be useful and explain the 'why' and the 'how'. For changelog entries, this means describing the problem from the user's perspective to help them understand the impact. (link)
2dc1c8d
into
flutter:flutter-3.41-candidate.0
**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.