[CP][stable] Fix bug in multisurfacerenderer where canvases do not have "position: absolute"#182299
Conversation
…ve "position: absolute"
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
There was a problem hiding this comment.
Code Review
This pull request effectively addresses a critical bug causing platform views to be invisible on Safari and Firefox by ensuring canvases have the position: absolute CSS property. The changes also include valuable refactoring in the Renderer class, extracting view listener setup into a dedicated method for improved modularity and readability. The debugClear method has been enhanced to provide a more robust state reset for testing, including proper listener cancellation and rasterizer disposal. A new, well-structured test case has been added to validate the position: absolute fix, demonstrating a commitment to correctness and test coverage. Overall, these changes significantly improve the stability and maintainability of the web rendering engine.
| ..width = cssWidth | ||
| ..height = cssHeight; | ||
| ..height = cssHeight | ||
| ..position = 'absolute'; |
There was a problem hiding this comment.
This addition directly addresses the bug where canvases were not visible on certain browsers due to missing position: absolute. This is a critical fix for rendering correctness.
| _onViewCreatedListener.cancel(); | ||
| _onViewDisposedListener.cancel(); |
There was a problem hiding this comment.
Cancelling the _onViewCreatedListener and _onViewDisposedListener in debugClear is crucial for preventing potential memory leaks and ensuring a clean state reset, especially in test environments. This improves correctness and maintainability.
|
@mdebbar it looks like this didn't merge cleanly could you please add an additional reviewer? |
6c0baae
into
flutter:flutter-3.41-candidate.0
… do not have "position: absolute" (flutter/flutter#182299)
… do not have "position: absolute" (flutter/flutter#182299)
… do not have "position: absolute" (flutter/flutter#182299)
This CP pull request was created manually.
Cherry-pick of #181053
Issue Link:
What is the link to the issue this cherry-pick is addressing?
Closes #182292
Changelog Description:
Fix bug in multisurfacerenderer where canvases do not have "position: absolute"
Impact Description:
Platform views not visible on Safari and Firefox.
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
Follow repro steps in #182292