Skip to content

Reland - Update date localization#182189

Merged
auto-submit[bot] merged 2 commits into
flutter:masterfrom
QuncCccccc:revert-182182
Feb 11, 2026
Merged

Reland - Update date localization#182189
auto-submit[bot] merged 2 commits into
flutter:masterfrom
QuncCccccc:revert-182182

Conversation

@QuncCccccc

@QuncCccccc QuncCccccc commented Feb 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR is a reland of #181685. The update introduced NBSP to connect time and its period(am or pm), so some invisible breakages are expected.

Fix is added in the second commit.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions Bot added tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. a: internationalization Supporting other languages or locales. (aka i18n) labels Feb 11, 2026
@QuncCccccc QuncCccccc marked this pull request as ready for review February 11, 2026 00:30
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Feb 11, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates date and time localization formats across several test files. The changes include using narrow no-break spaces (U+202F) to prevent awkward line breaks in Russian and English time formats, updating Arabic numerals to Western style, and removing a comma from the en_GB medium date format. Additionally, a test utility function (_pumpBoilerplate) is corrected to properly use the provided textDirection. I have one suggestion for consistency.

Comment thread packages/flutter_tools/test/integration.shard/gen_l10n_test.dart
@QuncCccccc

QuncCccccc commented Feb 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Added a g3fix cl/868385623. The rest of the failures should just be Scubas and expected.

@QuncCccccc QuncCccccc requested a review from Piinks February 11, 2026 01:09
Piinks
Piinks approved these changes Feb 11, 2026
View reviewed changes

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 11, 2026
@auto-submit auto-submit Bot added this pull request to the merge queue Feb 11, 2026
Merged via the queue into flutter:master with commit 3ea1619 Feb 11, 2026
142 of 143 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 11, 2026
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2026
@engine-flutter-autoroll
3ea161909 Reland - Update date localization (flutter/flutter#182189)
ef7a7f7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2026
@engine-flutter-autoroll
3ea161909 Reland - Update date localization (flutter/flutter#182189)
ab3ec22
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2026
@engine-flutter-autoroll
3ea161909 Reland - Update date localization (flutter/flutter#182189)
ed4accc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2026
@engine-flutter-autoroll
3ea161909 Reland - Update date localization (flutter/flutter#182189)
1bc677b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2026
@engine-flutter-autoroll
3ea161909 Reland - Update date localization (flutter/flutter#182189)
8244ca2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2026
@engine-flutter-autoroll
3ea161909 Reland - Update date localization (flutter/flutter#182189)
b55a3c5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 13, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2026
@engine-flutter-autoroll
3ea161909 Reland - Update date localization (flutter/flutter#182189)
ce84784
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 13, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2026
@engine-flutter-autoroll
3ea161909 Reland - Update date localization (flutter/flutter#182189)
833efcd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 13, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2026
@engine-flutter-autoroll
3ea161909 Reland - Update date localization (flutter/flutter#182189)
0a3de4d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2026
@engine-flutter-autoroll
3ea161909 Reland - Update date localization (flutter/flutter#182189)
a1ffb63
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2026
@engine-flutter-autoroll
3ea161909 Reland - Update date localization (flutter/flutter#182189)
8c7ea6e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2026
@engine-flutter-autoroll
3ea161909 Reland - Update date localization (flutter/flutter#182189)
e91a1cb
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2026
@engine-flutter-autoroll
3ea161909 Reland - Update date localization (flutter/flutter#182189)
cadee8f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2026
@engine-flutter-autoroll
3ea161909 Reland - Update date localization (flutter/flutter#182189)
6f54fe7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2026
@engine-flutter-autoroll
3ea161909 Reland - Update date localization (flutter/flutter#182189)
9cb4db6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2026
@engine-flutter-autoroll
3ea161909 Reland - Update date localization (flutter/flutter#182189)
88a6ec5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2026
@engine-flutter-autoroll
3ea161909 Reland - Update date localization (flutter/flutter#182189)
1d41083
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2026
@engine-flutter-autoroll
3ea161909 Reland - Update date localization (flutter/flutter#182189)
0809e37
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2026
@engine-flutter-autoroll
3ea161909 Reland - Update date localization (flutter/flutter#182189)
d7c9b70
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2026
@engine-flutter-autoroll
3ea161909 Reland - Update date localization (flutter/flutter#182189)
599744b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2026
@engine-flutter-autoroll
3ea161909 Reland - Update date localization (flutter/flutter#182189)
f8fad23
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2026
@engine-flutter-autoroll
3ea161909 Reland - Update date localization (flutter/flutter#182189)
b5c59c1
rickhohler pushed a commit to rickhohler/flutter that referenced this pull request Feb 19, 2026
@QuncCccccc @rickhohler
Reland - Update date localization (flutter#182189)
341047f 
This PR is a reland of flutter#181685.
The update introduced NBSP to connect time and its period(am or pm), so
some invisible breakages are expected.

Fix is added in the second
[commit](flutter@06be40e).

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
mboetger pushed a commit to mboetger/flutter that referenced this pull request Mar 26, 2026
@QuncCccccc @mboetger
Reland - Update date localization (flutter#182189)
d65c75c 
This PR is a reland of flutter#181685.
The update introduced NBSP to connect time and its period(am or pm), so
some invisible breakages are expected.

Fix is added in the second
[commit](flutter@06be40e).

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
@ziyad-aljohani ziyad-aljohani mentioned this pull request Jun 10, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: internationalization Supporting other languages or locales. (aka i18n) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@QuncCccccc @Piinks