Clean up include paths for Fuchsia in the flutter engine#182031
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors include paths for Fuchsia-specific code in the Flutter engine to use full paths from the source root. This is a great cleanup that improves maintainability by removing reliance on relative paths and include_dirs configurations in BUILD.gn files. The changes also include removing several unused headers and build configurations, which further cleans up the codebase.
I've found a couple of typos in the new include paths that would likely cause build failures. Please see my detailed comments.
| // found in the LICENSE file. | ||
|
|
||
| #include "dart_runner/dart_test_component_controller.h" | ||
| #include "flutter/shell/platform/fuchsia/dart_runner/tets/dart_runner/dart_test_component_controller.h" |
Contributor
There was a problem hiding this comment.
There seems to be a typo in this include path. It should be tests instead of tets. Additionally, the path seems incorrect. The correct full path for dart_test_component_controller.h should be flutter/shell/platform/fuchsia/dart_runner/dart_test_component_controller.h.
Suggested change
| #include "flutter/shell/platform/fuchsia/dart_runner/tets/dart_runner/dart_test_component_controller.h" | |
| #include "flutter/shell/platform/fuchsia/dart_runner/dart_test_component_controller.h" |
| // found in the LICENSE file. | ||
|
|
||
| #include "fakes/scenic/fake_flatland.h" | ||
| #include "flutter/shell/platform/fuchsia/flutter/fakes/scenic/fake_flatland.h" |
Contributor
There was a problem hiding this comment.
This include path appears to be incorrect as it's missing the tests directory segment.
Suggested change
| #include "flutter/shell/platform/fuchsia/flutter/fakes/scenic/fake_flatland.h" | |
| #include "flutter/shell/platform/fuchsia/flutter/tests/fakes/scenic/fake_flatland.h" |
This rewrites many of the include paths in Fuchsia engine code to use the full path of the file. For example: ```diff -#include "runtime/dart/utils/inlines.h" +#include "flutter/shell/platform/fuchsia/runtime/dart/utils/inlines.h" ``` I also cleaned up a few unused includes and convered the includes for the Fuchsia SDK to using angle backets.
b3701f3 to
83003dc
Compare
Contributor
|
LGTM |
jrwang
approved these changes
Feb 10, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 14, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 14, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 14, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 14, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 15, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 15, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 15, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 17, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 17, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 17, 2026
rickhohler
pushed a commit
to rickhohler/flutter
that referenced
this pull request
Feb 19, 2026
) This rewrites many of the include paths in Fuchsia engine code to use the full path of the file. For example: ```diff -#include "runtime/dart/utils/inlines.h" +#include "flutter/shell/platform/fuchsia/runtime/dart/utils/inlines.h" ``` I also cleaned up a few unused includes and convered the includes for the Fuchsia SDK to using angle backets. ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing.
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Mar 26, 2026
) This rewrites many of the include paths in Fuchsia engine code to use the full path of the file. For example: ```diff -#include "runtime/dart/utils/inlines.h" +#include "flutter/shell/platform/fuchsia/runtime/dart/utils/inlines.h" ``` I also cleaned up a few unused includes and convered the includes for the Fuchsia SDK to using angle backets. ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rewrites many of the include paths in Fuchsia engine code to use the full path of the file. For example:
I also cleaned up a few unused includes and convered the includes for the Fuchsia SDK to using angle backets.
Pre-launch Checklist
///).