Skip to content

[ Tool ] Fix regression introduced in flutter/flutter#181421#181826

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
bkonyi:fix_regression_resident_compiler_refactor
Feb 3, 2026
Merged

[ Tool ] Fix regression introduced in flutter/flutter#181421#181826
auto-submit[bot] merged 1 commit into
flutter:masterfrom
bkonyi:fix_regression_resident_compiler_refactor

Conversation

@bkonyi

@bkonyi bkonyi commented Feb 2, 2026 •
edited by loic-sharma
Loading

Copy link
Copy Markdown
Contributor

dev/devicelab/bin/task/flutter_test_performance.dart regressed due to the CFE not being initialized with the correct dill file for the target test. This change updates TestCompiler to pass the correct dill file when creating the ResidentCompiler and adds a test to verify that the ResidentCompiler is initialized with the correct dill.

See: #181421.

@bkonyi
[ Tool ] Fix regression introduced in flutter#181421
0b5c346 
`dev/devicelab/bin/task/flutter_test_performance.dart` regressed due to
the CFE not being initialized with the correct dill file for the target
test. This change updates `TestCompiler` to pass the correct dill file
when creating the `ResidentCompiler` and adds a test to verify that the
`ResidentCompiler` is initialized with the correct dill.
@bkonyi bkonyi requested a review from gaaclarke February 2, 2026 20:13
@bkonyi bkonyi mentioned this pull request Feb 2, 2026
Merged
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Feb 2, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a regression in TestCompiler by ensuring the ResidentCompiler is initialized with the correct dill file. The TestCompiler constructor is updated to use the provided BuildInfo to compute the testFilePath, and then creates a new BuildInfo for the instance with initializeFromDill set to this path. A test is also added to FakeTestCompiler to verify this behavior and prevent future regressions.

gaaclarke
gaaclarke approved these changes Feb 2, 2026
View reviewed changes

@gaaclarke gaaclarke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks

@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 2, 2026
@auto-submit

auto-submit Bot commented Feb 2, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/181826, because - The status or check suite triage has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 2, 2026
@bkonyi bkonyi added team-tool Owned by Flutter Tool team autosubmit Merge PR when tree becomes green via auto submit App labels Feb 2, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 2, 2026
@auto-submit

auto-submit Bot commented Feb 2, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/181826, because - The status or check suite triage has failed. Please fix the issues identified (or deflake) before re-applying this label.

@github-actions github-actions Bot added tool Affects the "flutter" command-line tool. See also t: labels. and removed team-tool Owned by Flutter Tool team labels Feb 3, 2026
@bkonyi bkonyi added autosubmit Merge PR when tree becomes green via auto submit App team-tool Owned by Flutter Tool team and removed tool Affects the "flutter" command-line tool. See also t: labels. labels Feb 3, 2026
@auto-submit auto-submit Bot added this pull request to the merge queue Feb 3, 2026
Merged via the queue into flutter:master with commit 9b30164 Feb 3, 2026
151 of 153 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 3, 2026
@Mairramer Mairramer mentioned this pull request Feb 3, 2026
Merged
9 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2026
@engine-flutter-autoroll
9b30164e6 [ Tool ] Fix regression introduced in flutter/flutter#181421 (
7b33a3f 
flutter/flutter#181826)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2026
@engine-flutter-autoroll
9b30164e6 [ Tool ] Fix regression introduced in flutter/flutter#181421 (
da89367 
flutter/flutter#181826)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2026
@engine-flutter-autoroll
9b30164e6 [ Tool ] Fix regression introduced in flutter/flutter#181421 (
794fb78 
flutter/flutter#181826)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2026
Merged
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Feb 5, 2026
@engine-flutter-autoroll
Roll Flutter from bf701fefec86 to f916dd6887bf (44 revisions) (#10967)
c197455 
Roll Flutter from bf701fefec86 to f916dd6887bf (44 revisions)

flutter/flutter@bf701fe...f916dd6

2026-02-05 nemeth@marcell.it Implement macOS wide gamut (Display P3) support (flutter/flutter#181769)
2026-02-04 engine-flutter-autoroll@skia.org Roll Skia from d23ecfbfdff9 to 8543ce512d5c (3 revisions) (flutter/flutter#181923)
2026-02-04 engine-flutter-autoroll@skia.org Roll Dart SDK from 8001c99d952b to 8f778ffd318b (3 revisions) (flutter/flutter#181927)
2026-02-04 jason-simmons@users.noreply.github.com Re-enable AddressSanitizer on the linux_unopt builder (flutter/flutter#181741)
2026-02-04 1063596+reidbaker@users.noreply.github.com Add exception to log message in ContentSizingFlag.java (flutter/flutter#181813)
2026-02-04 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#181925)
2026-02-04 nshahan@google.com [flutter_tools] Deprecate web hot reload flag (flutter/flutter#181884)
2026-02-04 magder@google.com Marks platform_views_scroll_perf_impeller__timeline_summary unflaky (flutter/flutter#181649)
2026-02-04 engine-flutter-autoroll@skia.org Roll Dart SDK from 204db085d970 to 8001c99d952b (1 revision) (flutter/flutter#181902)
2026-02-04 engine-flutter-autoroll@skia.org Roll Skia from f37a22506eb4 to d23ecfbfdff9 (23 revisions) (flutter/flutter#181915)
2026-02-04 jason-simmons@users.noreply.github.com In the Web codec tests, skip an undecodable image that is used to test a Skia error handling code path. (flutter/flutter#181870)
2026-02-04 engine-flutter-autoroll@skia.org Roll Packages from 5b1bea8 to 3bddf2c (5 revisions) (flutter/flutter#181918)
2026-02-04 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from UmQaaNuhkiuE8Dzug... to J2QdLcY2gyt4NP_xV... (flutter/flutter#181893)
2026-02-04 engine-flutter-autoroll@skia.org Roll Dart SDK from 54322a0b1109 to 204db085d970 (3 revisions) (flutter/flutter#181890)
2026-02-04 nurdaulet.97@gmail.com Cleanup cross imports (flutter/flutter#181807)
2026-02-04 kazbek.sultanov.doc@gmail.com [Material] Remove Material import from backdrop_filter_test.dart widget tests (flutter/flutter#181386)
2026-02-04 kazbek.sultanov.doc@gmail.com Move CheckedModeBanner tests to material and remove Material import from widgets banner_test (flutter/flutter#181261)
2026-02-04 git@reb0.org feat: Pass parameters from DropdownMenuFormField to DropDownMenu (flutter/flutter#181373)
2026-02-04 116356835+AbdeMohlbi@users.noreply.github.com Remove `Config complete` log when using `flutter build apk --config-only` (flutter/flutter#181864)
2026-02-04 flar@google.com [Impeller] Fix flattening of very large zoomed curves with tiny stroke widths (flutter/flutter#181505)
2026-02-03 prbillingsley89@gmail.com Propagates Overlay's MediaQueryData to OverlayPortal child (flutter/flutter#181579)
2026-02-03 ahmedsameha1@gmail.com Make sure that an AnimatedScale doesn't crash in 0x0 environment (flutter/flutter#181481)
2026-02-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 56294a92d5cc to 54322a0b1109 (1 revision) (flutter/flutter#181872)
2026-02-03 zemanux@users.noreply.github.com Fix decorated box (flutter/flutter#179802)
2026-02-03 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#181871)
2026-02-03 70534390+Erengun@users.noreply.github.com Remove Material library dependency from expansible_test.dart (flutter/flutter#181657)
2026-02-03 evanwall@buffalo.edu Organize and update fragment shader uniform tests. (flutter/flutter#181822)
2026-02-03 1961493+harryterkelsen@users.noreply.github.com fix(web_ui): handle non-invertible matrices in ImageFilter.matrix (flutter/flutter#181742)
2026-02-03 nhan13574@gmail.com Remove unnecessary Material import from cupertino/slider_test.dart (flutter/flutter#180957)
2026-02-03 15619084+vashworth@users.noreply.github.com Remove the Flutter.xcframework as a swift dependency (flutter/flutter#181739)
2026-02-03 matt.kosarek@canonical.com feature: implementation of tooltips in the `_TestWindowingOwner` and minor bugfixes to the multiple windows example app (flutter/flutter#181510)
2026-02-03 737941+loic-sharma@users.noreply.github.com [Web] Fix flt-platform-view comment (flutter/flutter#181576)
2026-02-03 fluttergithubbot@gmail.com Marks Linux_pixel_7pro android_verified_input_test to be unflaky (flutter/flutter#179120)
2026-02-03 34871572+gmackall@users.noreply.github.com Unmark `hybrid_android_views_integration_test` as bringup (flutter/flutter#181628)
2026-02-03 brackenavaron@gmail.com Remove material from sliver_tree_test.dart (flutter/flutter#181415)
2026-02-03 34871572+gmackall@users.noreply.github.com Make `android_plugin_new_output_dir_test` only build release (flutter/flutter#181677)
2026-02-03 737941+loic-sharma@users.noreply.github.com Roll customer tests (flutter/flutter#181825)
2026-02-03 41432658+jonathimer@users.noreply.github.com Add Linux Foundation Health Score badge to README (flutter/flutter#175587)
2026-02-03 116356835+AbdeMohlbi@users.noreply.github.com Remove unused getters on AndroidProject class (flutter/flutter#181860)
2026-02-03 47866232+chunhtai@users.noreply.github.com Adds batch release doc for flutter/package (flutter/flutter#181676)
2026-02-03 bkonyi@google.com [ Tool ] Don't use `globals.platform` in `getFlutterRoot()` (flutter/flutter#181859)
2026-02-03 engine-flutter-autoroll@skia.org Roll Packages from 837dbbd to 5b1bea8 (10 revisions) (flutter/flutter#181857)
2026-02-03 brackenavaron@gmail.com Remove material from basic_test.dart (flutter/flutter#181444)
2026-02-03 bkonyi@google.com [ Tool ] Fix regression introduced in flutter/flutter#181421 (flutter/flutter#181826)

If this roll has caused a breakage, revert this CL and stop the roller
...
LongCatIsLooong pushed a commit to LongCatIsLooong/flutter that referenced this pull request Feb 6, 2026
@bkonyi @LongCatIsLooong
[ Tool ] Fix regression introduced in flutter#181421 (flutter#181826)
ebc19da 
`dev/devicelab/bin/task/flutter_test_performance.dart` regressed due to
the CFE not being initialized with the correct dill file for the target
test. This change updates `TestCompiler` to pass the correct dill file
when creating the `ResidentCompiler` and adds a test to verify that the
`ResidentCompiler` is initialized with the correct dill.
flutter-zl pushed a commit to flutter-zl/flutter that referenced this pull request Feb 10, 2026
@bkonyi @flutter-zl
[ Tool ] Fix regression introduced in flutter#181421 (flutter#181826)
76a543f 
`dev/devicelab/bin/task/flutter_test_performance.dart` regressed due to
the CFE not being initialized with the correct dill file for the target
test. This change updates `TestCompiler` to pass the correct dill file
when creating the `ResidentCompiler` and adds a test to verify that the
`ResidentCompiler` is initialized with the correct dill.
rickhohler pushed a commit to rickhohler/flutter that referenced this pull request Feb 19, 2026
@bkonyi @rickhohler
[ Tool ] Fix regression introduced in flutter#181421 (flutter#181826)
4cd0b18 
`dev/devicelab/bin/task/flutter_test_performance.dart` regressed due to
the CFE not being initialized with the correct dill file for the target
test. This change updates `TestCompiler` to pass the correct dill file
when creating the `ResidentCompiler` and adds a test to verify that the
`ResidentCompiler` is initialized with the correct dill.
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@engine-flutter-autoroll
Roll Flutter from bf701fefec86 to f916dd6887bf (44 revisions) (flutte…
ddafaa3 
…r#10967)

Roll Flutter from bf701fefec86 to f916dd6887bf (44 revisions)

flutter/flutter@bf701fe...f916dd6

2026-02-05 nemeth@marcell.it Implement macOS wide gamut (Display P3) support (flutter/flutter#181769)
2026-02-04 engine-flutter-autoroll@skia.org Roll Skia from d23ecfbfdff9 to 8543ce512d5c (3 revisions) (flutter/flutter#181923)
2026-02-04 engine-flutter-autoroll@skia.org Roll Dart SDK from 8001c99d952b to 8f778ffd318b (3 revisions) (flutter/flutter#181927)
2026-02-04 jason-simmons@users.noreply.github.com Re-enable AddressSanitizer on the linux_unopt builder (flutter/flutter#181741)
2026-02-04 1063596+reidbaker@users.noreply.github.com Add exception to log message in ContentSizingFlag.java (flutter/flutter#181813)
2026-02-04 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#181925)
2026-02-04 nshahan@google.com [flutter_tools] Deprecate web hot reload flag (flutter/flutter#181884)
2026-02-04 magder@google.com Marks platform_views_scroll_perf_impeller__timeline_summary unflaky (flutter/flutter#181649)
2026-02-04 engine-flutter-autoroll@skia.org Roll Dart SDK from 204db085d970 to 8001c99d952b (1 revision) (flutter/flutter#181902)
2026-02-04 engine-flutter-autoroll@skia.org Roll Skia from f37a22506eb4 to d23ecfbfdff9 (23 revisions) (flutter/flutter#181915)
2026-02-04 jason-simmons@users.noreply.github.com In the Web codec tests, skip an undecodable image that is used to test a Skia error handling code path. (flutter/flutter#181870)
2026-02-04 engine-flutter-autoroll@skia.org Roll Packages from 5b1bea8 to 3bddf2c (5 revisions) (flutter/flutter#181918)
2026-02-04 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from UmQaaNuhkiuE8Dzug... to J2QdLcY2gyt4NP_xV... (flutter/flutter#181893)
2026-02-04 engine-flutter-autoroll@skia.org Roll Dart SDK from 54322a0b1109 to 204db085d970 (3 revisions) (flutter/flutter#181890)
2026-02-04 nurdaulet.97@gmail.com Cleanup cross imports (flutter/flutter#181807)
2026-02-04 kazbek.sultanov.doc@gmail.com [Material] Remove Material import from backdrop_filter_test.dart widget tests (flutter/flutter#181386)
2026-02-04 kazbek.sultanov.doc@gmail.com Move CheckedModeBanner tests to material and remove Material import from widgets banner_test (flutter/flutter#181261)
2026-02-04 git@reb0.org feat: Pass parameters from DropdownMenuFormField to DropDownMenu (flutter/flutter#181373)
2026-02-04 116356835+AbdeMohlbi@users.noreply.github.com Remove `Config complete` log when using `flutter build apk --config-only` (flutter/flutter#181864)
2026-02-04 flar@google.com [Impeller] Fix flattening of very large zoomed curves with tiny stroke widths (flutter/flutter#181505)
2026-02-03 prbillingsley89@gmail.com Propagates Overlay's MediaQueryData to OverlayPortal child (flutter/flutter#181579)
2026-02-03 ahmedsameha1@gmail.com Make sure that an AnimatedScale doesn't crash in 0x0 environment (flutter/flutter#181481)
2026-02-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 56294a92d5cc to 54322a0b1109 (1 revision) (flutter/flutter#181872)
2026-02-03 zemanux@users.noreply.github.com Fix decorated box (flutter/flutter#179802)
2026-02-03 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#181871)
2026-02-03 70534390+Erengun@users.noreply.github.com Remove Material library dependency from expansible_test.dart (flutter/flutter#181657)
2026-02-03 evanwall@buffalo.edu Organize and update fragment shader uniform tests. (flutter/flutter#181822)
2026-02-03 1961493+harryterkelsen@users.noreply.github.com fix(web_ui): handle non-invertible matrices in ImageFilter.matrix (flutter/flutter#181742)
2026-02-03 nhan13574@gmail.com Remove unnecessary Material import from cupertino/slider_test.dart (flutter/flutter#180957)
2026-02-03 15619084+vashworth@users.noreply.github.com Remove the Flutter.xcframework as a swift dependency (flutter/flutter#181739)
2026-02-03 matt.kosarek@canonical.com feature: implementation of tooltips in the `_TestWindowingOwner` and minor bugfixes to the multiple windows example app (flutter/flutter#181510)
2026-02-03 737941+loic-sharma@users.noreply.github.com [Web] Fix flt-platform-view comment (flutter/flutter#181576)
2026-02-03 fluttergithubbot@gmail.com Marks Linux_pixel_7pro android_verified_input_test to be unflaky (flutter/flutter#179120)
2026-02-03 34871572+gmackall@users.noreply.github.com Unmark `hybrid_android_views_integration_test` as bringup (flutter/flutter#181628)
2026-02-03 brackenavaron@gmail.com Remove material from sliver_tree_test.dart (flutter/flutter#181415)
2026-02-03 34871572+gmackall@users.noreply.github.com Make `android_plugin_new_output_dir_test` only build release (flutter/flutter#181677)
2026-02-03 737941+loic-sharma@users.noreply.github.com Roll customer tests (flutter/flutter#181825)
2026-02-03 41432658+jonathimer@users.noreply.github.com Add Linux Foundation Health Score badge to README (flutter/flutter#175587)
2026-02-03 116356835+AbdeMohlbi@users.noreply.github.com Remove unused getters on AndroidProject class (flutter/flutter#181860)
2026-02-03 47866232+chunhtai@users.noreply.github.com Adds batch release doc for flutter/package (flutter/flutter#181676)
2026-02-03 bkonyi@google.com [ Tool ] Don't use `globals.platform` in `getFlutterRoot()` (flutter/flutter#181859)
2026-02-03 engine-flutter-autoroll@skia.org Roll Packages from 837dbbd to 5b1bea8 (10 revisions) (flutter/flutter#181857)
2026-02-03 brackenavaron@gmail.com Remove material from basic_test.dart (flutter/flutter#181444)
2026-02-03 bkonyi@google.com [ Tool ] Fix regression introduced in flutter/flutter#181421 (flutter/flutter#181826)

If this roll has caused a breakage, revert this CL and stop the roller
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaaclarke gaaclarke gaaclarke approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

team-tool Owned by Flutter Tool team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bkonyi @gaaclarke