[Impeller] Fix type conversion warnings seen on Windows when Impeller GL API wrappers log arguments with function types#181734
Merged
Conversation
… GL API wrappers log arguments with function types flutter#181157 introduced a call to the glDebugMessageCallback API using a lambda as the argument. On Windows builds this produces a warning about a nonstandard implicit conversion when the Impeller GL API wrappers try to log the callback argument.
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a type conversion warning on Windows related to logging function pointer arguments in Impeller's GL API wrappers. The changes consist of two parts: In playground_impl_gles.cc, the unary + operator is applied to a stateless lambda passed to glDebugMessageCallbackKHR to explicitly convert it to a function pointer. In proc_table_gles.h, BuildGLArgumentsStream is modified to use a new ArgLogger helper. This helper has a template specialization for function pointers that casts them to void* before logging, which avoids the conversion warning.
jtmcdole
approved these changes
Jan 30, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 31, 2026
…n Impeller GL API wrappers log arguments with function types (flutter/flutter#181734)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 31, 2026
…n Impeller GL API wrappers log arguments with function types (flutter/flutter#181734)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 1, 2026
…n Impeller GL API wrappers log arguments with function types (flutter/flutter#181734)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 1, 2026
…n Impeller GL API wrappers log arguments with function types (flutter/flutter#181734)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 1, 2026
…n Impeller GL API wrappers log arguments with function types (flutter/flutter#181734)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 2, 2026
…n Impeller GL API wrappers log arguments with function types (flutter/flutter#181734)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 2, 2026
…n Impeller GL API wrappers log arguments with function types (flutter/flutter#181734)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 2, 2026
…n Impeller GL API wrappers log arguments with function types (flutter/flutter#181734)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 2, 2026
…n Impeller GL API wrappers log arguments with function types (flutter/flutter#181734)
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Feb 2, 2026
flutter/flutter@1d9d6a9...9eafba4 2026-02-01 engine-flutter-autoroll@skia.org Roll Skia from a8ceddc2bca0 to 4ee9eb659ae0 (1 revision) (flutter/flutter#181773) 2026-02-01 engine-flutter-autoroll@skia.org Roll Skia from a5a535bc21a3 to a8ceddc2bca0 (1 revision) (flutter/flutter#181772) 2026-02-01 engine-flutter-autoroll@skia.org Roll Dart SDK from cde322c518b9 to 84abc8d58ec8 (1 revision) (flutter/flutter#181767) 2026-02-01 engine-flutter-autoroll@skia.org Roll Dart SDK from c72b3f527a07 to cde322c518b9 (1 revision) (flutter/flutter#181763) 2026-01-31 engine-flutter-autoroll@skia.org Roll Dart SDK from 43de79f08887 to c72b3f527a07 (1 revision) (flutter/flutter#181762) 2026-01-31 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 27OsrsrKcrr2pOaqY... to nI52U4LJMrBv8G1M9... (flutter/flutter#181760) 2026-01-31 engine-flutter-autoroll@skia.org Roll Dart SDK from a0aac59705e5 to 43de79f08887 (1 revision) (flutter/flutter#181758) 2026-01-31 engine-flutter-autoroll@skia.org Roll Skia from b704afbcd8e7 to a5a535bc21a3 (1 revision) (flutter/flutter#181757) 2026-01-31 engine-flutter-autoroll@skia.org Roll Dart SDK from d6f77f9098e1 to a0aac59705e5 (1 revision) (flutter/flutter#181756) 2026-01-31 engine-flutter-autoroll@skia.org Roll Skia from 6f9511ce11ba to b704afbcd8e7 (4 revisions) (flutter/flutter#181753) 2026-01-31 engine-flutter-autoroll@skia.org Roll Dart SDK from 0cf997832948 to d6f77f9098e1 (2 revisions) (flutter/flutter#181749) 2026-01-31 engine-flutter-autoroll@skia.org Roll Skia from 33c00c0f3b8b to 6f9511ce11ba (1 revision) (flutter/flutter#181744) 2026-01-31 engine-flutter-autoroll@skia.org Roll Dart SDK from be3ffc51d407 to 0cf997832948 (1 revision) (flutter/flutter#181740) 2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from b62d43b59dd6 to 33c00c0f3b8b (1 revision) (flutter/flutter#181735) 2026-01-30 jason-simmons@users.noreply.github.com [Impeller] Fix type conversion warnings seen on Windows when Impeller GL API wrappers log arguments with function types (flutter/flutter#181734) 2026-01-30 jesswon@google.com Update New Android API Docs (flutter/flutter#180604) 2026-01-30 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from isy1ARvK-3bsvtfc-... to 27OsrsrKcrr2pOaqY... (flutter/flutter#181733) 2026-01-30 nemeth@marcell.it Fix P3-to-sRGB color conversion to operate in linear light (flutter/flutter#181720) 2026-01-30 codefu@google.com chore: deflake Linux_mokey flutter_engine_group_performance (flutter/flutter#181624) 2026-01-30 engine-flutter-autoroll@skia.org Roll Dart SDK from 2703fd9733ce to be3ffc51d407 (1 revision) (flutter/flutter#181729) 2026-01-30 matt.boetger@gmail.com Ensure content-sizing resize is run on UI thread (flutter/flutter#181686) 2026-01-30 bkonyi@google.com [ Tool ] Cleanup `ResidentCompiler` initialization logic (flutter/flutter#181421) 2026-01-30 dacoharkes@google.com [native assets] Split debug info into `.dsym` files (flutter/flutter#181533) 2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from 4745eb2fe837 to b62d43b59dd6 (1 revision) (flutter/flutter#181727) 2026-01-30 planetmarshall@users.noreply.github.com add ccache support for custom toolchain (flutter/flutter#180737) 2026-01-30 planetmarshall@users.noreply.github.com update GLFW to latest and use EGL context creation on linux (flutter/flutter#181259) 2026-01-30 planetmarshall@users.noreply.github.com add stacktrace support when requested for host builds (flutter/flutter#181264) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LongCatIsLooong
pushed a commit
to LongCatIsLooong/flutter
that referenced
this pull request
Feb 6, 2026
… GL API wrappers log arguments with function types (flutter#181734) flutter#181157 introduced a call to the glDebugMessageCallback API using a lambda as the argument. On Windows builds this produces a warning about a nonstandard implicit conversion when the Impeller GL API wrappers try to log the callback argument.
flutter-zl
pushed a commit
to flutter-zl/flutter
that referenced
this pull request
Feb 10, 2026
… GL API wrappers log arguments with function types (flutter#181734) flutter#181157 introduced a call to the glDebugMessageCallback API using a lambda as the argument. On Windows builds this produces a warning about a nonstandard implicit conversion when the Impeller GL API wrappers try to log the callback argument.
rickhohler
pushed a commit
to rickhohler/flutter
that referenced
this pull request
Feb 19, 2026
… GL API wrappers log arguments with function types (flutter#181734) flutter#181157 introduced a call to the glDebugMessageCallback API using a lambda as the argument. On Windows builds this produces a warning about a nonstandard implicit conversion when the Impeller GL API wrappers try to log the callback argument.
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…r#10938) flutter/flutter@1d9d6a9...9eafba4 2026-02-01 engine-flutter-autoroll@skia.org Roll Skia from a8ceddc2bca0 to 4ee9eb659ae0 (1 revision) (flutter/flutter#181773) 2026-02-01 engine-flutter-autoroll@skia.org Roll Skia from a5a535bc21a3 to a8ceddc2bca0 (1 revision) (flutter/flutter#181772) 2026-02-01 engine-flutter-autoroll@skia.org Roll Dart SDK from cde322c518b9 to 84abc8d58ec8 (1 revision) (flutter/flutter#181767) 2026-02-01 engine-flutter-autoroll@skia.org Roll Dart SDK from c72b3f527a07 to cde322c518b9 (1 revision) (flutter/flutter#181763) 2026-01-31 engine-flutter-autoroll@skia.org Roll Dart SDK from 43de79f08887 to c72b3f527a07 (1 revision) (flutter/flutter#181762) 2026-01-31 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 27OsrsrKcrr2pOaqY... to nI52U4LJMrBv8G1M9... (flutter/flutter#181760) 2026-01-31 engine-flutter-autoroll@skia.org Roll Dart SDK from a0aac59705e5 to 43de79f08887 (1 revision) (flutter/flutter#181758) 2026-01-31 engine-flutter-autoroll@skia.org Roll Skia from b704afbcd8e7 to a5a535bc21a3 (1 revision) (flutter/flutter#181757) 2026-01-31 engine-flutter-autoroll@skia.org Roll Dart SDK from d6f77f9098e1 to a0aac59705e5 (1 revision) (flutter/flutter#181756) 2026-01-31 engine-flutter-autoroll@skia.org Roll Skia from 6f9511ce11ba to b704afbcd8e7 (4 revisions) (flutter/flutter#181753) 2026-01-31 engine-flutter-autoroll@skia.org Roll Dart SDK from 0cf997832948 to d6f77f9098e1 (2 revisions) (flutter/flutter#181749) 2026-01-31 engine-flutter-autoroll@skia.org Roll Skia from 33c00c0f3b8b to 6f9511ce11ba (1 revision) (flutter/flutter#181744) 2026-01-31 engine-flutter-autoroll@skia.org Roll Dart SDK from be3ffc51d407 to 0cf997832948 (1 revision) (flutter/flutter#181740) 2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from b62d43b59dd6 to 33c00c0f3b8b (1 revision) (flutter/flutter#181735) 2026-01-30 jason-simmons@users.noreply.github.com [Impeller] Fix type conversion warnings seen on Windows when Impeller GL API wrappers log arguments with function types (flutter/flutter#181734) 2026-01-30 jesswon@google.com Update New Android API Docs (flutter/flutter#180604) 2026-01-30 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from isy1ARvK-3bsvtfc-... to 27OsrsrKcrr2pOaqY... (flutter/flutter#181733) 2026-01-30 nemeth@marcell.it Fix P3-to-sRGB color conversion to operate in linear light (flutter/flutter#181720) 2026-01-30 codefu@google.com chore: deflake Linux_mokey flutter_engine_group_performance (flutter/flutter#181624) 2026-01-30 engine-flutter-autoroll@skia.org Roll Dart SDK from 2703fd9733ce to be3ffc51d407 (1 revision) (flutter/flutter#181729) 2026-01-30 matt.boetger@gmail.com Ensure content-sizing resize is run on UI thread (flutter/flutter#181686) 2026-01-30 bkonyi@google.com [ Tool ] Cleanup `ResidentCompiler` initialization logic (flutter/flutter#181421) 2026-01-30 dacoharkes@google.com [native assets] Split debug info into `.dsym` files (flutter/flutter#181533) 2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from 4745eb2fe837 to b62d43b59dd6 (1 revision) (flutter/flutter#181727) 2026-01-30 planetmarshall@users.noreply.github.com add ccache support for custom toolchain (flutter/flutter#180737) 2026-01-30 planetmarshall@users.noreply.github.com update GLFW to latest and use EGL context creation on linux (flutter/flutter#181259) 2026-01-30 planetmarshall@users.noreply.github.com add stacktrace support when requested for host builds (flutter/flutter#181264) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#181157 introduced a call to the glDebugMessageCallback API using a lambda as the argument. On Windows builds this produces a warning about a nonstandard implicit conversion when the Impeller GL API wrappers try to log the callback argument.