Generate Flutter framework swift package by vashworth · Pull Request #181578 · flutter/flutter

vashworth · 2026-01-28T03:06:16Z

This PR creates a FlutterFramework swift package with no real content. This is a placeholder so that plugins may add a dependency on the FlutterFramework in their Package.swift before #178931 lands in stable. See go/swiftpm-flutter-release.

Impacted Users: Flutter iOS with SwiftPM feature flag enabled

Impact Description: Allows plugins to add a dependency on the FlutterFramework in their Package.swift.

Workaround: See Problem 2 alternatives in go/swiftpm-flutter-release

Risk: This PR by itself is low risk. It just generates a couple files in an ephemeral directory. It only is actually used if a plugin adds a dependency on it in it's Package.swift. If a plugin does this, it's still low risk since it's basically just an empty Swift package. It's also behind a feature flag (flutter config --enable-swift-package-manager), which can be disabled.

Test Coverage: Yes

Validation Steps:

flutter config --enable-swift-package-manager
flutter create my_plugin && cd my_plugin/example
Add FlutterFramework to Package.swift (see example)
flutter build ios

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

flutter-dashboard · 2026-01-28T03:06:20Z

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

gemini-code-assist

Code Review

This pull request introduces the generation of a placeholder Swift package named FlutterFramework to facilitate plugin dependencies before a broader change lands in stable. It includes a new constant for the framework's name, updates to the SwiftPackageManager to create this package, and corresponding changes in XcodeBasedProject and various test files to support and verify this new functionality. The changes are well-tested and align with the stated goal of providing a temporary solution for Swift Package Manager integration.

gemini-code-assist · 2026-01-28T17:26:29Z

 /// dependencies on Flutter plugin swift packages.
 const kFlutterGeneratedPluginSwiftPackageName = 'FlutterGeneratedPluginSwiftPackage';

+/// The name of the Swift pacakge that's generated by the Flutter tool to add


There's a small typo in the comment: "pacakge" should be "package".

Suggested change

/// The name of the Swift pacakge that's generated by the Flutter tool to add

/// The name of the Swift package that's generated by the Flutter tool to add

gemini-code-assist · 2026-01-28T17:26:29Z


+  @override
+  Directory get flutterFrameworkSwiftPackageDirectory =>
+      relativeSwiftPackagesDirectory.childDirectory('FlutterFramework');


For consistency and to avoid magic strings, it's best to use the kFlutterGeneratedFrameworkSwiftPackageTargetName constant here, as it was introduced specifically for this purpose. This adheres to the style guide's principle of "Avoid duplicating state" (Repository Style Guide, line 30).

Suggested change

relativeSwiftPackagesDirectory.childDirectory('FlutterFramework');

relativeSwiftPackagesDirectory.childDirectory(kFlutterGeneratedFrameworkSwiftPackageTargetName);

gemini-code-assist · 2026-01-28T17:26:29Z


+  @override
+  Directory get flutterFrameworkSwiftPackageDirectory =>
+      relativeSwiftPackagesDirectory.childDirectory('FlutterFramework');


Similar to the FakeMacOSProject, please use the kFlutterGeneratedFrameworkSwiftPackageTargetName constant instead of the hardcoded string "FlutterFramework" for better maintainability and to avoid duplicating state (Repository Style Guide, line 30).

Suggested change

relativeSwiftPackagesDirectory.childDirectory('FlutterFramework');

relativeSwiftPackagesDirectory.childDirectory(kFlutterGeneratedFrameworkSwiftPackageTargetName);

gemini-code-assist · 2026-01-28T17:26:30Z

+import PackageDescription
+
+let package = Package(
+    name: "FlutterFramework",


To maintain consistency and avoid magic strings, please use the kFlutterGeneratedFrameworkSwiftPackageTargetName constant here. This aligns with the style guide's principle of "Avoid duplicating state" (Repository Style Guide, line 30).

Suggested change

name: "FlutterFramework",

name: kFlutterGeneratedFrameworkSwiftPackageTargetName,

gemini-code-assist · 2026-01-28T17:26:30Z

+        $supportedPlatform
+    ],
+    products: [
+        .library(name: "FlutterFramework", targets: ["FlutterFramework"])


Please use the kFlutterGeneratedFrameworkSwiftPackageTargetName constant for the product name and target name to ensure consistency and reduce hardcoded values. This adheres to the style guide's principle of "Avoid duplicating state" (Repository Style Guide, line 30).

Suggested change

.library(name: "FlutterFramework", targets: ["FlutterFramework"])

.library(name: kFlutterGeneratedFrameworkSwiftPackageTargetName, targets: <String>[kFlutterGeneratedFrameworkSwiftPackageTargetName])

gemini-code-assist · 2026-01-28T17:26:30Z

+    ],
+    targets: [
+        .target(
+            name: "FlutterFramework"


The target name should also use the kFlutterGeneratedFrameworkSwiftPackageTargetName constant for consistency and to avoid hardcoded strings. This aligns with the style guide's principle of "Avoid duplicating state" (Repository Style Guide, line 30).

Suggested change

name: "FlutterFramework"

name: kFlutterGeneratedFrameworkSwiftPackageTargetName

gemini-code-assist · 2026-01-28T17:26:30Z

+                .childDirectory('FlutterFramework')
+                .childFile('FlutterFramework.swift');


Using the kFlutterGeneratedFrameworkSwiftPackageTargetName constant here would improve maintainability and consistency, as it avoids hardcoding the directory and file names. This adheres to the style guide's principle of "Avoid duplicating state" (Repository Style Guide, line 30).

Suggested change

.childDirectory('FlutterFramework')

.childFile('FlutterFramework.swift');

.childDirectory(kFlutterGeneratedFrameworkSwiftPackageTargetName)

.childFile('${kFlutterGeneratedFrameworkSwiftPackageTargetName}.swift');

gemini-code-assist · 2026-01-28T17:26:30Z


+  @override
+  Directory get flutterFrameworkSwiftPackageDirectory =>
+      relativeSwiftPackagesDirectory.childDirectory('FlutterFramework');


Please use the kFlutterGeneratedFrameworkSwiftPackageTargetName constant instead of the hardcoded string "FlutterFramework" for consistency and better maintainability. This aligns with the style guide's principle of "Avoid duplicating state" (Repository Style Guide, line 30).

Suggested change

relativeSwiftPackagesDirectory.childDirectory('FlutterFramework');

relativeSwiftPackagesDirectory.childDirectory(kFlutterGeneratedFrameworkSwiftPackageTargetName);

gemini-code-assist · 2026-01-28T17:26:30Z

+              '.package(name: "FlutterFramework", path: "../FlutterFramework")';
+          const targetDependency =


It's recommended to use the kFlutterGeneratedFrameworkSwiftPackageTargetName constant for the package and target names to ensure consistency and avoid hardcoded strings. This adheres to the style guide's principle of "Avoid duplicating state" (Repository Style Guide, line 30).

Suggested change

'.package(name: "FlutterFramework", path: "../FlutterFramework")';

const targetDependency =

'.package(name: "${kFlutterGeneratedFrameworkSwiftPackageTargetName}", path: "../${kFlutterGeneratedFrameworkSwiftPackageTargetName}")';

const targetDependency =

'.product(name: "${kFlutterGeneratedFrameworkSwiftPackageTargetName}", package: "${kFlutterGeneratedFrameworkSwiftPackageTargetName}")';

vashworth · 2026-01-28T17:28:12Z

All the gemini comments are about using hardcoded values in tests and a typo in a comment. I'm going to let that slide as not to have to re-run the tests

stuartmorgan-g

LGTM

stuartmorgan-g · 2026-01-28T17:37:02Z

All the gemini comments are about using hardcoded values in tests and a typo in a comment. I'm going to let that slide as not to have to re-run the tests

FWIW I strongly disagree with Gemini about not using hard-coded values for at least the part where the test is checking for expected Package.swift contents; if someone changes the constant, the tests should absolutely break, because what we want to test is not "the output matches the constant" it's "the output matches the value we are telling the entire ecosystem to depend on".

…81578)

This PR creates a FlutterFramework swift package with no real content. This is a placeholder so that plugins may add a dependency on the FlutterFramework in their Package.swift before flutter#178931 lands in stable. See go/swiftpm-flutter-release. Impacted Users: Flutter iOS with SwiftPM feature flag enabled Impact Description: Allows plugins to add a dependency on the FlutterFramework in their Package.swift. Workaround: See Problem 2 alternatives in [go/swiftpm-flutter-release](http://goto.google.com/swiftpm-flutter-release) Risk: This PR by itself is low risk. It just generates a couple files in an ephemeral directory. It only is actually used if a plugin adds a dependency on it in it's Package.swift. If a plugin does this, it's still low risk since it's basically just an empty Swift package. It's also behind a feature flag (`flutter config --enable-swift-package-manager`), which can be disabled. Test Coverage: Yes Validation Steps: - `flutter config --enable-swift-package-manager` - `flutter create my_plugin && cd my_plugin/example` - Add `FlutterFramework` to Package.swift (see [example](https://github.com/flutter/flutter/blob/master/packages/integration_test/ios/integration_test/Package.swift#L15-L21)) - `flutter build ios` **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Generate Flutter framework swift package

e35d2c8

github-actions Bot added tool Affects the "flutter" command-line tool. See also t: labels. a: desktop Running on desktop team-ios Owned by iOS platform team labels Jan 28, 2026

fix test

699eb11

vashworth requested a review from stuartmorgan-g January 28, 2026 17:12

vashworth marked this pull request as ready for review January 28, 2026 17:13

vashworth requested a review from a team as a code owner January 28, 2026 17:13

reidbaker self-assigned this Jan 28, 2026

reidbaker approved these changes Jan 28, 2026

View reviewed changes

eyebrowsoffire added cp: beta cherry pick this pull request to beta release candidate branch cp: review Cherry-picks in the review queue and removed cp: beta cherry pick this pull request to beta release candidate branch labels Jan 28, 2026

gemini-code-assist Bot reviewed Jan 28, 2026

View reviewed changes

stuartmorgan-g approved these changes Jan 28, 2026

View reviewed changes

eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 28, 2026

auto-submit Bot merged commit 37f698a into flutter:flutter-3.41-candidate.0 Jan 28, 2026
141 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2026

37f698a5b Generate Flutter framework swift package (flutter/flutter#1…

e5431aa

…81578)

reidbaker mentioned this pull request Mar 23, 2026

Update skia on Stable #184025

Merged

	/// The name of the Swift pacakge that's generated by the Flutter tool to add
	/// The name of the Swift package that's generated by the Flutter tool to add

	relativeSwiftPackagesDirectory.childDirectory('FlutterFramework');
	relativeSwiftPackagesDirectory.childDirectory(kFlutterGeneratedFrameworkSwiftPackageTargetName);

	name: "FlutterFramework",
	name: kFlutterGeneratedFrameworkSwiftPackageTargetName,

	.library(name: "FlutterFramework", targets: ["FlutterFramework"])
	.library(name: kFlutterGeneratedFrameworkSwiftPackageTargetName, targets: <String>[kFlutterGeneratedFrameworkSwiftPackageTargetName])

	name: "FlutterFramework"
	name: kFlutterGeneratedFrameworkSwiftPackageTargetName

		.childDirectory('FlutterFramework')
		.childFile('FlutterFramework.swift');

		'.package(name: "FlutterFramework", path: "../FlutterFramework")';
		const targetDependency =

Uh oh!

Conversation

vashworth commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard Bot commented Jan 28, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

vashworth commented Jan 28, 2026

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Jan 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vashworth commented Jan 28, 2026 •

edited

Loading