Skip to content

Reverts "Fixes metal vec3 uniform padding (#181340)"#181552

Merged
auto-submit[bot] merged 1 commit into
masterfrom
revert_aea4435c0051c842597a774f12ed1cb3df32ed1b
Jan 27, 2026
Merged

Reverts "Fixes metal vec3 uniform padding (#181340)"#181552
auto-submit[bot] merged 1 commit into
masterfrom
revert_aea4435c0051c842597a774f12ed1cb3df32ed1b

Conversation

@auto-submit

@auto-submit auto-submit Bot commented Jan 27, 2026

Copy link
Copy Markdown
Contributor

Reverts: #181340

Initiated by: gaaclarke

Reason for reverting: golden failures and known logical errors that didn't have test coverage

Original PR Author: gaaclarke

Reviewed By: {walley892, b-luk}

This change reverts the following previous change:
fixes #180873

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@auto-submit auto-submit Bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Jan 27, 2026
@github-actions github-actions Bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Jan 27, 2026
@auto-submit auto-submit Bot added this pull request to the merge queue Jan 27, 2026
Merged via the queue into master with commit dfd92b7 Jan 27, 2026
10 of 12 checks passed
@auto-submit auto-submit Bot deleted the revert_aea4435c0051c842597a774f12ed1cb3df32ed1b branch January 27, 2026 18:05
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 27, 2026
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Jan 27, 2026
flutter/flutter@7165649...dfd92b7

2026-01-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fixes metal vec3 uniform padding (#181340)" (flutter/flutter#181552)
2026-01-27 1063596+reidbaker@users.noreply.github.com Change update_engine_version documenation (flutter/flutter#181508)
2026-01-27 engine-flutter-autoroll@skia.org Roll Packages from e712bfa to e37af11 (7 revisions) (flutter/flutter#181544)
2026-01-27 jason-simmons@users.noreply.github.com Roll FreeType to 2.14.1 (flutter/flutter#181428)
2026-01-27 engine-flutter-autoroll@skia.org Roll Skia from 566d202962d3 to c2754838b077 (3 revisions) (flutter/flutter#181536)
2026-01-27 120639059+Enderjua@users.noreply.github.com [Material] modernize time picker components with Dart 3 switch expressions (flutter/flutter#181356)
2026-01-27 engine-flutter-autoroll@skia.org Roll Skia from 55a87b50a368 to 566d202962d3 (1 revision) (flutter/flutter#181528)
2026-01-27 engine-flutter-autoroll@skia.org Roll Dart SDK from f55d4538469a to 4c7cb0a1d07d (2 revisions) (flutter/flutter#181526)
2026-01-27 sigurdm@google.com Replace `pub run` mentions with `dart run` (flutter/flutter#181317)
2026-01-27 engine-flutter-autoroll@skia.org Roll Skia from 1a15ed6b17f2 to 55a87b50a368 (1 revision) (flutter/flutter#181523)
2026-01-27 magder@google.com Marks linux_chrome_dev_mode to be unflaky (flutter/flutter#181352)
2026-01-27 engine-flutter-autoroll@skia.org Roll Skia from f2c1aa140b79 to 1a15ed6b17f2 (2 revisions) (flutter/flutter#181514)
2026-01-27 snakept@icloud.com Fix Range Slider issue where indescrete ranges lead to out of range r… (flutter/flutter#181082)
2026-01-26 engine-flutter-autoroll@skia.org Roll Dart SDK from ba23b5ed0a97 to f55d4538469a (2 revisions) (flutter/flutter#181512)
2026-01-26 mariaivoneiradjaja@gmail.com Add `alignment` to `SizeTransition` (flutter/flutter#177895)
2026-01-26 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from T4qTEa3T5CCSCIoJY... to akraNGn2lw4T1msgZ... (flutter/flutter#181509)
2026-01-26 engine-flutter-autoroll@skia.org Roll Skia from be280d242a60 to f2c1aa140b79 (3 revisions) (flutter/flutter#181504)
2026-01-26 30870216+gaaclarke@users.noreply.github.com Fixes metal vec3 uniform padding (flutter/flutter#181340)
2026-01-26 47866232+chunhtai@users.noreply.github.com Fixes duplicated import in accessibility test library (flutter/flutter#181506)
2026-01-26 34871572+gmackall@users.noreply.github.com [Reland] Don't strip symbols from `libapp.so` on android by default (flutter/flutter#181275)
2026-01-26 sokolovskyi.konstantin@gmail.com Fix Gradle path in Android Platform Embedder README. (flutter/flutter#181501)
2026-01-26 116356835+AbdeMohlbi@users.noreply.github.com Remove unused `ActivityLifecycleListener` class (flutter/flutter#181406)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter-zl pushed a commit to flutter-zl/flutter that referenced this pull request Feb 10, 2026
…181552)

<!-- start_original_pr_link -->
Reverts: flutter#181340
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: gaaclarke
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: golden failures and known logical errors that
didn't have test coverage
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: gaaclarke
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {walley892, b-luk}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
fixes flutter#180873

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…r#10914)

flutter/flutter@7165649...dfd92b7

2026-01-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fixes metal vec3 uniform padding (#181340)" (flutter/flutter#181552)
2026-01-27 1063596+reidbaker@users.noreply.github.com Change update_engine_version documenation (flutter/flutter#181508)
2026-01-27 engine-flutter-autoroll@skia.org Roll Packages from e712bfa to e37af11 (7 revisions) (flutter/flutter#181544)
2026-01-27 jason-simmons@users.noreply.github.com Roll FreeType to 2.14.1 (flutter/flutter#181428)
2026-01-27 engine-flutter-autoroll@skia.org Roll Skia from 566d202962d3 to c2754838b077 (3 revisions) (flutter/flutter#181536)
2026-01-27 120639059+Enderjua@users.noreply.github.com [Material] modernize time picker components with Dart 3 switch expressions (flutter/flutter#181356)
2026-01-27 engine-flutter-autoroll@skia.org Roll Skia from 55a87b50a368 to 566d202962d3 (1 revision) (flutter/flutter#181528)
2026-01-27 engine-flutter-autoroll@skia.org Roll Dart SDK from f55d4538469a to 4c7cb0a1d07d (2 revisions) (flutter/flutter#181526)
2026-01-27 sigurdm@google.com Replace `pub run` mentions with `dart run` (flutter/flutter#181317)
2026-01-27 engine-flutter-autoroll@skia.org Roll Skia from 1a15ed6b17f2 to 55a87b50a368 (1 revision) (flutter/flutter#181523)
2026-01-27 magder@google.com Marks linux_chrome_dev_mode to be unflaky (flutter/flutter#181352)
2026-01-27 engine-flutter-autoroll@skia.org Roll Skia from f2c1aa140b79 to 1a15ed6b17f2 (2 revisions) (flutter/flutter#181514)
2026-01-27 snakept@icloud.com Fix Range Slider issue where indescrete ranges lead to out of range r… (flutter/flutter#181082)
2026-01-26 engine-flutter-autoroll@skia.org Roll Dart SDK from ba23b5ed0a97 to f55d4538469a (2 revisions) (flutter/flutter#181512)
2026-01-26 mariaivoneiradjaja@gmail.com Add `alignment` to `SizeTransition` (flutter/flutter#177895)
2026-01-26 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from T4qTEa3T5CCSCIoJY... to akraNGn2lw4T1msgZ... (flutter/flutter#181509)
2026-01-26 engine-flutter-autoroll@skia.org Roll Skia from be280d242a60 to f2c1aa140b79 (3 revisions) (flutter/flutter#181504)
2026-01-26 30870216+gaaclarke@users.noreply.github.com Fixes metal vec3 uniform padding (flutter/flutter#181340)
2026-01-26 47866232+chunhtai@users.noreply.github.com Fixes duplicated import in accessibility test library (flutter/flutter#181506)
2026-01-26 34871572+gmackall@users.noreply.github.com [Reland] Don't strip symbols from `libapp.so` on android by default (flutter/flutter#181275)
2026-01-26 sokolovskyi.konstantin@gmail.com Fix Gradle path in Android Platform Embedder README. (flutter/flutter#181501)
2026-01-26 116356835+AbdeMohlbi@users.noreply.github.com Remove unused `ActivityLifecycleListener` class (flutter/flutter#181406)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels. revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

enable 'FragmentShader shader with array uniforms renders correctly' for impeller

2 participants