Reduce reliance on Material in page_transitions_test.dart by navaronbracke · Pull Request #181467 · flutter/flutter

navaronbracke · 2026-01-25T15:41:25Z

This PR reduces the reliance on Material in page_transitions_test.dart but does not entirely remove it.

Moves a test for persistent bottom sheet to the right file
Fixes a use of sync* (not sure why this is not caught by dev/bots/analyze.dart, that does check for sync* cc @Piinks )
Replaces some easy usages of Material widgets with its widget counterparts.

The only thing that I did not yet fix is replacing MaterialApp in this file. That probably needs @victorsanni 's work on page transitions to be addressed first?

Part of #177415

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

gemini-code-assist

Code Review

This pull request effectively reduces the reliance on the Material library in page_transitions_test.dart by replacing Material-specific widgets like Scaffold and MaterialPageRoute with their more generic counterparts from the widgets library. It also correctly moves a test for persistent bottom sheets into persistent_bottom_sheet_test.dart and simplifies a generator function. The changes are well-aligned with the goal of modularizing the framework. I've added a couple of suggestions to improve type safety for GlobalKeys in the newly added test, which will make the code cleaner and more robust.

justinmc

LGTM 👍

auto-submit · 2026-02-02T23:20:07Z

autosubmit label was removed for flutter/flutter/181467, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.

navaronbracke · 2026-02-03T07:07:21Z

Rebased to make the autosubmit bot happy. Once green again, can someone re-add the label?

AbdeMohlbi · 2026-02-03T07:15:13Z

Rebased to make the autosubmit bot happy. Once green again, can someone re-add the label?

I'll check on it again

navaronbracke · 2026-02-03T08:16:35Z

@AbdeMohlbi Looks to be green now.

AbdeMohlbi · 2026-02-03T08:35:18Z

@AbdeMohlbi Looks to be green now.

Done

…lutter/flutter#181467)

flutter/flutter@c305f1f...bf701fe 2026-02-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 01ba84eeb32f to 56294a92d5cc (2 revisions) (flutter/flutter#181851) 2026-02-03 brackenavaron@gmail.com Remove material from scrollable_helpers_test.dart (flutter/flutter#181460) 2026-02-03 brackenavaron@gmail.com Reduce reliance on Material in page_transitions_test.dart (flutter/flutter#181467) 2026-02-03 116356835+AbdeMohlbi@users.noreply.github.com Fix todo about `replacing URL with constants` in `gradle_errors.dart` (flutter/flutter#181673) 2026-02-03 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 1L4m9qCikk-JzrNWE... to UmQaaNuhkiuE8Dzug... (flutter/flutter#181841) 2026-02-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 1aa8f2de7587 to 01ba84eeb32f (2 revisions) (flutter/flutter#181836) 2026-02-03 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#181738) 2026-02-03 brackenavaron@gmail.com Remove material from slivers_appbar_floating_pinned_test.dart + slivers_appbar_stretch_test.dart + sliver_persistent_header_test.dart + slivers_appbar_floating_test.dart (flutter/flutter#181469) 2026-02-02 engine-flutter-autoroll@skia.org Roll Skia from 43fa79e1c51f to f37a22506eb4 (1 revision) (flutter/flutter#181814) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

victorsanni · 2026-02-03T19:01:14Z

replacing MaterialApp in this file.

The MaterialApp tests verify that the page transitions builders can be supplied to MaterialApp.theme.pageTransitionsTheme. So they can be moved to Material.

navaronbracke · 2026-02-03T19:44:07Z

I'll do that next then, thanks!

@Piinks

…1467) This PR reduces the reliance on Material in page_transitions_test.dart but does not entirely remove it. 1) Moves a test for persistent bottom sheet to the right file 2) Fixes a use of `sync*` (not sure why this is not caught by dev/bots/analyze.dart, that _does_ check for `sync*` cc @Piinks ) 3) Replaces some easy usages of Material widgets with its widget counterparts. The only thing that I did not yet fix is replacing `MaterialApp` in this file. That probably needs @victorsanni 's work on page transitions to be addressed first? Part of flutter#177415 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

@Piinks

…1467) This PR reduces the reliance on Material in page_transitions_test.dart but does not entirely remove it. 1) Moves a test for persistent bottom sheet to the right file 2) Fixes a use of `sync*` (not sure why this is not caught by dev/bots/analyze.dart, that _does_ check for `sync*` cc @Piinks ) 3) Replaces some easy usages of Material widgets with its widget counterparts. The only thing that I did not yet fix is replacing `MaterialApp` in this file. That probably needs @victorsanni 's work on page transitions to be addressed first? Part of flutter#177415 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

@Piinks

…1467) This PR reduces the reliance on Material in page_transitions_test.dart but does not entirely remove it. 1) Moves a test for persistent bottom sheet to the right file 2) Fixes a use of `sync*` (not sure why this is not caught by dev/bots/analyze.dart, that _does_ check for `sync*` cc @Piinks ) 3) Replaces some easy usages of Material widgets with its widget counterparts. The only thing that I did not yet fix is replacing `MaterialApp` in this file. That probably needs @victorsanni 's work on page transitions to be addressed first? Part of flutter#177415 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…#10957) flutter/flutter@c305f1f...bf701fe 2026-02-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 01ba84eeb32f to 56294a92d5cc (2 revisions) (flutter/flutter#181851) 2026-02-03 brackenavaron@gmail.com Remove material from scrollable_helpers_test.dart (flutter/flutter#181460) 2026-02-03 brackenavaron@gmail.com Reduce reliance on Material in page_transitions_test.dart (flutter/flutter#181467) 2026-02-03 116356835+AbdeMohlbi@users.noreply.github.com Fix todo about `replacing URL with constants` in `gradle_errors.dart` (flutter/flutter#181673) 2026-02-03 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 1L4m9qCikk-JzrNWE... to UmQaaNuhkiuE8Dzug... (flutter/flutter#181841) 2026-02-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 1aa8f2de7587 to 01ba84eeb32f (2 revisions) (flutter/flutter#181836) 2026-02-03 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#181738) 2026-02-03 brackenavaron@gmail.com Remove material from slivers_appbar_floating_pinned_test.dart + slivers_appbar_stretch_test.dart + sliver_persistent_header_test.dart + slivers_appbar_floating_test.dart (flutter/flutter#181469) 2026-02-02 engine-flutter-autoroll@skia.org Roll Skia from 43fa79e1c51f to f37a22506eb4 (1 revision) (flutter/flutter#181814) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jan 25, 2026

gemini-code-assist Bot reviewed Jan 25, 2026

View reviewed changes

Comment thread packages/flutter/test/material/persistent_bottom_sheet_test.dart Outdated

Comment thread packages/flutter/test/material/persistent_bottom_sheet_test.dart Outdated

dkwingsmt requested a review from justinmc January 28, 2026 19:26

justinmc approved these changes Feb 2, 2026

View reviewed changes

AbdeMohlbi self-requested a review February 2, 2026 23:10

AbdeMohlbi approved these changes Feb 2, 2026

View reviewed changes

justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 2, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 2, 2026

navaronbracke added 4 commits February 3, 2026 08:05

move persistent bottom sheet test to the right file

087e3a7

fix sync* violation

7a171eb

reduce dependency on material in page_transitions_test.dart

5a17747

fix type argument

913ef22

navaronbracke force-pushed the page_transitions_test_no_material branch from afb1d96 to 913ef22 Compare February 3, 2026 07:05

AbdeMohlbi added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 3, 2026

auto-submit Bot added this pull request to the merge queue Feb 3, 2026

Merged via the queue into flutter:master with commit 329d54b Feb 3, 2026
73 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 3, 2026

navaronbracke deleted the page_transitions_test_no_material branch February 3, 2026 09:34

engine-flutter-autoroll mentioned this pull request Feb 3, 2026

Roll Flutter from c305f1f7ad35 to bf701fefec86 (9 revisions) flutter/packages#10957

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2026

329d54b37 Reduce reliance on Material in page_transitions_test.dart (f…

1f484bc

…lutter/flutter#181467)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Reduce reliance on Material in page_transitions_test.dart#181467

Reduce reliance on Material in page_transitions_test.dart#181467
auto-submit[bot] merged 4 commits into
flutter:masterfrom
navaronbracke:page_transitions_test_no_material

navaronbracke commented Jan 25, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

justinmc left a comment

Uh oh!

auto-submit Bot commented Feb 2, 2026

Uh oh!

navaronbracke commented Feb 3, 2026 •

edited

Loading

Uh oh!

AbdeMohlbi commented Feb 3, 2026

Uh oh!

navaronbracke commented Feb 3, 2026

Uh oh!

AbdeMohlbi commented Feb 3, 2026

Uh oh!

Uh oh!

victorsanni commented Feb 3, 2026

Uh oh!

navaronbracke commented Feb 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

navaronbracke commented Jan 25, 2026

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit Bot commented Feb 2, 2026

Uh oh!

navaronbracke commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AbdeMohlbi commented Feb 3, 2026

Uh oh!

navaronbracke commented Feb 3, 2026

Uh oh!

AbdeMohlbi commented Feb 3, 2026

Uh oh!

Uh oh!

victorsanni commented Feb 3, 2026

Uh oh!

navaronbracke commented Feb 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

navaronbracke commented Feb 3, 2026 •

edited

Loading