Remove material from scrollable_helpers_test.dart#181460
Merged
auto-submit[bot] merged 3 commits intoFeb 3, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors scrollable_helpers_test.dart to remove its dependency on the Material library. This is a good cleanup and helps maintain separation of concerns between widget layers. A test that required Material widgets has been correctly moved to reorderable_list_test.dart. The changes look good overall. I've added one suggestion to scrollable_helpers_test.dart to reduce some code duplication, which will improve the file's maintainability.
Contributor
Author
|
This requires TestWidgetsApp |
0e429f8 to
503ec5e
Compare
AbdeMohlbi
approved these changes
Feb 2, 2026
Contributor
|
Ah there is a test failure, but it looks like an infra problem. If it doesn't pass after this re-run, maybe try updating the PR. |
Member
It had a merge conflict with another change you had in the merge queue. |
Contributor
Author
|
Right, it conflicted with the line for the slivers app bar stretch test that landed earlier. Fixed now, so we can retry once green again. |
Member
|
@navaronbracke what is the status of this one ? |
Contributor
Author
|
I fixed the merge conflict in be32ebc (sorry, wrong link) so this can get an autosubmit again? |
Member
can you update the branch once again so we can be sure it is working as expected ? then we can add the autosubmit |
Contributor
Author
|
Give me a second to rebase this again (there's another conflict :P) |
be32ebc to
fb0cb79
Compare
Member
|
@navaronbracke what is the status of this ? |
Contributor
Author
|
All checks are green again, so this can get an autosubmit label |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 3, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Feb 3, 2026
flutter/flutter@c305f1f...bf701fe 2026-02-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 01ba84eeb32f to 56294a92d5cc (2 revisions) (flutter/flutter#181851) 2026-02-03 brackenavaron@gmail.com Remove material from scrollable_helpers_test.dart (flutter/flutter#181460) 2026-02-03 brackenavaron@gmail.com Reduce reliance on Material in page_transitions_test.dart (flutter/flutter#181467) 2026-02-03 116356835+AbdeMohlbi@users.noreply.github.com Fix todo about `replacing URL with constants` in `gradle_errors.dart` (flutter/flutter#181673) 2026-02-03 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 1L4m9qCikk-JzrNWE... to UmQaaNuhkiuE8Dzug... (flutter/flutter#181841) 2026-02-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 1aa8f2de7587 to 01ba84eeb32f (2 revisions) (flutter/flutter#181836) 2026-02-03 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#181738) 2026-02-03 brackenavaron@gmail.com Remove material from slivers_appbar_floating_pinned_test.dart + slivers_appbar_stretch_test.dart + sliver_persistent_header_test.dart + slivers_appbar_floating_test.dart (flutter/flutter#181469) 2026-02-02 engine-flutter-autoroll@skia.org Roll Skia from 43fa79e1c51f to f37a22506eb4 (1 revision) (flutter/flutter#181814) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LongCatIsLooong
pushed a commit
to LongCatIsLooong/flutter
that referenced
this pull request
Feb 6, 2026
This PR removes material imports from scrollable_helpers_test.dart and moves a test to the right file Part of flutter#177415 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
flutter-zl
pushed a commit
to flutter-zl/flutter
that referenced
this pull request
Feb 10, 2026
This PR removes material imports from scrollable_helpers_test.dart and moves a test to the right file Part of flutter#177415 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
rickhohler
pushed a commit
to rickhohler/flutter
that referenced
this pull request
Feb 19, 2026
This PR removes material imports from scrollable_helpers_test.dart and moves a test to the right file Part of flutter#177415 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…#10957) flutter/flutter@c305f1f...bf701fe 2026-02-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 01ba84eeb32f to 56294a92d5cc (2 revisions) (flutter/flutter#181851) 2026-02-03 brackenavaron@gmail.com Remove material from scrollable_helpers_test.dart (flutter/flutter#181460) 2026-02-03 brackenavaron@gmail.com Reduce reliance on Material in page_transitions_test.dart (flutter/flutter#181467) 2026-02-03 116356835+AbdeMohlbi@users.noreply.github.com Fix todo about `replacing URL with constants` in `gradle_errors.dart` (flutter/flutter#181673) 2026-02-03 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 1L4m9qCikk-JzrNWE... to UmQaaNuhkiuE8Dzug... (flutter/flutter#181841) 2026-02-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 1aa8f2de7587 to 01ba84eeb32f (2 revisions) (flutter/flutter#181836) 2026-02-03 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#181738) 2026-02-03 brackenavaron@gmail.com Remove material from slivers_appbar_floating_pinned_test.dart + slivers_appbar_stretch_test.dart + sliver_persistent_header_test.dart + slivers_appbar_floating_test.dart (flutter/flutter#181469) 2026-02-02 engine-flutter-autoroll@skia.org Roll Skia from 43fa79e1c51f to f37a22506eb4 (1 revision) (flutter/flutter#181814) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes material imports from scrollable_helpers_test.dart and moves a test to the right file
Part of #177415
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.