[beta] Cherry pick https://github.com/flutter/flutter/pull/181269#181371
Conversation
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
There was a problem hiding this comment.
Code Review
This pull request addresses a compilation breakage by making the topGap parameter in the CupertinoSheetTransition constructor optional, defaulting to _kTopGapRatio. The documentation for topGap has been updated to reflect this change and to use a template for consistency. Corresponding test cases have been adjusted to remove the explicit topGap: 0.08 argument, relying on the new default value. The changes are well-aligned with the stated objective of loosening the API to resolve the compilation issue.
7e227d1
into
flutter:flutter-3.41-candidate.0
This PR cherrypicks #181269 into beta. This is needed to address a breakage.
Impacted Users: Apps that directly use
CupertinoSheetTransition.Impact Description: Can not compile.
Workaround: Yes. They need to add
topGap: 0.08to the constructor.Risk: Low. This PR loosens the API, and reverts the behavior to that before #171348.
Test Coverage: Yes. The widget has high test coverage.
Validation Steps: The PR compiles and tests pass.
sheet_test.dartcontains constructors that do not specifytopGapin the same way as existing apps.