Skip to content

Mark IconData final and @mustBeConst#181345

Merged
auto-submit[bot] merged 1 commit into
masterfrom
icon-data-class-modifier
Mar 24, 2026
Merged

Mark IconData final and @mustBeConst#181345
auto-submit[bot] merged 1 commit into
masterfrom
icon-data-class-modifier

Conversation

@dcharkes

@dcharkes dcharkes commented Jan 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

2026-03-18 update, no push-back on the breaking changes. Migrations done downstream:

Applying breaking changes:

See the issue descriptions for the motivation.

cc @Piinks

It seems we have a non-const use in the Remote Flutter Widgets:

https://github.com/flutter/packages/blob/d0c7d1fad77331724882614345137221c77d5758/packages/rfw/lib/src/flutter/argument_decoders.dart#L801-L811

The package itself makes no mention of it not work with the Flutter Icon Tree Shaker. If it's a know issue that the icon tree shaker is not supported with package:rfw we can add // ignore: non_const_argument_for_const_parameter. (flutter/packages#10858)

@flutter-dashboard

flutter-dashboard Bot commented Jan 22, 2026

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions Bot added the framework flutter/packages/flutter repository. See also f: labels. label Jan 22, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jan 22, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request makes IconData a final class and adds @mustBeConst to its constructor parameters, which is a great improvement for enforcing immutability and enabling compiler optimizations. My review includes a suggestion to apply the @mustBeConst annotation to all constructor parameters for completeness and consistency.

Comment thread packages/flutter/lib/src/widgets/icon_data.dart
@dcharkes dcharkes marked this pull request as draft January 22, 2026 21:06
@flutter-dashboard

flutter-dashboard Bot commented Jan 22, 2026

Copy link
Copy Markdown

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

dcharkes added a commit to flutter/packages that referenced this pull request Jan 22, 2026
@dcharkes
[rfw] Workaround IconData parameters must be const
501f4cc 
A patch for:

* flutter/flutter#181345
@dcharkes dcharkes mentioned this pull request Jan 22, 2026
Closed
justinmc
justinmc reviewed Jan 22, 2026
View reviewed changes

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a win to me. I want to be sure that Material and Cupertino don't have any breaking usages of IconData though (doesn't look like it to me if I grep through the codebase).

I haven't worked on the rfw codebase, but taking a look it seems like it won't be possible for it to support icon tree shaking. That makes sense for a package that can execute code at runtime that is unknown at compile time, so I expect users of rfw will understand.

@loic-sharma

loic-sharma commented Jan 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

FYI, some folks use the enum Foo implements IconData pattern, which I believe will be broken if we make IconData final. Some examples:

  1. https://github.com/FaFre/WebLibre/blob/82ea06d0ebd9fe72438dcbab63a2234b9314a2dd/app/lib/presentation/icons/tor_icons.dart#L22
  2. https://github.com/PiotrRogulski/advent_of_code/blob/acf963c651a4b83bdd14fc660fa96b35f85d6b9a/lib/design_system/icons.dart#L7
  3. Icon tree shaking ignores IconData implementation getters #126261

This comment explains why folks use this pattern: #126261 (comment)

One of the major if not the biggest value from keeping such values as an enum for me is the values property provided by the language itself. I use values in widgetbook; keeping such list manually is error-prone

However, it seems that this improvement is nice enough to warrant breaking breaking this pattern.

@dcharkes

dcharkes commented Jan 23, 2026

Copy link
Copy Markdown
Contributor Author

One of the major if not the biggest value from keeping such values as an enum for me is the values property provided by the language itself. I use values in widgetbook; keeping such list manually is error-prone

@Albert221 You rely on subtyping IconData to get an automated .values. Could you elaborate on how .values is used in the code? My understanding of the tree-shaking mechanism is if .values is used, then all the codePoints are reachable, which means you'll never get any code points tree-shaken from the fonts.

@Albert221

Albert221 commented Jan 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@dcharkes Hey! That is correct, they're not tree-shaken at all if I use .values. But I use it in my Widgetbook instance, where I want my developers and designers to have access to the whole library of available icons. The widgetbook is a separate package, so it doesn't hurt me. In the mobile app itself, I don't use .values at all for icons to have the tree-shaking :)

Setup we use for many projects and that many clients use in their codebases usually is:

  • app_package (depends on app_design_system)
  • app_design_system my custom icon datas
  • design_system_widgetbook (depends on app_design_system) where devs/designers can preview all available components, colors, icons, etc.

@dcharkes

dcharkes commented Jan 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Thanks for the reply @Albert221 🙏

Okay, then the tree-shaking is WAI in your use case. I suppose asking you to migrate away from enum ... implements IconData is asking you to break all your users? Would it be possible to migrate to the same structure as the other icon sets, an unrelated class around it with static const members and a code-genned(?) values const.

@Albert221

Albert221 commented Jan 23, 2026

Copy link
Copy Markdown
Contributor

Not ideal but possible, yes. If that's for the sake of making Flutter better for everyone, go for it

@dcharkes

dcharkes commented Jan 23, 2026

Copy link
Copy Markdown
Contributor Author

Not ideal but possible, yes. If that's for the sake of making Flutter better for everyone, go for it

🙏 👍 !

Okay, when we do this as a breaking change, then older versions of WidgetBook will stop working in a newer Flutter version. Please let me know when you have migrated, and if the migration didn't caused breaking change issues on your side (looking at the code I don't think so, but I might be wrong). I'll wait with landing anything on master for a while (and need to file a breaking change announcement as well) to ensure no one breaks.

@dcharkes dcharkes mentioned this pull request Jan 28, 2026
Merged
This was referenced Mar 10, 2026
Merged
Open
@dcharkes dcharkes force-pushed the icon-data-class-modifier branch from 6c1c25c to 63b8163 Compare March 10, 2026 08:43
dcharkes added a commit to flutter/packages that referenced this pull request Mar 11, 2026
@dcharkes
[rfw] Opt out of icon tree shaking (#11216)
a6542ce 
We are introducing the `@mustBeConst` annotation on `IconData`
parameters that must be const in order for the icon tree shaker to work:

* flutter/flutter#181344
* flutter/flutter#181345

RFW does not support tree-shaking.

This PR adds the lint ignores with an explicit comment that the lint
ignore is intentional.
@dcharkes dcharkes force-pushed the icon-data-class-modifier branch from 63b8163 to 84a1207 Compare March 12, 2026 15:42
@dcharkes dcharkes added the CICD Run CI/CD label Mar 12, 2026
@dcharkes dcharkes force-pushed the icon-data-class-modifier branch from 84a1207 to 8569697 Compare March 16, 2026 07:31
@dcharkes dcharkes added CICD Run CI/CD and removed CICD Run CI/CD labels Mar 16, 2026
@dcharkes dcharkes mentioned this pull request Mar 16, 2026
Merged
dcharkes added a commit to flutter/tests that referenced this pull request Mar 16, 2026
@dcharkes
Update git hash in flutter_packages.test (#482)
a2f216b 
Roll in flutter/packages#11216.

To make flutter/flutter#181345 go green.
@dcharkes dcharkes force-pushed the icon-data-class-modifier branch from 8569697 to f9750dd Compare March 16, 2026 18:21
@dcharkes dcharkes added CICD Run CI/CD and removed CICD Run CI/CD labels Mar 16, 2026
@dcharkes dcharkes mentioned this pull request Mar 16, 2026
Merged
23 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 24, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 24, 2026
@engine-flutter-autoroll
5940fcf3f Mark IconData final and @mustBeConst (flutter/flutter…
0dcaa59 
…#181345)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 24, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 24, 2026
@engine-flutter-autoroll
5940fcf3f Mark IconData final and @mustBeConst (flutter/flutter…
1e58411 
…#181345)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 24, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 24, 2026
@engine-flutter-autoroll
5940fcf3f Mark IconData final and @mustBeConst (flutter/flutter…
1ef5a7e 
…#181345)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 24, 2026
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 24, 2026
@engine-flutter-autoroll
5940fcf3f Mark IconData final and @mustBeConst (flutter/flutter…
ab30ebf 
…#181345)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 25, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2026
@engine-flutter-autoroll
5940fcf3f Mark IconData final and @mustBeConst (flutter/flutter…
7d3acb0 
…#181345)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 25, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2026
@engine-flutter-autoroll
5940fcf3f Mark IconData final and @mustBeConst (flutter/flutter…
f5eea63 
…#181345)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 25, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2026
@engine-flutter-autoroll
5940fcf3f Mark IconData final and @mustBeConst (flutter/flutter…
ab3ec34 
…#181345)
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Mar 25, 2026
@engine-flutter-autoroll
Manual roll Flutter from dd64978dfae1 to 82d96ef98a33 (89 revisions) (#…
a3d306f 
…11345)

Manual roll Flutter from dd64978dfae1 to 82d96ef98a33 (89 revisions)

Manual roll requested by tarrinneal@google.com

flutter/flutter@dd64978...82d96ef

2026-03-24 116356835+AbdeMohlbi@users.noreply.github.com Fix RenderStack's documentation (flutter/flutter#183822)
2026-03-24 engine-flutter-autoroll@skia.org Roll Skia from a465876e3156 to f4e59f82dc69 (4 revisions) (flutter/flutter#184082)
2026-03-24 30870216+gaaclarke@users.noreply.github.com Refactor: Removes Geometry field from ColorSourceContents (flutter/flutter#183952)
2026-03-24 katelovett@google.com Refactor layout dimensions (flutter/flutter#184066)
2026-03-24 abadasamuelosp@gmail.com feat: Add --base-href support to flutter run for web (flutter/flutter#182709)
2026-03-24 43498643+mkucharski17@users.noreply.github.com Add LeanCode and contributors to AUTHORS (flutter/flutter#182997)
2026-03-24 dacoharkes@google.com [tools] Make sure `assemble` has a pubspec as cwd (flutter/flutter#184067)
2026-03-24 engine-flutter-autoroll@skia.org Roll Skia from bf4f2763b6e6 to a465876e3156 (5 revisions) (flutter/flutter#184068)
2026-03-24 evanwall@buffalo.edu fix gaussian blur getting clipped with negative scale (flutter/flutter#184037)
2026-03-24 34871572+gmackall@users.noreply.github.com Keep glyphs for variable fonts (flutter/flutter#183857)
2026-03-24 dacoharkes@google.com Mark `IconData` `final` and `@mustBeConst` (flutter/flutter#181345)
2026-03-24 engine-flutter-autoroll@skia.org Roll Skia from 62841a512deb to bf4f2763b6e6 (1 revision) (flutter/flutter#184062)
2026-03-24 ahmedsameha1@gmail.com Use Color.a instead of Color.alpha to assert the opacity of the color… (flutter/flutter#184003)
2026-03-24 engine-flutter-autoroll@skia.org Roll Dart SDK from f504293598f2 to b08bd0a3ee39 (1 revision) (flutter/flutter#184054)
2026-03-24 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from x9x76ERXhrt0Q3zKf... to M3sjWggTQmP2AD4bS... (flutter/flutter#184053)
2026-03-24 engine-flutter-autoroll@skia.org Roll Dart SDK from 788e347194a6 to f504293598f2 (1 revision) (flutter/flutter#184048)
2026-03-24 engine-flutter-autoroll@skia.org Roll Skia from fb6acef456ea to 62841a512deb (2 revisions) (flutter/flutter#184046)
2026-03-24 dkwingsmt@users.noreply.github.com [Slider] Remove value indicator painter when animation is dismissed (flutter/flutter#182991)
2026-03-24 engine-flutter-autoroll@skia.org Manual roll ICU from 7971660ba630 to ee5f27adc28b (1 revision) (flutter/flutter#184041)
2026-03-23 ishaquehassan@gmail.com Add scrollPadding property to DropdownMenu (flutter/flutter#183109)
2026-03-23 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#183895)
2026-03-23 engine-flutter-autoroll@skia.org Roll Skia from c2b58922e37d to fb6acef456ea (1 revision) (flutter/flutter#184033)
2026-03-23 engine-flutter-autoroll@skia.org Roll Dart SDK from b172bea4f008 to 788e347194a6 (2 revisions) (flutter/flutter#184035)
2026-03-23 codefu@google.com chore: deflake Linux_android_emu android_display_cutout (flutter/flutter#183522)
2026-03-23 vs.ashoknarayan@gmail.com Add note about gclient sync network failures and workaround (flutter/flutter#183794)
2026-03-23 engine-flutter-autoroll@skia.org Roll Skia from a81bf411a5cb to c2b58922e37d (3 revisions) (flutter/flutter#184016)
2026-03-23 1961493+harryterkelsen@users.noreply.github.com refactor(web): use positive logic and platform defaults for accessibility features (flutter/flutter#183907)
2026-03-23 jhy03261997@gmail.com [android][a11y] set "android.widget.ProgressBar" according to semantics role (flutter/flutter#183897)
2026-03-23 mr-peipei@web.de Add progress bar to artifact downloads (flutter/flutter#182836)
2026-03-23 116356835+AbdeMohlbi@users.noreply.github.com Add windows instruction to `Forcing Flutter Tools Snapshot Regeneration` (flutter/flutter#183977)
2026-03-23 engine-flutter-autoroll@skia.org Roll Skia from 42a6eb1dc5c9 to a81bf411a5cb (3 revisions) (flutter/flutter#184007)
2026-03-23 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from q1xqlQPxq8a3JTA4P... to x9x76ERXhrt0Q3zKf... (flutter/flutter#184006)
2026-03-23 engine-flutter-autoroll@skia.org Roll Dart SDK from ef45f179526f to b172bea4f008 (1 revision) (flutter/flutter#184004)
2026-03-23 engine-flutter-autoroll@skia.org Roll Skia from 964c3b33fd73 to 42a6eb1dc5c9 (1 revision) (flutter/flutter#184001)
2026-03-23 matt.kosarek@canonical.com Update the windowing docs per the latest wording found while doing Satellites (flutter/flutter#183748)
2026-03-22 48625061+muradhossin@users.noreply.github.com Add assert for mutually exclusive errorBuilder and errorText (flutter/flutter#183901)
2026-03-22 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Yc7Ijp2ySjG841xha... to q1xqlQPxq8a3JTA4P... (flutter/flutter#183991)
2026-03-21 engine-flutter-autoroll@skia.org Roll Skia from 812822ad5caa to 964c3b33fd73 (1 revision) (flutter/flutter#183982)
2026-03-21 engine-flutter-autoroll@skia.org Roll Dart SDK from c831a55e2fcc to ef45f179526f (1 revision) (flutter/flutter#183973)
2026-03-21 engine-flutter-autoroll@skia.org Roll Skia from 569cc0475162 to 812822ad5caa (2 revisions) (flutter/flutter#183970)
2026-03-20 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ilAIAVzu4xmeb078x... to Yc7Ijp2ySjG841xha... (flutter/flutter#183956)
2026-03-20 engine-flutter-autoroll@skia.org Roll Skia from 79a14289c60d to 569cc0475162 (3 revisions) (flutter/flutter#183954)
2026-03-20 engine-flutter-autoroll@skia.org Roll Dart SDK from c88a8008e93b to c831a55e2fcc (3 revisions) (flutter/flutter#183953)
2026-03-20 engine-flutter-autoroll@skia.org Roll Skia from 8d4c76b92050 to 79a14289c60d (4 revisions) (flutter/flutter#183949)
...
copybara-service Bot pushed a commit to dart-lang/sdk that referenced this pull request Mar 25, 2026
@elliette
Revert to earlier version of DevTools
770d686 
This is before the two commits that keep getting rebuilt, but still includes flutter/devtools#9718 which needed to land in g3 for flutter/flutter#181345.

Change-Id: I7b6ffe670b268247bc3753d44cb6d027a1b277bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/490741
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Elliott Brooks <elliottbrooks@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
okorohelijah pushed a commit to okorohelijah/packages that referenced this pull request Mar 26, 2026
@dcharkes @okorohelijah
[rfw] Opt out of icon tree shaking (flutter#11216)
2124568 
We are introducing the `@mustBeConst` annotation on `IconData`
parameters that must be const in order for the icon tree shaker to work:

* flutter/flutter#181344
* flutter/flutter#181345

RFW does not support tree-shaking.

This PR adds the lint ignores with an explicit comment that the lint
ignore is intentional.
okorohelijah pushed a commit to okorohelijah/packages that referenced this pull request Mar 26, 2026
@engine-flutter-autoroll @okorohelijah
Manual roll Flutter from dd64978dfae1 to 82d96ef98a33 (89 revisions) (f…
6587d98 
…lutter#11345)

Manual roll Flutter from dd64978dfae1 to 82d96ef98a33 (89 revisions)

Manual roll requested by tarrinneal@google.com

flutter/flutter@dd64978...82d96ef

2026-03-24 116356835+AbdeMohlbi@users.noreply.github.com Fix RenderStack's documentation (flutter/flutter#183822)
2026-03-24 engine-flutter-autoroll@skia.org Roll Skia from a465876e3156 to f4e59f82dc69 (4 revisions) (flutter/flutter#184082)
2026-03-24 30870216+gaaclarke@users.noreply.github.com Refactor: Removes Geometry field from ColorSourceContents (flutter/flutter#183952)
2026-03-24 katelovett@google.com Refactor layout dimensions (flutter/flutter#184066)
2026-03-24 abadasamuelosp@gmail.com feat: Add --base-href support to flutter run for web (flutter/flutter#182709)
2026-03-24 43498643+mkucharski17@users.noreply.github.com Add LeanCode and contributors to AUTHORS (flutter/flutter#182997)
2026-03-24 dacoharkes@google.com [tools] Make sure `assemble` has a pubspec as cwd (flutter/flutter#184067)
2026-03-24 engine-flutter-autoroll@skia.org Roll Skia from bf4f2763b6e6 to a465876e3156 (5 revisions) (flutter/flutter#184068)
2026-03-24 evanwall@buffalo.edu fix gaussian blur getting clipped with negative scale (flutter/flutter#184037)
2026-03-24 34871572+gmackall@users.noreply.github.com Keep glyphs for variable fonts (flutter/flutter#183857)
2026-03-24 dacoharkes@google.com Mark `IconData` `final` and `@mustBeConst` (flutter/flutter#181345)
2026-03-24 engine-flutter-autoroll@skia.org Roll Skia from 62841a512deb to bf4f2763b6e6 (1 revision) (flutter/flutter#184062)
2026-03-24 ahmedsameha1@gmail.com Use Color.a instead of Color.alpha to assert the opacity of the color… (flutter/flutter#184003)
2026-03-24 engine-flutter-autoroll@skia.org Roll Dart SDK from f504293598f2 to b08bd0a3ee39 (1 revision) (flutter/flutter#184054)
2026-03-24 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from x9x76ERXhrt0Q3zKf... to M3sjWggTQmP2AD4bS... (flutter/flutter#184053)
2026-03-24 engine-flutter-autoroll@skia.org Roll Dart SDK from 788e347194a6 to f504293598f2 (1 revision) (flutter/flutter#184048)
2026-03-24 engine-flutter-autoroll@skia.org Roll Skia from fb6acef456ea to 62841a512deb (2 revisions) (flutter/flutter#184046)
2026-03-24 dkwingsmt@users.noreply.github.com [Slider] Remove value indicator painter when animation is dismissed (flutter/flutter#182991)
2026-03-24 engine-flutter-autoroll@skia.org Manual roll ICU from 7971660ba630 to ee5f27adc28b (1 revision) (flutter/flutter#184041)
2026-03-23 ishaquehassan@gmail.com Add scrollPadding property to DropdownMenu (flutter/flutter#183109)
2026-03-23 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#183895)
2026-03-23 engine-flutter-autoroll@skia.org Roll Skia from c2b58922e37d to fb6acef456ea (1 revision) (flutter/flutter#184033)
2026-03-23 engine-flutter-autoroll@skia.org Roll Dart SDK from b172bea4f008 to 788e347194a6 (2 revisions) (flutter/flutter#184035)
2026-03-23 codefu@google.com chore: deflake Linux_android_emu android_display_cutout (flutter/flutter#183522)
2026-03-23 vs.ashoknarayan@gmail.com Add note about gclient sync network failures and workaround (flutter/flutter#183794)
2026-03-23 engine-flutter-autoroll@skia.org Roll Skia from a81bf411a5cb to c2b58922e37d (3 revisions) (flutter/flutter#184016)
2026-03-23 1961493+harryterkelsen@users.noreply.github.com refactor(web): use positive logic and platform defaults for accessibility features (flutter/flutter#183907)
2026-03-23 jhy03261997@gmail.com [android][a11y] set "android.widget.ProgressBar" according to semantics role (flutter/flutter#183897)
2026-03-23 mr-peipei@web.de Add progress bar to artifact downloads (flutter/flutter#182836)
2026-03-23 116356835+AbdeMohlbi@users.noreply.github.com Add windows instruction to `Forcing Flutter Tools Snapshot Regeneration` (flutter/flutter#183977)
2026-03-23 engine-flutter-autoroll@skia.org Roll Skia from 42a6eb1dc5c9 to a81bf411a5cb (3 revisions) (flutter/flutter#184007)
2026-03-23 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from q1xqlQPxq8a3JTA4P... to x9x76ERXhrt0Q3zKf... (flutter/flutter#184006)
2026-03-23 engine-flutter-autoroll@skia.org Roll Dart SDK from ef45f179526f to b172bea4f008 (1 revision) (flutter/flutter#184004)
2026-03-23 engine-flutter-autoroll@skia.org Roll Skia from 964c3b33fd73 to 42a6eb1dc5c9 (1 revision) (flutter/flutter#184001)
2026-03-23 matt.kosarek@canonical.com Update the windowing docs per the latest wording found while doing Satellites (flutter/flutter#183748)
2026-03-22 48625061+muradhossin@users.noreply.github.com Add assert for mutually exclusive errorBuilder and errorText (flutter/flutter#183901)
2026-03-22 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Yc7Ijp2ySjG841xha... to q1xqlQPxq8a3JTA4P... (flutter/flutter#183991)
2026-03-21 engine-flutter-autoroll@skia.org Roll Skia from 812822ad5caa to 964c3b33fd73 (1 revision) (flutter/flutter#183982)
2026-03-21 engine-flutter-autoroll@skia.org Roll Dart SDK from c831a55e2fcc to ef45f179526f (1 revision) (flutter/flutter#183973)
2026-03-21 engine-flutter-autoroll@skia.org Roll Skia from 569cc0475162 to 812822ad5caa (2 revisions) (flutter/flutter#183970)
2026-03-20 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ilAIAVzu4xmeb078x... to Yc7Ijp2ySjG841xha... (flutter/flutter#183956)
2026-03-20 engine-flutter-autoroll@skia.org Roll Skia from 79a14289c60d to 569cc0475162 (3 revisions) (flutter/flutter#183954)
2026-03-20 engine-flutter-autoroll@skia.org Roll Dart SDK from c88a8008e93b to c831a55e2fcc (3 revisions) (flutter/flutter#183953)
2026-03-20 engine-flutter-autoroll@skia.org Roll Skia from 8d4c76b92050 to 79a14289c60d (4 revisions) (flutter/flutter#183949)
...
sfshaza2 pushed a commit to flutter/website that referenced this pull request Mar 26, 2026
@dcharkes
Migration guide for IconData (#13005)
c9f2fa7 
A migration guide for:

* flutter/flutter#181342
* flutter/flutter#181344

Breaking change PR:

* flutter/flutter#181345
mboetger pushed a commit to mboetger/flutter that referenced this pull request Mar 26, 2026
@dcharkes @mboetger
Mark IconData final and @mustBeConst (flutter#181345)
c37e86e 
2026-03-18 update, no push-back on the breaking changes. Migrations done
downstream:

* fluttercommunity/font_awesome_flutter#297
*
PiotrRogulski/kanji_app@76973c7
* flutter/packages#11216
* FaFre/WebLibre#214
* flutter/devtools#9718

-----------

Applying breaking changes:

* flutter#181342
* flutter#181344

See the issue descriptions for the motivation.

cc @Piinks 

It seems we have a non-const use in the Remote Flutter Widgets:


https://github.com/flutter/packages/blob/d0c7d1fad77331724882614345137221c77d5758/packages/rfw/lib/src/flutter/argument_decoders.dart#L801-L811

The package itself makes no mention of it not work with the Flutter Icon
Tree Shaker. If it's a know issue that the icon tree shaker is not
supported with `package:rfw` we can add `// ignore:
non_const_argument_for_const_parameter`.
(flutter/packages#10858)
@Piinks Piinks mentioned this pull request Mar 27, 2026
Open
ahmedsameha1 pushed a commit to ahmedsameha1/flutter that referenced this pull request Apr 14, 2026
@dcharkes @ahmedsameha1
Mark IconData final and @mustBeConst (flutter#181345)
dce2061 
2026-03-18 update, no push-back on the breaking changes. Migrations done
downstream:

* fluttercommunity/font_awesome_flutter#297
*
PiotrRogulski/kanji_app@76973c7
* flutter/packages#11216
* FaFre/WebLibre#214
* flutter/devtools#9718

-----------

Applying breaking changes:

* flutter#181342
* flutter#181344

See the issue descriptions for the motivation.

cc @Piinks 

It seems we have a non-const use in the Remote Flutter Widgets:


https://github.com/flutter/packages/blob/d0c7d1fad77331724882614345137221c77d5758/packages/rfw/lib/src/flutter/argument_decoders.dart#L801-L811

The package itself makes no mention of it not work with the Flutter Icon
Tree Shaker. If it's a know issue that the icon tree shaker is not
supported with `package:rfw` we can add `// ignore:
non_const_argument_for_const_parameter`.
(flutter/packages#10858)
Tulon added a commit to Tulon/WineBar that referenced this pull request Apr 15, 2026
@Tulon
Switch from the material_design_icons_flutter to the `flutter_mater…
3f7a355 
…ial_design_icons` package

The reason for the switch is that this commit [1] to Flutter broke the former
package, which seems no longer maintained, so there is no one to fix it.
The newer package seems to be API-compatible with the former one and
doesn't seem to be affected by [1], making it a natural choice to migrate to.

[1]: flutter/flutter#181345
Tulon added a commit to Tulon/WineBar that referenced this pull request Apr 15, 2026
@Tulon
Switch from the material_design_icons_flutter to the `flutter_mater…
cb678ce 
…ial_design_icons` package

The reason for the switch is that this commit [1] to Flutter broke the former
package, which seems no longer maintained, so there is no one to fix it.
The newer package seems to be API-compatible with the former one and
doesn't seem to be affected by [1], making it a natural choice to migrate to.

[1]: flutter/flutter#181345
Jyndigo pushed a commit to uesp/wkwebview_flutter that referenced this pull request Apr 15, 2026
@engine-flutter-autoroll
Manual roll Flutter from dd64978dfae1 to 82d96ef98a33 (89 revisions) …
22ca87b 
…(#11345)

Manual roll Flutter from dd64978dfae1 to 82d96ef98a33 (89 revisions)

Manual roll requested by tarrinneal@google.com

flutter/flutter@dd64978...82d96ef

2026-03-24 116356835+AbdeMohlbi@users.noreply.github.com Fix RenderStack's documentation (flutter/flutter#183822)
2026-03-24 engine-flutter-autoroll@skia.org Roll Skia from a465876e3156 to f4e59f82dc69 (4 revisions) (flutter/flutter#184082)
2026-03-24 30870216+gaaclarke@users.noreply.github.com Refactor: Removes Geometry field from ColorSourceContents (flutter/flutter#183952)
2026-03-24 katelovett@google.com Refactor layout dimensions (flutter/flutter#184066)
2026-03-24 abadasamuelosp@gmail.com feat: Add --base-href support to flutter run for web (flutter/flutter#182709)
2026-03-24 43498643+mkucharski17@users.noreply.github.com Add LeanCode and contributors to AUTHORS (flutter/flutter#182997)
2026-03-24 dacoharkes@google.com [tools] Make sure `assemble` has a pubspec as cwd (flutter/flutter#184067)
2026-03-24 engine-flutter-autoroll@skia.org Roll Skia from bf4f2763b6e6 to a465876e3156 (5 revisions) (flutter/flutter#184068)
2026-03-24 evanwall@buffalo.edu fix gaussian blur getting clipped with negative scale (flutter/flutter#184037)
2026-03-24 34871572+gmackall@users.noreply.github.com Keep glyphs for variable fonts (flutter/flutter#183857)
2026-03-24 dacoharkes@google.com Mark `IconData` `final` and `@mustBeConst` (flutter/flutter#181345)
2026-03-24 engine-flutter-autoroll@skia.org Roll Skia from 62841a512deb to bf4f2763b6e6 (1 revision) (flutter/flutter#184062)
2026-03-24 ahmedsameha1@gmail.com Use Color.a instead of Color.alpha to assert the opacity of the color… (flutter/flutter#184003)
2026-03-24 engine-flutter-autoroll@skia.org Roll Dart SDK from f504293598f2 to b08bd0a3ee39 (1 revision) (flutter/flutter#184054)
2026-03-24 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from x9x76ERXhrt0Q3zKf... to M3sjWggTQmP2AD4bS... (flutter/flutter#184053)
2026-03-24 engine-flutter-autoroll@skia.org Roll Dart SDK from 788e347194a6 to f504293598f2 (1 revision) (flutter/flutter#184048)
2026-03-24 engine-flutter-autoroll@skia.org Roll Skia from fb6acef456ea to 62841a512deb (2 revisions) (flutter/flutter#184046)
2026-03-24 dkwingsmt@users.noreply.github.com [Slider] Remove value indicator painter when animation is dismissed (flutter/flutter#182991)
2026-03-24 engine-flutter-autoroll@skia.org Manual roll ICU from 7971660ba630 to ee5f27adc28b (1 revision) (flutter/flutter#184041)
2026-03-23 ishaquehassan@gmail.com Add scrollPadding property to DropdownMenu (flutter/flutter#183109)
2026-03-23 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#183895)
2026-03-23 engine-flutter-autoroll@skia.org Roll Skia from c2b58922e37d to fb6acef456ea (1 revision) (flutter/flutter#184033)
2026-03-23 engine-flutter-autoroll@skia.org Roll Dart SDK from b172bea4f008 to 788e347194a6 (2 revisions) (flutter/flutter#184035)
2026-03-23 codefu@google.com chore: deflake Linux_android_emu android_display_cutout (flutter/flutter#183522)
2026-03-23 vs.ashoknarayan@gmail.com Add note about gclient sync network failures and workaround (flutter/flutter#183794)
2026-03-23 engine-flutter-autoroll@skia.org Roll Skia from a81bf411a5cb to c2b58922e37d (3 revisions) (flutter/flutter#184016)
2026-03-23 1961493+harryterkelsen@users.noreply.github.com refactor(web): use positive logic and platform defaults for accessibility features (flutter/flutter#183907)
2026-03-23 jhy03261997@gmail.com [android][a11y] set "android.widget.ProgressBar" according to semantics role (flutter/flutter#183897)
2026-03-23 mr-peipei@web.de Add progress bar to artifact downloads (flutter/flutter#182836)
2026-03-23 116356835+AbdeMohlbi@users.noreply.github.com Add windows instruction to `Forcing Flutter Tools Snapshot Regeneration` (flutter/flutter#183977)
2026-03-23 engine-flutter-autoroll@skia.org Roll Skia from 42a6eb1dc5c9 to a81bf411a5cb (3 revisions) (flutter/flutter#184007)
2026-03-23 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from q1xqlQPxq8a3JTA4P... to x9x76ERXhrt0Q3zKf... (flutter/flutter#184006)
2026-03-23 engine-flutter-autoroll@skia.org Roll Dart SDK from ef45f179526f to b172bea4f008 (1 revision) (flutter/flutter#184004)
2026-03-23 engine-flutter-autoroll@skia.org Roll Skia from 964c3b33fd73 to 42a6eb1dc5c9 (1 revision) (flutter/flutter#184001)
2026-03-23 matt.kosarek@canonical.com Update the windowing docs per the latest wording found while doing Satellites (flutter/flutter#183748)
2026-03-22 48625061+muradhossin@users.noreply.github.com Add assert for mutually exclusive errorBuilder and errorText (flutter/flutter#183901)
2026-03-22 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Yc7Ijp2ySjG841xha... to q1xqlQPxq8a3JTA4P... (flutter/flutter#183991)
2026-03-21 engine-flutter-autoroll@skia.org Roll Skia from 812822ad5caa to 964c3b33fd73 (1 revision) (flutter/flutter#183982)
2026-03-21 engine-flutter-autoroll@skia.org Roll Dart SDK from c831a55e2fcc to ef45f179526f (1 revision) (flutter/flutter#183973)
2026-03-21 engine-flutter-autoroll@skia.org Roll Skia from 569cc0475162 to 812822ad5caa (2 revisions) (flutter/flutter#183970)
2026-03-20 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ilAIAVzu4xmeb078x... to Yc7Ijp2ySjG841xha... (flutter/flutter#183956)
2026-03-20 engine-flutter-autoroll@skia.org Roll Skia from 79a14289c60d to 569cc0475162 (3 revisions) (flutter/flutter#183954)
2026-03-20 engine-flutter-autoroll@skia.org Roll Dart SDK from c88a8008e93b to c831a55e2fcc (3 revisions) (flutter/flutter#183953)
2026-03-20 engine-flutter-autoroll@skia.org Roll Skia from 8d4c76b92050 to 79a14289c60d (4 revisions) (flutter/flutter#183949)
...
This was referenced Apr 16, 2026
Closed
Merged
Tulon added a commit to Tulon/WineBar that referenced this pull request Apr 17, 2026
@Tulon
Switch from the material_design_icons_flutter to the `flutter_mater…
ce216e8 
…ial_design_icons` package (#43)

The reason for the switch is that this commit [1] to Flutter broke the
former package, which seems no longer maintained, so there is no one to
fix it. The newer package seems to be API-compatible with the former one
and doesn't seem to be affected by [1], making it a natural choice to
migrate to.

[1]: flutter/flutter#181345
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@dcharkes
[rfw] Opt out of icon tree shaking (flutter#11216)
000cc00 
We are introducing the `@mustBeConst` annotation on `IconData`
parameters that must be const in order for the icon tree shaker to work:

* flutter/flutter#181344
* flutter/flutter#181345

RFW does not support tree-shaking.

This PR adds the lint ignores with an explicit comment that the lint
ignore is intentional.
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@engine-flutter-autoroll
Manual roll Flutter from dd64978dfae1 to 82d96ef98a33 (89 revisions) (f…
f874830 
…lutter#11345)

Manual roll Flutter from dd64978dfae1 to 82d96ef98a33 (89 revisions)

Manual roll requested by tarrinneal@google.com

flutter/flutter@dd64978...82d96ef

2026-03-24 116356835+AbdeMohlbi@users.noreply.github.com Fix RenderStack's documentation (flutter/flutter#183822)
2026-03-24 engine-flutter-autoroll@skia.org Roll Skia from a465876e3156 to f4e59f82dc69 (4 revisions) (flutter/flutter#184082)
2026-03-24 30870216+gaaclarke@users.noreply.github.com Refactor: Removes Geometry field from ColorSourceContents (flutter/flutter#183952)
2026-03-24 katelovett@google.com Refactor layout dimensions (flutter/flutter#184066)
2026-03-24 abadasamuelosp@gmail.com feat: Add --base-href support to flutter run for web (flutter/flutter#182709)
2026-03-24 43498643+mkucharski17@users.noreply.github.com Add LeanCode and contributors to AUTHORS (flutter/flutter#182997)
2026-03-24 dacoharkes@google.com [tools] Make sure `assemble` has a pubspec as cwd (flutter/flutter#184067)
2026-03-24 engine-flutter-autoroll@skia.org Roll Skia from bf4f2763b6e6 to a465876e3156 (5 revisions) (flutter/flutter#184068)
2026-03-24 evanwall@buffalo.edu fix gaussian blur getting clipped with negative scale (flutter/flutter#184037)
2026-03-24 34871572+gmackall@users.noreply.github.com Keep glyphs for variable fonts (flutter/flutter#183857)
2026-03-24 dacoharkes@google.com Mark `IconData` `final` and `@mustBeConst` (flutter/flutter#181345)
2026-03-24 engine-flutter-autoroll@skia.org Roll Skia from 62841a512deb to bf4f2763b6e6 (1 revision) (flutter/flutter#184062)
2026-03-24 ahmedsameha1@gmail.com Use Color.a instead of Color.alpha to assert the opacity of the color… (flutter/flutter#184003)
2026-03-24 engine-flutter-autoroll@skia.org Roll Dart SDK from f504293598f2 to b08bd0a3ee39 (1 revision) (flutter/flutter#184054)
2026-03-24 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from x9x76ERXhrt0Q3zKf... to M3sjWggTQmP2AD4bS... (flutter/flutter#184053)
2026-03-24 engine-flutter-autoroll@skia.org Roll Dart SDK from 788e347194a6 to f504293598f2 (1 revision) (flutter/flutter#184048)
2026-03-24 engine-flutter-autoroll@skia.org Roll Skia from fb6acef456ea to 62841a512deb (2 revisions) (flutter/flutter#184046)
2026-03-24 dkwingsmt@users.noreply.github.com [Slider] Remove value indicator painter when animation is dismissed (flutter/flutter#182991)
2026-03-24 engine-flutter-autoroll@skia.org Manual roll ICU from 7971660ba630 to ee5f27adc28b (1 revision) (flutter/flutter#184041)
2026-03-23 ishaquehassan@gmail.com Add scrollPadding property to DropdownMenu (flutter/flutter#183109)
2026-03-23 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#183895)
2026-03-23 engine-flutter-autoroll@skia.org Roll Skia from c2b58922e37d to fb6acef456ea (1 revision) (flutter/flutter#184033)
2026-03-23 engine-flutter-autoroll@skia.org Roll Dart SDK from b172bea4f008 to 788e347194a6 (2 revisions) (flutter/flutter#184035)
2026-03-23 codefu@google.com chore: deflake Linux_android_emu android_display_cutout (flutter/flutter#183522)
2026-03-23 vs.ashoknarayan@gmail.com Add note about gclient sync network failures and workaround (flutter/flutter#183794)
2026-03-23 engine-flutter-autoroll@skia.org Roll Skia from a81bf411a5cb to c2b58922e37d (3 revisions) (flutter/flutter#184016)
2026-03-23 1961493+harryterkelsen@users.noreply.github.com refactor(web): use positive logic and platform defaults for accessibility features (flutter/flutter#183907)
2026-03-23 jhy03261997@gmail.com [android][a11y] set "android.widget.ProgressBar" according to semantics role (flutter/flutter#183897)
2026-03-23 mr-peipei@web.de Add progress bar to artifact downloads (flutter/flutter#182836)
2026-03-23 116356835+AbdeMohlbi@users.noreply.github.com Add windows instruction to `Forcing Flutter Tools Snapshot Regeneration` (flutter/flutter#183977)
2026-03-23 engine-flutter-autoroll@skia.org Roll Skia from 42a6eb1dc5c9 to a81bf411a5cb (3 revisions) (flutter/flutter#184007)
2026-03-23 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from q1xqlQPxq8a3JTA4P... to x9x76ERXhrt0Q3zKf... (flutter/flutter#184006)
2026-03-23 engine-flutter-autoroll@skia.org Roll Dart SDK from ef45f179526f to b172bea4f008 (1 revision) (flutter/flutter#184004)
2026-03-23 engine-flutter-autoroll@skia.org Roll Skia from 964c3b33fd73 to 42a6eb1dc5c9 (1 revision) (flutter/flutter#184001)
2026-03-23 matt.kosarek@canonical.com Update the windowing docs per the latest wording found while doing Satellites (flutter/flutter#183748)
2026-03-22 48625061+muradhossin@users.noreply.github.com Add assert for mutually exclusive errorBuilder and errorText (flutter/flutter#183901)
2026-03-22 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Yc7Ijp2ySjG841xha... to q1xqlQPxq8a3JTA4P... (flutter/flutter#183991)
2026-03-21 engine-flutter-autoroll@skia.org Roll Skia from 812822ad5caa to 964c3b33fd73 (1 revision) (flutter/flutter#183982)
2026-03-21 engine-flutter-autoroll@skia.org Roll Dart SDK from c831a55e2fcc to ef45f179526f (1 revision) (flutter/flutter#183973)
2026-03-21 engine-flutter-autoroll@skia.org Roll Skia from 569cc0475162 to 812822ad5caa (2 revisions) (flutter/flutter#183970)
2026-03-20 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ilAIAVzu4xmeb078x... to Yc7Ijp2ySjG841xha... (flutter/flutter#183956)
2026-03-20 engine-flutter-autoroll@skia.org Roll Skia from 79a14289c60d to 569cc0475162 (3 revisions) (flutter/flutter#183954)
2026-03-20 engine-flutter-autoroll@skia.org Roll Dart SDK from c88a8008e93b to c831a55e2fcc (3 revisions) (flutter/flutter#183953)
2026-03-20 engine-flutter-autoroll@skia.org Roll Skia from 8d4c76b92050 to 79a14289c60d (4 revisions) (flutter/flutter#183949)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc left review comments
@Piinks Piinks Piinks approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CICD Run CI/CD framework flutter/packages/flutter repository. See also f: labels.

Projects

Google Testing Queue
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dcharkes @loic-sharma @Albert221 @Piinks @justinmc