Remove use of SkDeserialProcs::fTypefaceProc#181047
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request correctly replaces the deprecated SkDeserialProcs::fTypefaceProc with the modern SkDeserialProcs::fTypefaceStreamProc. The changes are consistent and update the function signature for DeserializeTypefaceWithoutData and its usage accordingly. I have a couple of minor suggestions to improve code consistency and adherence to the style guide regarding parameter naming in the function declaration and definition.
SkDeserialProcs::fTypefaceProc took a void* and size_t, but the expectation was that the void* was a SkStream** and the size_t was always sizeof(SkStream*). Users should now use the less confusing replacement SkDeserialProcs::fTypefaceStreamProc which takes an SkStream&.
SkDeserialProcs::fTypefaceProc took a void* and size_t, but the expectation was that the void* was a SkStream** and the size_t was always sizeof(SkStream*). Users should now use the less confusing replacement SkDeserialProcs::fTypefaceStreamProc which takes an SkStream&.
SkDeserialProcs::fTypefaceProc took a void* and size_t, but the expectation was that the void* was a SkStream** and the size_t was always sizeof(SkStream*). Users should now use the less confusing replacement SkDeserialProcs::fTypefaceStreamProc which takes an SkStream&.
SkDeserialProcs::fTypefaceProc took a void* and size_t, but the expectation was that the void* was a SkStream** and the size_t was always sizeof(SkStream*). Users should now use the less confusing replacement SkDeserialProcs::fTypefaceStreamProc which takes an SkStream&.