-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Update CHANGELOG at head for 3.38.7 stable hotfix #180986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the CHANGELOG.md file to include the entry for the 3.38.7 hotfix. The change is correct, but the changelog entry is a direct copy of the issue title, which is discouraged by the project's contribution guidelines. I've suggested a minor rephrasing to align with the best practices.
|
|
||
| ### [3.38.7](https://github.com/flutter/flutter/releases/tag/3.38.7) | ||
|
|
||
| - [flutter/179857](https://github.com/flutter/flutter/issues/179857) - `flutter run -d all` crashes if multiple devices are available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog entry is a direct copy of the issue title. The project's contribution guidelines for changelogs recommend writing a descriptive summary instead of copy-pasting issue titles. While the current text is descriptive, rephrasing it would better align with the guidelines.
| - [flutter/179857](https://github.com/flutter/flutter/issues/179857) - `flutter run -d all` crashes if multiple devices are available. | |
| - [flutter/179857](https://github.com/flutter/flutter/issues/179857) - The `flutter run -d all` command crashes when multiple devices are available. |
References
- The repository style guide requires following the Flutter contribution guide. The guidelines for writing changelog entries, found in
CHANGELOG.mdanddocs/releases/Hotfix-Documentation-Best-Practices.md, specify that issue titles should not be copy-pasted. Instead, a descriptive summary of the problem should be written to help users. (link)
camsim99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10/10
Updates the CHANGELOG following the 3.38.7 stable hotfix release. Includes Includes flutter#180867
Updates the CHANGELOG following the 3.38.7 stable hotfix release. Includes Includes flutter#180867
Updates the CHANGELOG following the 3.38.7 stable hotfix release. Includes
Includes #180867