Skip to content

Conversation

@walley892
Copy link
Contributor

Updates the CHANGELOG following the 3.38.7 stable hotfix release. Includes

Includes #180867

@walley892 walley892 requested a review from camsim99 January 14, 2026 17:50
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CHANGELOG.md file to include the entry for the 3.38.7 hotfix. The change is correct, but the changelog entry is a direct copy of the issue title, which is discouraged by the project's contribution guidelines. I've suggested a minor rephrasing to align with the best practices.


### [3.38.7](https://github.com/flutter/flutter/releases/tag/3.38.7)

- [flutter/179857](https://github.com/flutter/flutter/issues/179857) - `flutter run -d all` crashes if multiple devices are available.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The changelog entry is a direct copy of the issue title. The project's contribution guidelines for changelogs recommend writing a descriptive summary instead of copy-pasting issue titles. While the current text is descriptive, rephrasing it would better align with the guidelines.

Suggested change
- [flutter/179857](https://github.com/flutter/flutter/issues/179857) - `flutter run -d all` crashes if multiple devices are available.
- [flutter/179857](https://github.com/flutter/flutter/issues/179857) - The `flutter run -d all` command crashes when multiple devices are available.
References
  1. The repository style guide requires following the Flutter contribution guide. The guidelines for writing changelog entries, found in CHANGELOG.md and docs/releases/Hotfix-Documentation-Best-Practices.md, specify that issue titles should not be copy-pasted. Instead, a descriptive summary of the problem should be written to help users. (link)

Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10/10

@walley892 walley892 added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 14, 2026
@auto-submit auto-submit bot added this pull request to the merge queue Jan 14, 2026
Merged via the queue into flutter:master with commit 0709c50 Jan 14, 2026
9 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 14, 2026
patrickBillingsley pushed a commit to patrickBillingsley/flutter that referenced this pull request Jan 14, 2026
Updates the CHANGELOG following the 3.38.7 stable hotfix release.
Includes

Includes flutter#180867
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2026
ikramhasan pushed a commit to ikramhasan/flutter that referenced this pull request Jan 15, 2026
Updates the CHANGELOG following the 3.38.7 stable hotfix release.
Includes

Includes flutter#180867
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants