Add missing 'throw' to ImageFilter.shader's validation check by b-luk · Pull Request #180923 · flutter/flutter

b-luk · 2026-01-13T19:30:34Z

An error StringBuffer was created and populated, but was left unused. This PR throws it.

This fixes and re-enables fragment_shader_test.dart's ImageFilter error test. The test is re-enabled as an impeller-only test because ImageFilter.shader requires impeller.

Fixes #180763

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

gemini-code-assist

Code Review

This pull request correctly fixes an issue where an error message was being constructed but not thrown during ImageFilter.shader validation. The re-enabling of the corresponding test case is also appropriate. I've added one suggestion to improve the readability and correctness of the re-enabled test.

gemini-code-assist · 2026-01-13T19:34:52Z

+      const shaders = <String>[
+        'no_uniforms.frag.iplr',
+        'missing_size.frag.iplr',
+        'missing_texture.frag.iplr',
+      ];
+      const errors = <(bool, bool)>[(true, true), (true, false), (false, false)];
+      for (var i = 0; i < 3; i++) {
+        final String fileName = shaders[i];
+        final FragmentProgram program = await FragmentProgram.fromAsset(fileName);
+        final FragmentShader shader = program.fragmentShader();
+
+        Object? error;
+        try {
+          ImageFilter.shader(shader);
+        } catch (err) {
+          error = err;
+        }
+        expect(error is StateError, true);
+        final (bool floatError, bool samplerError) = errors[i];
+        if (floatError) {
+          expect(error.toString(), contains('shader has fewer than two float'));
+        }
+        if (samplerError) {
+          expect(error.toString(), contains('shader is missing a sampler uniform'));
+        }
      }


For better readability and to make the test cases more explicit, you could refactor this to use a list of records instead of two separate lists for shaders and error flags. This also addresses a likely typo in the errors list for 'missing_texture.frag.iplr'.

const testCases = [ (file: 'no_uniforms.frag.iplr', floatError: true, samplerError: true), (file: 'missing_size.frag.iplr', floatError: true, samplerError: false), (file: 'missing_texture.frag.iplr', floatError: false, samplerError: true), ]; for (final testCase in testCases) { final FragmentProgram program = await FragmentProgram.fromAsset(testCase.file); final FragmentShader shader = program.fragmentShader(); Object? error; try { ImageFilter.shader(shader); } catch (err) { error = err; } expect(error, isA<StateError>()); final String errorMessage = error.toString(); if (testCase.floatError) { expect(errorMessage, contains('shader has fewer than two float')); } if (testCase.samplerError) { expect(errorMessage, contains('shader is missing a sampler uniform')); } }

Good suggestion. The existing test did in fact have a typo and used "samplerError: false" for the missing_texture case. I applied the suggestion.

gaaclarke

lgtm, thanks @b-luk !

auto-submit · 2026-01-13T22:47:50Z

autosubmit label was removed for flutter/flutter/180923, because - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2026-01-14T00:02:24Z

autosubmit label was removed for flutter/flutter/180923, because - The status or check suite Linux linux_web_engine_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

…lutter/flutter#180923)

…#180923) An error StringBuffer was created and populated, but was left unused. This PR `throw`s it. This fixes and re-enables fragment_shader_test.dart's ImageFilter error test. The test is re-enabled as an impeller-only test because ImageFilter.shader requires impeller. Fixes flutter#180763 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…lutter/flutter#180923)

Fix fragment_shader_test.dart's ImageFilter error test

122da83

b-luk requested a review from gaaclarke January 13, 2026 19:30

github-actions Bot added the engine flutter/engine related. See also e: labels. label Jan 13, 2026

gemini-code-assist Bot reviewed Jan 13, 2026

View reviewed changes

gemini suggestion

22b28e5

gaaclarke approved these changes Jan 13, 2026

View reviewed changes

b-luk added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 13, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 13, 2026

Fix omit_obvious_local_variable_types lint

b03f2c0

b-luk added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 13, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 14, 2026

b-luk added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 14, 2026

auto-submit Bot added this pull request to the merge queue Jan 14, 2026

Merged via the queue into flutter:master with commit 72b2728 Jan 14, 2026
181 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 14, 2026

engine-flutter-autoroll mentioned this pull request Jan 14, 2026

Manual roll Flutter from 793b0b89e82e to 53e9db28740b (29 revisions) flutter/packages#10796

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 14, 2026

72b2728 Add missing 'throw' to ImageFilter.shader's validation check (f…

3f45ae3

…lutter/flutter#180923)

b-luk deleted the fragment-shader-test-imagefilter-error branch January 14, 2026 22:56

engine-flutter-autoroll mentioned this pull request Jan 15, 2026

Roll Flutter from b45a73b1dc3e to 3af33a0771e0 (41 revisions) flutter/packages#10804

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2026

72b2728 Add missing 'throw' to ImageFilter.shader's validation check (f…

0f33da6

…lutter/flutter#180923)

engine-flutter-autoroll mentioned this pull request Jan 15, 2026

Roll Flutter from b45a73b1dc3e to e5734555c2a8 (42 revisions) flutter/packages#10805

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2026

72b2728 Add missing 'throw' to ImageFilter.shader's validation check (f…

1f8dd0e

…lutter/flutter#180923)

engine-flutter-autoroll mentioned this pull request Jan 15, 2026

Roll Flutter from b45a73b1dc3e to f4d405c4ff26 (43 revisions) flutter/packages#10806

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2026

72b2728 Add missing 'throw' to ImageFilter.shader's validation check (f…

aeda96f

…lutter/flutter#180923)

engine-flutter-autoroll mentioned this pull request Jan 15, 2026

Roll Flutter from b45a73b1dc3e to 7d755d10933b (44 revisions) flutter/packages#10807

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2026

72b2728 Add missing 'throw' to ImageFilter.shader's validation check (f…

d3a301a

…lutter/flutter#180923)

engine-flutter-autoroll mentioned this pull request Jan 16, 2026

Roll Flutter from 48c247582e45 to 66b42dd1051a (50 revisions) flutter/packages#10818

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2026

72b2728 Add missing 'throw' to ImageFilter.shader's validation check (f…

829160b

…lutter/flutter#180923)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2026

72b2728 Add missing 'throw' to ImageFilter.shader's validation check (f…

d0d5d1e

…lutter/flutter#180923)

engine-flutter-autoroll mentioned this pull request Jan 16, 2026

Roll Flutter from 48c247582e45 to 66b42dd1051a (50 revisions) flutter/packages#10819

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2026

72b2728 Add missing 'throw' to ImageFilter.shader's validation check (f…

b7faa51

…lutter/flutter#180923)

engine-flutter-autoroll mentioned this pull request Jan 16, 2026

Roll Flutter from 48c247582e45 to 6159a34a6f52 (51 revisions) flutter/packages#10820

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2026

72b2728 Add missing 'throw' to ImageFilter.shader's validation check (f…

f3735d9

…lutter/flutter#180923)

engine-flutter-autoroll mentioned this pull request Jan 16, 2026

Roll Flutter from 48c247582e45 to 78d0d4bfb1d7 (52 revisions) flutter/packages#10821

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2026

72b2728 Add missing 'throw' to ImageFilter.shader's validation check (f…

51179e2

…lutter/flutter#180923)

engine-flutter-autoroll mentioned this pull request Jan 16, 2026

Roll Flutter from 48c247582e45 to 2057a543d6b4 (53 revisions) flutter/packages#10822

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 17, 2026

72b2728 Add missing 'throw' to ImageFilter.shader's validation check (f…

aee9878

…lutter/flutter#180923)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 17, 2026

72b2728 Add missing 'throw' to ImageFilter.shader's validation check (f…

261fcbf

…lutter/flutter#180923)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 17, 2026

72b2728 Add missing 'throw' to ImageFilter.shader's validation check (f…

b50669f

…lutter/flutter#180923)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2026

72b2728 Add missing 'throw' to ImageFilter.shader's validation check (f…

ec6904a

…lutter/flutter#180923)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2026

72b2728 Add missing 'throw' to ImageFilter.shader's validation check (f…

11a6041

…lutter/flutter#180923)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2026

72b2728 Add missing 'throw' to ImageFilter.shader's validation check (f…

166dbe6

…lutter/flutter#180923)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2026

72b2728 Add missing 'throw' to ImageFilter.shader's validation check (f…

18ab879

…lutter/flutter#180923)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2026

72b2728 Add missing 'throw' to ImageFilter.shader's validation check (f…

fbf2d88

…lutter/flutter#180923)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026

72b2728 Add missing 'throw' to ImageFilter.shader's validation check (f…

218835e

…lutter/flutter#180923)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026

72b2728 Add missing 'throw' to ImageFilter.shader's validation check (f…

eb7b7e7

…lutter/flutter#180923)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026

72b2728 Add missing 'throw' to ImageFilter.shader's validation check (f…

b796931

…lutter/flutter#180923)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026

72b2728 Add missing 'throw' to ImageFilter.shader's validation check (f…

2a63d5a

…lutter/flutter#180923)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026

72b2728 Add missing 'throw' to ImageFilter.shader's validation check (f…

beb11e1

…lutter/flutter#180923)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 21, 2026

72b2728 Add missing 'throw' to ImageFilter.shader's validation check (f…

ebe1e74

…lutter/flutter#180923)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 21, 2026

72b2728 Add missing 'throw' to ImageFilter.shader's validation check (f…

e1f968d

…lutter/flutter#180923)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 21, 2026

72b2728 Add missing 'throw' to ImageFilter.shader's validation check (f…

e4242f6

…lutter/flutter#180923)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2026

72b2728 Add missing 'throw' to ImageFilter.shader's validation check (f…

74e8a18

…lutter/flutter#180923)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2026

72b2728 Add missing 'throw' to ImageFilter.shader's validation check (f…

f4f8fcb

…lutter/flutter#180923)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2026

72b2728 Add missing 'throw' to ImageFilter.shader's validation check (f…

3fe30d6

…lutter/flutter#180923)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2026

72b2728 Add missing 'throw' to ImageFilter.shader's validation check (f…

b212e0a

…lutter/flutter#180923)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add missing 'throw' to ImageFilter.shader's validation check#180923

Add missing 'throw' to ImageFilter.shader's validation check#180923
auto-submit[bot] merged 3 commits into
flutter:masterfrom
b-luk:fragment-shader-test-imagefilter-error

b-luk commented Jan 13, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Jan 13, 2026

Uh oh!

b-luk Jan 13, 2026

Uh oh!

gaaclarke left a comment

Uh oh!

auto-submit Bot commented Jan 13, 2026

Uh oh!

auto-submit Bot commented Jan 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

b-luk commented Jan 13, 2026

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

b-luk Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit Bot commented Jan 13, 2026

Uh oh!

auto-submit Bot commented Jan 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants