In flutter_test_performance, consider the blank line at the start of "flutter test" output to be optional. #180911
+3
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…"flutter test" output to be optional. flutter_test_performance runs a "flutter test" command and parses its output. The parser expects the output to begin with a blank line. That line is no longer present after the roll to version 1.29 of the Dart test package (see flutter#180886) Fixes flutter#180903
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the output parser in dev/devicelab/bin/tasks/flutter_test_performance.dart. The condition for detecting the 'loading' phase of a test run has been altered. Previously, the 'loading' line was only expected after a blank line was printed. The change removes the step.index >= TestStep.testWritesFirstCarriageReturn.index constraint, allowing the 'loading' line to be processed even if an initial blank line is not present in the flutter test output. Additionally, a comment has been updated to explain that the initial blank line is optional depending on the Dart test package version.
jtmcdole
approved these changes
Jan 13, 2026
Contributor
|
autosubmit label was removed for flutter/flutter/180911, because - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 14, 2026
…tart of "flutter test" output to be optional. (flutter/flutter#180911)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 14, 2026
… start of "flutter test" output to be optional. (flutter/flutter#180911)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 14, 2026
… start of "flutter test" output to be optional. (flutter/flutter#180911)
This was referenced Jan 14, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 14, 2026
…tart of "flutter test" output to be optional. (flutter/flutter#180911)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 14, 2026
…tart of "flutter test" output to be optional. (flutter/flutter#180911)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 15, 2026
…tart of "flutter test" output to be optional. (flutter/flutter#180911)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 15, 2026
…tart of "flutter test" output to be optional. (flutter/flutter#180911)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 15, 2026
…tart of "flutter test" output to be optional. (flutter/flutter#180911)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 15, 2026
…tart of "flutter test" output to be optional. (flutter/flutter#180911)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 15, 2026
…tart of "flutter test" output to be optional. (flutter/flutter#180911)
ikramhasan
pushed a commit
to ikramhasan/flutter
that referenced
this pull request
Jan 15, 2026
…"flutter test" output to be optional. (flutter#180911) flutter_test_performance runs a "flutter test" command and parses its output. The parser expects the output to begin with a blank line. That line is no longer present after the roll to version 1.29 of the Dart test package (see flutter#180886) Fixes flutter#180903
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 16, 2026
…tart of "flutter test" output to be optional. (flutter/flutter#180911)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 16, 2026
…tart of "flutter test" output to be optional. (flutter/flutter#180911)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 16, 2026
…tart of "flutter test" output to be optional. (flutter/flutter#180911)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 16, 2026
…tart of "flutter test" output to be optional. (flutter/flutter#180911)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 16, 2026
…tart of "flutter test" output to be optional. (flutter/flutter#180911)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 16, 2026
…tart of "flutter test" output to be optional. (flutter/flutter#180911)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 16, 2026
…tart of "flutter test" output to be optional. (flutter/flutter#180911)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter_test_performance runs a "flutter test" command and parses its output. The parser expects the output to begin with a blank line. That line is no longer present after the roll to version 1.29 of the Dart test package (see #180886)
Fixes #180903