Skip to content

Update discussion of iOS/macOS testing#180898

Merged
auto-submit[bot] merged 2 commits into
masterfrom
plugin-swift-test-update
Jan 14, 2026
Merged

Update discussion of iOS/macOS testing#180898
auto-submit[bot] merged 2 commits into
masterfrom
plugin-swift-test-update

Conversation

@stuartmorgan-g

Copy link
Copy Markdown
Contributor
  • Adds references to Swift Testing to the sections discussion running XCTests.
  • Updates the outdated guidance to use Obj-C for new iOS test setup
  • Removes the instructions for adding XCTest test targets to a plugin, as we have added it to all existing plugins, and it's part of the template now so will automatically exist in new plugins.
  • Remove discussion of OCMock, because we should not be adding new usage of OCMock at this point.

See #180787

- Adds references to Swift Testing to the sections discussion running XCTests.
- Updates the outdated guidance to use Obj-C for new iOS test setup
- Removes the instructions for adding XCTest test targets to a plugin, as we have added it to all existing plugins, and it's part of the template now so will automatically exist in new plugins.
@github-actions github-actions Bot added package flutter/packages repository. See also p: labels. team-ecosystem Owned by Ecosystem team d: docs/ flutter/flutter/docs, for contributors labels Jan 13, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for iOS and macOS plugin testing. The changes include adding references to Swift Testing, updating guidance to prefer Swift over Objective-C for new tests, and removing instructions for setting up XCTest targets and using OCMock. The updates are a good improvement. I've added a couple of suggestions to fix minor inconsistencies in the updated instructions to enhance clarity and correctness.

Comment thread docs/ecosystem/testing/Plugin-Tests.md Outdated
Comment thread docs/ecosystem/testing/Plugin-Tests.md Outdated

@jmagman jmagman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I forgot about these docs.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 14, 2026
@auto-submit auto-submit Bot added this pull request to the merge queue Jan 14, 2026
Merged via the queue into master with commit bd16c23 Jan 14, 2026
13 of 14 checks passed
@auto-submit auto-submit Bot deleted the plugin-swift-test-update branch January 14, 2026 22:45
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 14, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2026
ikramhasan pushed a commit to ikramhasan/flutter that referenced this pull request Jan 15, 2026
- Adds references to Swift Testing to the sections discussion running
XCTests.
- Updates the outdated guidance to use Obj-C for new iOS test setup
- Removes the instructions for adding XCTest test targets to a plugin,
as we have added it to all existing plugins, and it's part of the
template now so will automatically exist in new plugins.
- Remove discussion of OCMock, because we should not be adding new usage
of OCMock at this point.

See flutter#180787
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 17, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 17, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 17, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 21, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 21, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 21, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

d: docs/ flutter/flutter/docs, for contributors package flutter/packages repository. See also p: labels. team-ecosystem Owned by Ecosystem team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants