Make sure that a Form doesn't crash in 0x0 environment#180792
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a test case to address an issue where a Form widget with zero area could crash. The new test verifies that a Form can be rendered with zero size. My feedback focuses on making the test more robust by ensuring it triggers the validation logic that was causing the crash, thereby fully covering the reported issue.
| const Directionality( | ||
| textDirection: TextDirection.ltr, | ||
| child: Center( | ||
| child: SizedBox.shrink(child: Form(child: Text('X'))), |
Contributor
There was a problem hiding this comment.
To properly test the scenario described in issue #6537, autovalidateMode should be set to AutovalidateMode.always. This will trigger the validation logic within the FormState.build method, which is where the crash occurs when the Form has zero area and no View ancestor is found.
Suggested change
| child: SizedBox.shrink(child: Form(child: Text('X'))), | |
| child: SizedBox.shrink(child: Form(autovalidateMode: AutovalidateMode.always, child: Text('X'))), |
victorsanni
approved these changes
Jan 12, 2026
dkwingsmt
approved these changes
Jan 13, 2026
Contributor
|
@ahmedsameha1 FYI there is a merge conflict, could you fix it before we merge this? |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 21, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 21, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 21, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 22, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 22, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 22, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 23, 2026
flutter-zl
pushed a commit
to flutter-zl/flutter
that referenced
this pull request
Feb 10, 2026
This is my attempt to handle flutter#6537 for the Form widget. Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my attempt to handle #6537 for the Form widget.