Implement superellipse support for CupertinoFocusHalo by O-Hannonen · Pull Request #180724 · flutter/flutter

O-Hannonen · 2026-01-09T08:31:00Z

This PR closes #180719

Related to this and this.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

gemini-code-assist

Code Review

This pull request introduces support for superellipse shapes in CupertinoFocusHalo by refactoring it to use ShapeDecoration and adding a CupertinoFocusHalo.withRoundedSuperellipse constructor. The changes are well-structured and include corresponding test updates. I've found one potential type safety issue in the implementation and a minor documentation typo, which I've detailed in a comment.

…no-focus-halo

dkwingsmt

LGTM, thank you!

…no-focus-halo

MitchellGoodwin

LGTM as well!

…no-focus-halo

…ter/flutter#180724)

feat: implement superellipse support

1191c7c

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository f: focus Focus traversal, gaining or losing focus labels Jan 9, 2026

gemini-code-assist Bot reviewed Jan 9, 2026

View reviewed changes

Comment thread packages/flutter/lib/src/cupertino/cupertino_focus_halo.dart Outdated

fix: review fixes

e42efa3

victorsanni requested a review from dkwingsmt January 9, 2026 23:33

Merge branch 'master' into 180719-add-superellipse-support-to-cuperti…

a078bba

…no-focus-halo

dkwingsmt approved these changes Jan 12, 2026

View reviewed changes

Comment thread packages/flutter/lib/src/cupertino/cupertino_focus_halo.dart

O-Hannonen and others added 2 commits January 12, 2026 18:31

fix: review fixes

309729a

Merge branch 'master' into 180719-add-superellipse-support-to-cuperti…

31d7384

…no-focus-halo

dkwingsmt requested a review from MitchellGoodwin January 12, 2026 23:11

MitchellGoodwin approved these changes Jan 14, 2026

View reviewed changes

MitchellGoodwin reviewed Jan 14, 2026

View reviewed changes

Comment thread packages/flutter/lib/src/cupertino/cupertino_focus_halo.dart

O-Hannonen and others added 2 commits January 15, 2026 08:14

fix: fix broken test

a5dfc5e

Merge branch 'master' into 180719-add-superellipse-support-to-cuperti…

16116db

…no-focus-halo

dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 15, 2026

auto-submit Bot added this pull request to the merge queue Jan 15, 2026

Merged via the queue into flutter:master with commit df73099 Jan 15, 2026
71 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 15, 2026

engine-flutter-autoroll mentioned this pull request Jan 15, 2026

Roll Flutter from b45a73b1dc3e to 3af33a0771e0 (41 revisions) flutter/packages#10804

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2026

df7309946 Implement superellipse support for CupertinoFocusHalo (flut…

0adce14

…ter/flutter#180724)

engine-flutter-autoroll mentioned this pull request Jan 15, 2026

Roll Flutter from b45a73b1dc3e to e5734555c2a8 (42 revisions) flutter/packages#10805

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2026

df7309946 Implement superellipse support for CupertinoFocusHalo (flut…

940145d

…ter/flutter#180724)

engine-flutter-autoroll mentioned this pull request Jan 15, 2026

Roll Flutter from b45a73b1dc3e to f4d405c4ff26 (43 revisions) flutter/packages#10806

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2026

df7309946 Implement superellipse support for CupertinoFocusHalo (flut…

abb441a

…ter/flutter#180724)

engine-flutter-autoroll mentioned this pull request Jan 15, 2026

Roll Flutter from b45a73b1dc3e to 7d755d10933b (44 revisions) flutter/packages#10807

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2026

df7309946 Implement superellipse support for CupertinoFocusHalo (flut…

8319684

…ter/flutter#180724)

engine-flutter-autoroll mentioned this pull request Jan 15, 2026

Manual roll Flutter from b45a73b1dc3e to 7d755d10933b (44 revisions) flutter/packages#10809

Closed

engine-flutter-autoroll mentioned this pull request Jan 16, 2026

Roll Flutter from 48c247582e45 to 2057a543d6b4 (53 revisions) flutter/packages#10822

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2026

df7309946 Implement superellipse support for CupertinoFocusHalo (flut…

0015c7f

…ter/flutter#180724)

engine-flutter-autoroll mentioned this pull request Jan 17, 2026

Roll Flutter from 48c247582e45 to 7bc5493d88bf (70 revisions) flutter/packages#10823

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 17, 2026

df7309946 Implement superellipse support for CupertinoFocusHalo (flut…

31090c6

…ter/flutter#180724)

engine-flutter-autoroll mentioned this pull request Jan 17, 2026

Roll Flutter from 48c247582e45 to 7bc5493d88bf (70 revisions) flutter/packages#10824

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 17, 2026

df7309946 Implement superellipse support for CupertinoFocusHalo (flut…

1b6af28

…ter/flutter#180724)

engine-flutter-autoroll mentioned this pull request Jan 17, 2026

Roll Flutter from 48c247582e45 to 2bb464851daf (71 revisions) flutter/packages#10825

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 17, 2026

df7309946 Implement superellipse support for CupertinoFocusHalo (flut…

28554f3

…ter/flutter#180724)

engine-flutter-autoroll mentioned this pull request Jan 18, 2026

Roll Flutter from 48c247582e45 to d20405293d08 (78 revisions) flutter/packages#10826

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2026

df7309946 Implement superellipse support for CupertinoFocusHalo (flut…

da9066d

…ter/flutter#180724)

engine-flutter-autoroll mentioned this pull request Jan 18, 2026

Roll Flutter from 48c247582e45 to d20405293d08 (78 revisions) flutter/packages#10827

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2026

df7309946 Implement superellipse support for CupertinoFocusHalo (flut…

319f150

…ter/flutter#180724)

engine-flutter-autoroll mentioned this pull request Jan 19, 2026

Roll Flutter from 48c247582e45 to 8329989d2978 (79 revisions) flutter/packages#10829

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2026

df7309946 Implement superellipse support for CupertinoFocusHalo (flut…

5cd0175

…ter/flutter#180724)

engine-flutter-autoroll mentioned this pull request Jan 19, 2026

Roll Flutter from 48c247582e45 to d21322b1b67b (80 revisions) flutter/packages#10830

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2026

df7309946 Implement superellipse support for CupertinoFocusHalo (flut…

5157c4e

…ter/flutter#180724)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2026

df7309946 Implement superellipse support for CupertinoFocusHalo (flut…

aa9ff75

…ter/flutter#180724)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026

df7309946 Implement superellipse support for CupertinoFocusHalo (flut…

8990c49

…ter/flutter#180724)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026

df7309946 Implement superellipse support for CupertinoFocusHalo (flut…

2f1e4e8

…ter/flutter#180724)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026

df7309946 Implement superellipse support for CupertinoFocusHalo (flut…

e1d1a61

…ter/flutter#180724)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026

df7309946 Implement superellipse support for CupertinoFocusHalo (flut…

d76b568

…ter/flutter#180724)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026

df7309946 Implement superellipse support for CupertinoFocusHalo (flut…

c4434bf

…ter/flutter#180724)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 21, 2026

df7309946 Implement superellipse support for CupertinoFocusHalo (flut…

d6e3336

…ter/flutter#180724)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 21, 2026

df7309946 Implement superellipse support for CupertinoFocusHalo (flut…

7e576cb

…ter/flutter#180724)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 21, 2026

df7309946 Implement superellipse support for CupertinoFocusHalo (flut…

ae1466f

…ter/flutter#180724)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2026

df7309946 Implement superellipse support for CupertinoFocusHalo (flut…

68f8774

…ter/flutter#180724)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2026

df7309946 Implement superellipse support for CupertinoFocusHalo (flut…

e9e8dcf

…ter/flutter#180724)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2026

df7309946 Implement superellipse support for CupertinoFocusHalo (flut…

b665786

…ter/flutter#180724)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2026

df7309946 Implement superellipse support for CupertinoFocusHalo (flut…

ea6a2e6

…ter/flutter#180724)

Piinks mentioned this pull request Jan 24, 2026

Flutter Notable Commits - 2026 #181433

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement superellipse support for CupertinoFocusHalo#180724

Implement superellipse support for CupertinoFocusHalo#180724
auto-submit[bot] merged 7 commits into
flutter:masterfrom
O-Hannonen:180719-add-superellipse-support-to-cupertino-focus-halo

O-Hannonen commented Jan 9, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

dkwingsmt left a comment

Uh oh!

Uh oh!

MitchellGoodwin left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

O-Hannonen commented Jan 9, 2026

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MitchellGoodwin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants