Skip to content

Add RawTooltipl example and test#180722

Merged
auto-submit[bot] merged 15 commits into
flutter:masterfrom
AbdeMohlbi:issue_180218_take_2
Jan 21, 2026
Merged

Add RawTooltipl example and test#180722
auto-submit[bot] merged 15 commits into
flutter:masterfrom
AbdeMohlbi:issue_180218_take_2

Conversation

@AbdeMohlbi

@AbdeMohlbi AbdeMohlbi commented Jan 9, 2026

Copy link
Copy Markdown
Member

Fixes: #180318
Relands #180691 (because of CLA issues).

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Jan 9, 2026
@AbdeMohlbi AbdeMohlbi changed the title add RwaTooltipl example and test Add RawTooltipl example and test Jan 9, 2026
@AbdeMohlbi AbdeMohlbi mentioned this pull request Jan 9, 2026
9 tasks
@AbdeMohlbi AbdeMohlbi marked this pull request as ready for review January 9, 2026 10:13
Comment thread examples/api/lib/widgets/raw_tooltip/raw_tooltip.0.dart Outdated
Comment thread examples/api/lib/widgets/raw_tooltip/raw_tooltip.0.dart Outdated
Comment thread examples/api/test/widgets/raw_tooltip/raw_tooltip.0_test.dart Outdated
import 'package:flutter_test/flutter_test.dart';

void main() {
testWidgets('RawTooltip is visible when tapping button', (

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add another test that shows the tooltip is always shown on hover.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done can you check again ?

child: Text('I am a RawToolTip message'),
);
},
child: Container(color: Colors.blue, height: 100, width: 200),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add some text in this container that clarifies the tooltip is always shown when hovered, and that pressing the FAB will manually trigger the tooltip to be displayed.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@victorsanni i did update the example because the tooltip that will appear on hover on top of the text which may be confusing , now it is positioned to the right:

Before After
Screenshot 2026-01-14 at 18 35 48 Screenshot 2026-01-14 at 18 35 34

AbdeMohlbi and others added 3 commits January 13, 2026 07:01
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>

@huycozy huycozy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing the work! LGTM except some @victorsanni 's comments.

Comment thread examples/api/test/widgets/raw_tooltip/raw_tooltip.0_test.dart Outdated
@AbdeMohlbi AbdeMohlbi requested a review from huycozy January 16, 2026 10:53
padding: const EdgeInsets.all(8),
alignment: Alignment.center,
child: const Text(
'Hover to always show the tooltip.\n'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The language here is not wrong, but a little misleading. It could be interpreted as "temporarily hovering will show the tooltip permanently". I think a better and more succinct way to phrase this is "Hover over this box or tap on the FAB to show the tooltip".

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done can you check again

Comment thread examples/api/test/widgets/raw_tooltip/raw_tooltip.0_test.dart Outdated
Comment thread examples/api/test/widgets/raw_tooltip/raw_tooltip.0_test.dart Outdated
Comment thread examples/api/test/widgets/raw_tooltip/raw_tooltip.0_test.dart Outdated
Comment thread examples/api/test/widgets/raw_tooltip/raw_tooltip.0_test.dart Outdated

expect(find.text(rawTooltipText), findsOneWidget);

addTearDown(pointer.removePointer);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need an addTearDown for a method called at the end of the test anyways?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
AbdeMohlbi and others added 4 commits January 17, 2026 08:07
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
@AbdeMohlbi AbdeMohlbi added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 21, 2026
@auto-submit auto-submit Bot added this pull request to the merge queue Jan 21, 2026
Merged via the queue into flutter:master with commit 3b666a0 Jan 21, 2026
71 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 21, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2026
flutter-zl pushed a commit to flutter-zl/flutter that referenced this pull request Feb 10, 2026
Fixes: flutter#180318
Relands flutter#180691 (because of CLA issues).


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add example for RawTooltipState.ensureTooltipVisible

3 participants