Add RawTooltipl example and test#180722
Conversation
| import 'package:flutter_test/flutter_test.dart'; | ||
|
|
||
| void main() { | ||
| testWidgets('RawTooltip is visible when tapping button', ( |
There was a problem hiding this comment.
Maybe add another test that shows the tooltip is always shown on hover.
There was a problem hiding this comment.
done can you check again ?
| child: Text('I am a RawToolTip message'), | ||
| ); | ||
| }, | ||
| child: Container(color: Colors.blue, height: 100, width: 200), |
There was a problem hiding this comment.
Maybe add some text in this container that clarifies the tooltip is always shown when hovered, and that pressing the FAB will manually trigger the tooltip to be displayed.
There was a problem hiding this comment.
@victorsanni i did update the example because the tooltip that will appear on hover on top of the text which may be confusing , now it is positioned to the right:
| Before | After |
|---|---|
![]() |
![]() |
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
huycozy
left a comment
There was a problem hiding this comment.
Thank you for doing the work! LGTM except some @victorsanni 's comments.
| padding: const EdgeInsets.all(8), | ||
| alignment: Alignment.center, | ||
| child: const Text( | ||
| 'Hover to always show the tooltip.\n' |
There was a problem hiding this comment.
The language here is not wrong, but a little misleading. It could be interpreted as "temporarily hovering will show the tooltip permanently". I think a better and more succinct way to phrase this is "Hover over this box or tap on the FAB to show the tooltip".
There was a problem hiding this comment.
done can you check again
|
|
||
| expect(find.text(rawTooltipText), findsOneWidget); | ||
|
|
||
| addTearDown(pointer.removePointer); |
There was a problem hiding this comment.
Do we need an addTearDown for a method called at the end of the test anyways?
There was a problem hiding this comment.
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
Fixes: flutter#180318 Relands flutter#180691 (because of CLA issues). ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Victor Sanni <victorsanniay@gmail.com>


Fixes: #180318
Relands #180691 (because of CLA issues).
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.