-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Also host build-tools 33.0.1, platform-34, and platform-35 in our android_sdk bundle #180653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
…in our android_sdk bundle (flutter/flutter#180653)
… our android_sdk bundle (flutter/flutter#180653)
… our android_sdk bundle (flutter/flutter#180653)
… our android_sdk bundle (flutter/flutter#180653)
… our android_sdk bundle (flutter/flutter#180653)
… our android_sdk bundle (flutter/flutter#180653)
… our android_sdk bundle (flutter/flutter#180653)
… our android_sdk bundle (flutter/flutter#180653)
… our android_sdk bundle (flutter/flutter#180653)
… our android_sdk bundle (flutter/flutter#180653)
… our android_sdk bundle (flutter/flutter#180653)
See #172956 (comment), but basically we use these in ci, and if we put them in the bundle we eliminate more downloading, which has caused flakes.
38 instead of 37 because I ran the script once without java on my path, which meant before I could ctrl+c we registered an empty https://chrome-infra-packages.appspot.com/p/flutter/android/sdk/all/mac-amd64/+/xLObmfS7IH8ElsjrUJNC8YjtTB5R8oYuYv8765UuwzsC, so that would have conflicted and been a headache to remove the tag from.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.