Improve code quality in KeyboardManagerTest.java
#180625
Conversation
|
Can you expand on why the static modifiers are not necessary? I especially appreciate you fixing the long values to use L instead of l. https://google.github.io/styleguide/javaguide.html#s4.8.8-numeric-literals |
@reidbaker |
| */ | ||
| @FunctionalInterface | ||
| static interface ChannelCallHandler extends BiConsumer<JSONObject, Consumer<Boolean>> {} | ||
| interface ChannelCallHandler extends BiConsumer<JSONObject, Consumer<Boolean>> {} |
There was a problem hiding this comment.
These interfaces are not inside another interface they are inside KeyboardManagerTest. So I dont think they match the description you gave for why it is safe to remove.
Ah you also said nested in a class. LGTM
This change :
assertargument .static modifiers.'long' literal '0x666677778888l' ends with lowercase 'l'.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.