Make sure that a Draggable doesn't crash in 0x0 environment #180380
Merged
+23
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a widget test to ensure that Draggable widgets do not crash when placed in a zero-sized area. The test correctly sets up the scenario, but it does not trigger a drag gesture, which is necessary to reproduce the crash described in the associated issue. I've suggested an addition to the test to initiate a drag gesture, which will properly verify the fix.
| ), | ||
| ), | ||
| ); | ||
| expect(tester.getSize(find.byType(Draggable<bool>)), Size.zero); |
Contributor
There was a problem hiding this comment.
The test sets up the zero-sized Draggable correctly, but it doesn't attempt to drag it. The crash described in issue #6537 occurs when a drag is initiated. To properly test the fix, we should simulate a drag gesture on the Draggable.
expect(tester.getSize(find.byType(Draggable<bool>)), Size.zero);
// Start a drag gesture to ensure it doesn't crash.
final TestGesture gesture = await tester.startGesture(tester.getCenter(find.byType(Draggable<bool>)));
await gesture.up();
Contributor
There was a problem hiding this comment.
I think this isn't true and the test is fine as-is, right?
justinmc
approved these changes
Dec 30, 2025
| ), | ||
| ), | ||
| ); | ||
| expect(tester.getSize(find.byType(Draggable<bool>)), Size.zero); |
Contributor
There was a problem hiding this comment.
I think this isn't true and the test is fine as-is, right?
victorsanni
approved these changes
Dec 31, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 6, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 6, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 6, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 6, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 6, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 6, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 7, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 7, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 7, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 7, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to handle #6537 for the Draggable widget.