Make sure that an AnimatedGrid doesn't crash in 0x0 environment #180159
+26
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a regression test to ensure that AnimatedGrid does not crash when rendered in a zero-sized environment. My review points out that the test may not be correctly targeting the scenario described in the associated issue, as it uses a different grid delegate. I've suggested a change to align the test with the original problem.
| child: AnimatedGrid( | ||
| controller: controller, | ||
| itemBuilder: (_, int index, _) => Text('$index'), | ||
| gridDelegate: const SliverGridDelegateWithFixedCrossAxisCount(crossAxisCount: 2), |
Contributor
There was a problem hiding this comment.
The issue this PR aims to fix is specific to SliverGridDelegateWithMaxCrossAxisExtent, which can compute a crossAxisCount of 0 when the available crossAxisExtent is 0, leading to a division by zero. This test uses SliverGridDelegateWithFixedCrossAxisCount, which has a fixed crossAxisCount and doesn't trigger the bug. To properly test the fix, you should use SliverGridDelegateWithMaxCrossAxisExtent.
Suggested change
| gridDelegate: const SliverGridDelegateWithFixedCrossAxisCount(crossAxisCount: 2), | |
| gridDelegate: const SliverGridDelegateWithMaxCrossAxisExtent(maxCrossAxisExtent: 150.0), |
victorsanni
approved these changes
Dec 24, 2025
dkwingsmt
approved these changes
Dec 26, 2025
Contributor
dkwingsmt
left a comment
There was a problem hiding this comment.
Checklist:
- The test is in the correct file
- The test name goes “does not crash at zero area”
- The target widget is wrapped by
Center(or is fullscreen) - The target widget does not have an overlay, or the overlay is tested
- The target widget is expected to have a size of exactly
Size.zero
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 27, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 27, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 28, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 28, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 29, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Dec 29, 2025
Roll Flutter from 6ff7f30 to 60d8165 (32 revisions) flutter/flutter@6ff7f30...60d8165 2025-12-29 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from xn1U9DUFEpB4f6vG-... to DdllqZRZYriOd7Q8v... (flutter/flutter#180356) 2025-12-28 engine-flutter-autoroll@skia.org Roll Dart SDK from 17d51009282c to df175c998021 (1 revision) (flutter/flutter#180349) 2025-12-28 engine-flutter-autoroll@skia.org Roll Dart SDK from d4a92c2c69bf to 17d51009282c (1 revision) (flutter/flutter#180346) 2025-12-28 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from jVkEEUxyGeemuu2HE... to xn1U9DUFEpB4f6vG-... (flutter/flutter#180343) 2025-12-27 engine-flutter-autoroll@skia.org Roll Dart SDK from 3b84125003a1 to d4a92c2c69bf (1 revision) (flutter/flutter#180331) 2025-12-27 engine-flutter-autoroll@skia.org Roll Skia from e6e535aec613 to c29a475066f5 (1 revision) (flutter/flutter#180322) 2025-12-27 ahmedsameha1@gmail.com Make sure that a WidgetsApp doesn't crash in 0x0 environment (flutter/flutter#180224) 2025-12-27 ahmedsameha1@gmail.com Make sure that an AnimatedSize doesn't crash in 0x0 environment (flutter/flutter#180174) 2025-12-27 ahmedsameha1@gmail.com Make sure that an AnimatedGrid doesn't crash in 0x0 environment (flutter/flutter#180159) 2025-12-27 ahmedsameha1@gmail.com Make sure that an AnimatedCrossFade does not crash in 0x0 environment (flutter/flutter#180088) 2025-12-27 ahmedsameha1@gmail.com Make sure that an AnimatedList doesn't crash in 0x0 environment (flutter/flutter#180123) 2025-12-26 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from mZlbuHta7S71Quawk... to jVkEEUxyGeemuu2HE... (flutter/flutter#180317) 2025-12-26 engine-flutter-autoroll@skia.org Roll Dart SDK from 6b2c3716be54 to 3b84125003a1 (1 revision) (flutter/flutter#180316) 2025-12-26 engine-flutter-autoroll@skia.org Roll Dart SDK from 18f6751c5ccc to 6b2c3716be54 (1 revision) (flutter/flutter#180252) 2025-12-26 engine-flutter-autoroll@skia.org Roll Skia from 07c59737d265 to e6e535aec613 (1 revision) (flutter/flutter#180303) 2025-12-25 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 2q71ydbnIhmBUiNOF... to mZlbuHta7S71Quawk... (flutter/flutter#180290) 2025-12-25 engine-flutter-autoroll@skia.org Roll Skia from 6d0a1b03e9c7 to 07c59737d265 (1 revision) (flutter/flutter#180289) 2025-12-25 engine-flutter-autoroll@skia.org Roll Skia from 2b5d93b62a3f to 6d0a1b03e9c7 (1 revision) (flutter/flutter#180279) 2025-12-25 engine-flutter-autoroll@skia.org Roll Skia from 3544942c9d42 to 2b5d93b62a3f (1 revision) (flutter/flutter#180276) 2025-12-24 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 5EgkVbjGVZmCFPdtR... to 2q71ydbnIhmBUiNOF... (flutter/flutter#180274) 2025-12-24 engine-flutter-autoroll@skia.org Roll Packages from 5e3a766 to 2164da9 (4 revisions) (flutter/flutter#180271) 2025-12-24 engine-flutter-autoroll@skia.org Roll Skia from 988a48f7a944 to 3544942c9d42 (1 revision) (flutter/flutter#180267) 2025-12-24 fluttergithubbot@gmail.com Marks Mac_arm64_mokey native_assets_android to be unflaky (flutter/flutter#180263) 2025-12-24 engine-flutter-autoroll@skia.org Roll Skia from 51a05ce05880 to 988a48f7a944 (1 revision) (flutter/flutter#180256) 2025-12-24 34465683+rkishan516@users.noreply.github.com fix: exclude semantics for disabled dates (flutter/flutter#178981) 2025-12-24 engine-flutter-autoroll@skia.org Roll Skia from 7fe9b93153f8 to 51a05ce05880 (1 revision) (flutter/flutter#180253) 2025-12-24 116356835+AbdeMohlbi@users.noreply.github.com Enhance documentation for sortable column behavior (flutter/flutter#180011) 2025-12-24 engine-flutter-autoroll@skia.org Roll Skia from a0f18947bc1b to 7fe9b93153f8 (4 revisions) (flutter/flutter#180247) 2025-12-23 engine-flutter-autoroll@skia.org Roll Skia from bdb147ae3040 to a0f18947bc1b (2 revisions) (flutter/flutter#180241) 2025-12-23 engine-flutter-autoroll@skia.org Roll Dart SDK from 94b05f717ba3 to 18f6751c5ccc (1 revision) (flutter/flutter#180236) 2025-12-23 kazbek.sultanov.doc@gmail.com docs: clarify dropdown menu text clearing (flutter/flutter#179676) 2025-12-23 flar@google.com New optimized general convex path shadow algorithm (flutter/flutter#178370) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to handle #6537 for the AnimatedGrid widget.