use a libcxx abi namespace compatible with lldb #180134
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
9d97b7c to
053181b
Compare
LLDB's type formatters expect the libcxx ABI namespace to start with two leading underscores.
See LLDB Discourse Thread and LLDB Sources
Fixes #180132
Note that this change requires a complete rebuild of the engine sources - see related #180128
Pre-launch Checklist
///).