Fix linter warnings in AccessibilityBridgeTest.java
#180118
Conversation
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request addresses a number of linter warnings in AccessibilityBridgeTest.java, primarily by correcting the argument order in assertEquals calls to the standard (expected, actual) format and replacing generic assertions with more specific ones like assertNull, assertTrue, and assertFalse. These changes improve the readability and maintainability of the test suite. Additionally, the switch to StandardCharsets is a good practice. I've added one comment to fix an assertEquals that was missed to ensure consistency across the file.
engine/src/flutter/shell/platform/android/test/io/flutter/view/AccessibilityBridgeTest.java
Outdated
Show resolved
Hide resolved
…/AccessibilityBridgeTest.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
autosubmit label was removed for flutter/flutter/180118, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
|
autosubmit label was removed for flutter/flutter/180118, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
This change fixes some of the linter warnings about wrong order of arguments passed to
asserts, and fixes a small warning aboutCharsetusage, an example of these warnings :before:
after:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.